Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Remove references to npm from docs #3587

Merged
merged 10 commits into from
Dec 6, 2023

Conversation

critesjosh
Copy link
Contributor

This PR removes references to installing @aztec/aztec-sandbox and @aztec/cli via NPM in favor of installing via Docker. It also updates notes about types imports for the token contract contract tutorial and the token reference in the "writing a dapp" tutorial.

Note: recent additions broke the Quickstart guide. The docs got out of sync with the latest version because docs are always tested against master. This should be fixed with the new release going out tomorrow morning, so I'm not bothering to change it now, but we should test the Quickstart page again once the new release goes out. @catmcgee do you think we should implement docs versioning to help prevent this from happening? It will increase the maintenance overhead of the docs.

closes #3540 #3541

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@critesjosh critesjosh changed the title Docs/jc/remove npm refs chore(docs): Remove references to npm from docs Dec 5, 2023
@critesjosh critesjosh marked this pull request as ready for review December 6, 2023 14:06
@critesjosh critesjosh requested a review from alexghr December 6, 2023 14:07

```shell
npm install -g @aztec/cli
/bin/bash -c "$(curl -fsSL 'https://sandbox.aztec.network')"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will eventually get changed to install.aztec.network but I'm not sure when.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, ill leave it for now then.

@critesjosh critesjosh merged commit 50351c7 into rk/no_sandbox_npm Dec 6, 2023
82 checks passed
@critesjosh critesjosh deleted the docs/jc/remove-npm-refs branch December 6, 2023 19:53
docs/docs/dev_docs/cli/cli-commands.md Show resolved Hide resolved
docs/docs/dev_docs/cli/cli-commands.md Show resolved Hide resolved
docs/docs/dev_docs/cli/cli-commands.md Show resolved Hide resolved

### Note on Linux

If you are running Linux, you will need to set the context (because Docker Desktop runs in a VM by default). See [this page](https://docs.docker.com/desktop/faqs/linuxfaqs/#what-is-the-difference-between-docker-desktop-for-linux-and-docker-engine) for more information. You can do this by running:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@critesjosh critesjosh restored the docs/jc/remove-npm-refs branch December 12, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants