Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: making blocks tree root part of block hash preimage + refactor #3489

Closed
wants to merge 9 commits into from

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Nov 30, 2023

  1. Fixes Unify ordering in BlockHeader::serialize and in the block hash preimage #3442
  2. Fixes feat: make blocks tree root part of the block hash preimage #3482
  3. using the block header from aztec-nr,
  4. rename historic_block_data file which I forgot in my previous PR

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@benesjan benesjan force-pushed the janb/circuits-block-nuke branch from 3efc1e7 to 091979a Compare December 1, 2023 08:38
@benesjan benesjan changed the title feat: nuking Block struct in noir circuits feat: making blocks tree root part of block hash preimage + refactor Dec 1, 2023
@benesjan benesjan marked this pull request as draft December 1, 2023 13:28
@benesjan benesjan force-pushed the janb/circuits-block-nuke branch from 20f060a to faa6a92 Compare December 1, 2023 16:15
@benesjan benesjan force-pushed the janb/circuits-block-nuke branch from faa6a92 to 8ad1f9c Compare December 4, 2023 08:00
@benesjan
Copy link
Contributor Author

We will do a larger refactor of all the types so this PR is no longer relevant.

@benesjan benesjan closed this Dec 11, 2023
@ludamad ludamad deleted the janb/circuits-block-nuke branch August 22, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
1 participant