-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): build bb.js in docs build script #3306
Conversation
docs/scripts/build.sh
Outdated
@@ -17,6 +17,14 @@ if [ -n "$NETLIFY" ]; then | |||
cd .. | |||
echo Working dir $(pwd) | |||
|
|||
# Build bb.js | |||
cd barretenberg/ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this follow the same pattern as build_package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can update. I don't think this builds though.
Are you able to build docs (yarn build
in ./docs/
) on your machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the late response, i fell behind on this at istanbul.
I have just run it ok on the mainframe, does netlify have a docker container build option, if its not building there its probably due to the lack of required dependencies like clang16 etc.
I think the better solution is to use netlify CLI in our build pipeline and push the built site to netlify. See #3336 |
The docs need to build the latest bb.js now to build correctly, after this PR.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.