Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): build bb.js in docs build script #3306

Closed
wants to merge 7 commits into from

Conversation

critesjosh
Copy link
Contributor

The docs need to build the latest bb.js now to build correctly, after this PR.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@critesjosh critesjosh requested a review from catmcgee November 14, 2023 05:13
@@ -17,6 +17,14 @@ if [ -n "$NETLIFY" ]; then
cd ..
echo Working dir $(pwd)

# Build bb.js
cd barretenberg/ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this follow the same pattern as build_package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can update. I don't think this builds though.

Are you able to build docs (yarn build in ./docs/) on your machine?

Copy link
Member

@Maddiaa0 Maddiaa0 Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late response, i fell behind on this at istanbul.
I have just run it ok on the mainframe, does netlify have a docker container build option, if its not building there its probably due to the lack of required dependencies like clang16 etc.

@Maddiaa0 Maddiaa0 marked this pull request as ready for review November 20, 2023 14:35
@critesjosh
Copy link
Contributor Author

critesjosh commented Nov 20, 2023

I think the better solution is to use netlify CLI in our build pipeline and push the built site to netlify. See #3336

@critesjosh critesjosh closed this Nov 20, 2023
@ludamad ludamad deleted the docs/jc/build-bbjs branch August 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants