Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unboxing - nargo.toml injection of "-" for "_" #3018

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fix: unboxing - nargo.toml injection of "-" for "_" #3018

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22f1988
fix nargo.toml injection of "-" for "_"
dan-aztec Oct 24, 2023
cf2af46
Merge branch 'master' into dan/fix-box-dep-injection
dan-aztec Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion yarn-project/cli/src/unbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,11 @@ async function updateNargoToml(tag: string, outputPath: string, log: LogFn): Pro
if (key) {
// Replace the line, which was configured for compiling within the `aztec-packages` monorepo. We replace
// the local path with `git` and `directory` fields with a `tag` field, which points to the tagged release
return `${key} = { git="https://github.com/AztecProtocol/aztec-packages/", tag="${tag}", directory="yarn-project/aztec-nr/${key}" }`;
// note that the key has a "_" in the name, but we use "-" in the github repo folder
return `${key} = { git="https://github.com/AztecProtocol/aztec-packages/", tag="${tag}", directory="yarn-project/aztec-nr/${key.replace(
'_',
'-',
)}" }`;
}
return line;
});
Expand Down