Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: console-only token box #3002

Closed
wants to merge 2 commits into from
Closed

feat: console-only token box #3002

wants to merge 2 commits into from

Conversation

benesjan
Copy link
Contributor

Fixes: #2972

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@benesjan benesjan marked this pull request as draft October 24, 2023 12:49
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/react 18.2.31 None +2 380 kB types
@typescript-eslint/parser 6.9.0 None +10 3.39 MB jameshenry
@types/node 20.8.8 None +0 3.92 MB types
react 18.2.0 None +0 316 kB gnoff
react-dom 18.2.0 None +2 4.91 MB gnoff

@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • note_trial_decrypting_time_in_ms (8): 6.00 (+50%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit c50aefb6 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,984 867,320 3,449,588
l1_rollup_execution_gas 842,071 3,594,428 22,204,957
l2_block_processing_time_in_ms 2,330 (+2%) 8,767 34,284
note_successful_decrypting_time_in_ms 706 2,550 (+1%) 9,757
note_trial_decrypting_time_in_ms ⚠️ 6.00 (+50%) 108 (+3%) 137 (+1%)
l2_block_building_time_in_ms 15,796 62,798 251,520
l2_block_rollup_simulation_time_in_ms 13,210 52,561 210,312
l2_block_public_tx_process_time_in_ms 2,547 (+1%) 10,117 (+1%) 40,749 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 25,161 (+1%) 48,477
note_history_successful_decrypting_time_in_ms 6,162 (+1%) 12,184 (+1%)
note_history_trial_decrypting_time_in_ms 121 148 (+1%)
node_database_size_in_bytes 1,630,216 1,095,351
pxe_database_size_in_bytes 27,188 54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 82.4 61,697 18,841
private-kernel-ordering 50.6 24,233 8,089
base-rollup 2,084 656,309 811
root-rollup 89.4 (-3%) 4,072 1,097
private-kernel-inner 58.8 (-1%) 81,504 18,841
public-kernel-private-input 46.5 41,455 18,841
public-kernel-non-first-iteration 28.9 41,497 18,841
merge-rollup 0.891 (+3%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 29,394

@benesjan benesjan closed this Oct 30, 2023
@benesjan benesjan reopened this Oct 30, 2023
@benesjan benesjan closed this Oct 30, 2023
@benesjan benesjan deleted the janb/no-ui-token-box branch January 2, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a console-only Token box
2 participants