fix: Pending commitments contract using the wrong number of arguments

[kevaundray]

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

• If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
• I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
• Every change is related to the PR description.
• I have linked this pull request to relevant issues (if any exist).

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 69c1d663 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,960	868,232	3,449,624
l1_rollup_execution_gas	842,047	3,595,340	22,204,993
l2_block_processing_time_in_ms	1,028 (-1%)	3,898 (-1%)	15,329 (-1%)
note_successful_decrypting_time_in_ms	332 (-1%)	1,026 (-1%)	3,910 (-3%)
note_trial_decrypting_time_in_ms	35.0 (-12%)	107 (-1%)	137 (-1%)
l2_block_building_time_in_ms	8,971 (-1%)	35,782	157,888
l2_block_rollup_simulation_time_in_ms	6,632	26,427	105,513
l2_block_public_tx_process_time_in_ms	2,301 (-2%)	9,232 (-2%)	51,721 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	11,534 (+2%)	22,461 (+2%)
note_history_successful_decrypting_time_in_ms	2,433 (+3%)	4,924 (+2%)
note_history_trial_decrypting_time_in_ms	122	152 (+4%)
node_database_size_in_bytes	1,629,619	1,100,283 (+1%)
pxe_database_size_in_bytes	27,188	54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	47.4	61,697	18,841
private-kernel-ordering	23.7 (+2%)	24,233	8,089
base-rollup	853	639,797	811
root-rollup	38.0	4,072	1,097
private-kernel-inner	43.1 (+1%)	81,504	18,841
public-kernel-private-input	47.9	41,455	18,841
public-kernel-non-first-iteration	31.0 (+1%)	41,497	18,841
merge-rollup	0.841 (+2%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,723	27,508

[kevaundray]

This PR extracts a two commits from #2592 by @sirasistant .

We were passing 16 arguments to a function that was asking for two arguments. This was a bug in the contract though it would have been caught earlier, if we had not had a feature in acvm which allows you to reassign the same values to witnesses. Before the change in #2592 we were re-assigning 0 to the same witness index which is why it was not caught.

I think we should remove this feature from ACVM and enforce that you can only assign a value to a witness once, cc @guipublic

[sirasistant]

This PR is also changing the circuits symlink to a file which I think would need a step in bootstrap to copy over

[sirasistant]

letsgo!