Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download msgpack #2885

Merged
merged 23 commits into from
Oct 17, 2023
Merged

feat: download msgpack #2885

merged 23 commits into from
Oct 17, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Oct 16, 2023

Downloads msgpack-c with same content using commit hash, from https://github.com/AztecProtocol/msgpack-c. As this is not our code (a few small patches to error-handling aside) and it's somewhat large at 7mb of code, itself bundling dependencies., so it's cleaner to not have it in tree.

@ludamad ludamad force-pushed the ad/feat/download-msgpack branch 2 times, most recently from c70d462 to 2977d11 Compare October 16, 2023 20:58
@ludamad ludamad force-pushed the ad/feat/download-msgpack branch from 2977d11 to 619b82a Compare October 16, 2023 21:29
@ludamad ludamad force-pushed the ad/feat/download-msgpack branch from fe6bf6b to d6fe483 Compare October 17, 2023 12:47
@AztecProtocol AztecProtocol deleted a comment from AztecBot Oct 17, 2023
@ludamad ludamad changed the base branch from master to feat/bump-msgpack October 17, 2023 14:09
@AztecBot
Copy link
Collaborator

AztecBot commented Oct 17, 2023

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 20ad5779 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,828 868,052 3,449,360
l1_rollup_execution_gas 841,915 3,595,160 22,204,729
l2_block_processing_time_in_ms 1,025 (-2%) 3,886 (-1%) 15,266 (-2%)
note_successful_decrypting_time_in_ms 329 (-1%) 1,035 (+1%) 3,885 (+3%)
note_trial_decrypting_time_in_ms 31.0 (-9%) 116 (+8%) 136
l2_block_building_time_in_ms 8,916 (-1%) 35,701 (-1%) 157,069 (+4%)
l2_block_rollup_simulation_time_in_ms 6,594 (-1%) 26,356 (-2%) 104,795 (-1%)
l2_block_public_tx_process_time_in_ms 2,282 9,222 ⚠️ 51,807 (+15%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 11,680 (+1%) 22,754 (+2%)
note_history_successful_decrypting_time_in_ms 2,464 (+4%) 4,992 (+4%)
note_history_trial_decrypting_time_in_ms 123 (-1%) 147 (-1%)
node_database_size_in_bytes 1,663,802 1,201,327
pxe_database_size_in_bytes 27,188 54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 47.4 (+9%) 61,697 (+9%) ⚠️ 18,841 (+28%)
private-kernel-ordering ⚠️ 23.5 (+11%) ⚠️ 24,233 (+20%) 8,089
base-rollup 854 639,797 (+1%) 811
root-rollup 37.8 (-1%) 4,072 1,097
private-kernel-inner ⚠️ 42.7 (+19%) ⚠️ 81,504 (+13%) ⚠️ 18,841 (+28%)
public-kernel-private-input 47.8 (+1%) ⚠️ 41,455 (+11%) ⚠️ 18,841 (+28%)
public-kernel-non-first-iteration ⚠️ 31.2 (+12%) ⚠️ 41,497 (+11%) ⚠️ 18,841 (+28%)
merge-rollup 0.841 (+3%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 27,508 (+2%)

Base automatically changed from feat/bump-msgpack to master October 17, 2023 14:32
@ludamad ludamad enabled auto-merge (squash) October 17, 2023 14:36
@ludamad ludamad merged commit 8ac8beb into master Oct 17, 2023
@ludamad ludamad deleted the ad/feat/download-msgpack branch October 17, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants