Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump msgpack #2884

Merged
merged 10 commits into from
Oct 17, 2023
Merged

feat: bump msgpack #2884

merged 10 commits into from
Oct 17, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Oct 16, 2023

Bumps msgpack for std::variant enhancements. This is fast-followed by https://github.com/AztecProtocol/aztec-packages/pull/2885/files which has the same commit hash but downloads https://github.com/AztecProtocol/msgpack-c. As this is not our code (a few small patches to error-handling aside) and it's somewhat large at 7mb of code, itself bundling dependencies., so it's cleaner to not have it in tree.

@AztecProtocol AztecProtocol deleted a comment from AztecBot Oct 16, 2023
@ludamad ludamad merged commit d7b7fb1 into master Oct 17, 2023
2 checks passed
@ludamad ludamad deleted the feat/bump-msgpack branch October 17, 2023 14:32
@AztecBot
Copy link
Collaborator

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 20ad5779 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,972 868,220 3,449,384
l1_rollup_execution_gas 842,059 3,595,328 22,204,753
l2_block_processing_time_in_ms 1,019 (-2%) 3,858 (-2%) 15,402 (-2%)
note_successful_decrypting_time_in_ms 320 (-4%) 976 (-5%) 3,669 (-2%)
note_trial_decrypting_time_in_ms ⚠️ 21.0 (-38%) ⚠️ 86.0 (-20%) 137 (+1%)
l2_block_building_time_in_ms 8,870 (-1%) 35,560 (-2%) 149,972 (-1%)
l2_block_rollup_simulation_time_in_ms 6,581 (-1%) 26,429 (-1%) 105,262 (-1%)
l2_block_public_tx_process_time_in_ms 2,249 (-2%) 9,010 (-2%) 44,049 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 11,449 (-1%) 22,153
note_history_successful_decrypting_time_in_ms 2,302 (-3%) 4,750 (-1%)
note_history_trial_decrypting_time_in_ms 123 (-1%) 145 (-2%)
node_database_size_in_bytes 1,658,564 1,195,986
pxe_database_size_in_bytes 27,188 54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 43.1 (-1%) 56,577 14,745
private-kernel-ordering 21.2 20,137 8,089
base-rollup 849 631,605 811
root-rollup 37.7 (-1%) 4,072 1,097
private-kernel-inner 35.2 (-2%) 72,288 14,745
public-kernel-private-input 46.5 (-1%) 37,359 14,745
public-kernel-non-first-iteration 27.9 37,401 14,745
merge-rollup 0.862 (+5%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 27,094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants