Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable noir private kernel circuit init #2781

Merged
merged 21 commits into from
Oct 11, 2023
Merged

chore: enable noir private kernel circuit init #2781

merged 21 commits into from
Oct 11, 2023

Conversation

kevaundray
Copy link
Contributor

This PR switches the cpp verion of private kernel init with the Noir version in pxe.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@kevaundray
add package.json and initial test
f2ad8b1
@kevaundray
add FixedLengthArray and change ReturnType to be an alias of the type…
45f2c34 
…script generated return type
@kevaundray
modify noir code to fix bug
cd013f7
@kevaundray
regenerate bindings
03f47ec
@kevaundray
modify type conversion code to cast to FixedSizeArrayLength -- typesc…
6d6f9b9 
…ript doesn't like this as is
@kevaundray
refactor test
f3f9f57
@kevaundray
remove .only
2a287b6
@kevaundray
Merge remote-tracking branch 'origin/feature_branch/private-kernel' i…
2bd6ac6 
…nto kw/abi-types-encoding
@kevaundray
fix import
5b6572f
@kevaundray
remove now redundant test and cleanup import
105401e
@kevaundray
move logic to abiEncode/Decode and execute into a function in index.ts
c886083
@kevaundray
comment update
737c6ca
@kevaundray
tech debt: expose makePrivateKernelInputsInit
6ed7f92
@kevaundray
redo tests to use executeInit
f5261c6
@kevaundray
given makePrivateKernelInputsInit, we can remove the manual instance …
93d33c5 
…we created
@kevaundray
replace privateKernelSimInit with Noir private kernel version
b2c4841
@kevaundray
remove if statement as its always false -- noir private kernel does n…
1dd0d63 
…ot return a CircuitError
@kevaundray
yarn formatting
1f77fd8
@kevaundray
Merge branch 'kw/abi-types-encoding' into kw/enable-noir-private-kernel
7577f53
Base automatically changed from kw/abi-types-encoding to feature_branch/private-kernel October 11, 2023 07:47
@sirasistant sirasistant marked this pull request as ready for review October 11, 2023 08:13
@sirasistant sirasistant merged commit 523d96a into feature_branch/private-kernel Oct 11, 2023
@sirasistant sirasistant deleted the kw/enable-noir-private-kernel branch October 11, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevaundray @sirasistant