Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Benchmark script fixes for master branch #2638

Merged
merged 2 commits into from
Oct 3, 2023
Merged

fix: Benchmark script fixes for master branch #2638

merged 2 commits into from
Oct 3, 2023

Conversation

spalladino
Copy link
Collaborator

@spalladino spalladino commented Oct 3, 2023 •
edited
Loading

Fixes issues in benchmark script for master branch:

  • Source logs folder path was incorrect (had an extra slash)
  • Downloaded logs check was incorrect (missing space in comparison)
  • Does not exit with error when on a tagged release

@spalladino spalladino requested a review from PhilWindle October 3, 2023 13:43
@spalladino spalladino enabled auto-merge (squash) October 3, 2023 13:59
@spalladino spalladino merged commit 0a161a4 into master Oct 3, 2023
@spalladino spalladino deleted the palla/bench-fixes branch October 3, 2023 14:02
@AztecBot AztecBot mentioned this pull request Oct 3, 2023
Merged
kevaundray pushed a commit that referenced this pull request Oct 3, 2023
@AztecBot
chore(master): Release 0.8.1 (#2640)
0731311 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.1</summary>

##
[0.8.1](aztec-packages-v0.8.0...aztec-packages-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](#2610))
([7cb7c58](7cb7c58))
* Benchmark script fixes for master branch
([#2638](#2638))
([0a161a4](0a161a4))
* Redirect sunset instructions
([#2646](#2646))
([9253442](9253442))
* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](#2649))
([84b8ff4](84b8ff4))


### Miscellaneous

* **benchmark:** Measure block sync time
([#2637](#2637))
([d11343f](d11343f))
* Update acir_tests script to point to master
([#2650](#2650))
([51d1e79](51d1e79))
</details>

<details><summary>barretenberg.js: 0.8.1</summary>

##
[0.8.1](barretenberg.js-v0.8.0...barretenberg.js-v0.8.1)
(2023-10-03)


### Bug Fixes

* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](#2649))
([84b8ff4](84b8ff4))
</details>

<details><summary>barretenberg: 0.8.1</summary>

##
[0.8.1](barretenberg-v0.8.0...barretenberg-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](#2610))
([7cb7c58](7cb7c58))


### Miscellaneous

* Update acir_tests script to point to master
([#2650](#2650))
([51d1e79](51d1e79))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Oct 5, 2023
@AztecBot
chore(master): Release 0.8.1 (#2640)
dc6de42 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.1</summary>

##
[0.8.1](AztecProtocol/aztec-packages@aztec-packages-v0.8.0...aztec-packages-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](AztecProtocol/aztec-packages#2610))
([7cb7c58](AztecProtocol/aztec-packages@7cb7c58))
* Benchmark script fixes for master branch
([#2638](AztecProtocol/aztec-packages#2638))
([0a161a4](AztecProtocol/aztec-packages@0a161a4))
* Redirect sunset instructions
([#2646](AztecProtocol/aztec-packages#2646))
([9253442](AztecProtocol/aztec-packages@9253442))
* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](AztecProtocol/aztec-packages#2649))
([84b8ff4](AztecProtocol/aztec-packages@84b8ff4))


### Miscellaneous

* **benchmark:** Measure block sync time
([#2637](AztecProtocol/aztec-packages#2637))
([d11343f](AztecProtocol/aztec-packages@d11343f))
* Update acir_tests script to point to master
([#2650](AztecProtocol/aztec-packages#2650))
([51d1e79](AztecProtocol/aztec-packages@51d1e79))
</details>

<details><summary>barretenberg.js: 0.8.1</summary>

##
[0.8.1](AztecProtocol/aztec-packages@barretenberg.js-v0.8.0...barretenberg.js-v0.8.1)
(2023-10-03)


### Bug Fixes

* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](AztecProtocol/aztec-packages#2649))
([84b8ff4](AztecProtocol/aztec-packages@84b8ff4))
</details>

<details><summary>barretenberg: 0.8.1</summary>

##
[0.8.1](AztecProtocol/aztec-packages@barretenberg-v0.8.0...barretenberg-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](AztecProtocol/aztec-packages#2610))
([7cb7c58](AztecProtocol/aztec-packages@7cb7c58))


### Miscellaneous

* Update acir_tests script to point to master
([#2650](AztecProtocol/aztec-packages#2650))
([51d1e79](AztecProtocol/aztec-packages@51d1e79))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Maddiaa0 pushed a commit that referenced this pull request Oct 6, 2023
@spalladino @Maddiaa0
fix: Benchmark script fixes for master branch (#2638)
045d448 
Fixes issues in benchmark script for `master` branch:
- Source logs folder path was incorrect (had an extra slash)
- Downloaded logs check was incorrect (missing space in comparison)
- Does not exit with error when on a tagged release
Maddiaa0 pushed a commit that referenced this pull request Oct 6, 2023
@AztecBot @Maddiaa0
chore(master): Release 0.8.1 (#2640)
1501345 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.1</summary>

##
[0.8.1](aztec-packages-v0.8.0...aztec-packages-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](#2610))
([7cb7c58](7cb7c58))
* Benchmark script fixes for master branch
([#2638](#2638))
([0a161a4](0a161a4))
* Redirect sunset instructions
([#2646](#2646))
([9253442](9253442))
* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](#2649))
([84b8ff4](84b8ff4))


### Miscellaneous

* **benchmark:** Measure block sync time
([#2637](#2637))
([d11343f](d11343f))
* Update acir_tests script to point to master
([#2650](#2650))
([51d1e79](51d1e79))
</details>

<details><summary>barretenberg.js: 0.8.1</summary>

##
[0.8.1](barretenberg.js-v0.8.0...barretenberg.js-v0.8.1)
(2023-10-03)


### Bug Fixes

* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](#2649))
([84b8ff4](84b8ff4))
</details>

<details><summary>barretenberg: 0.8.1</summary>

##
[0.8.1](barretenberg-v0.8.0...barretenberg-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](#2610))
([7cb7c58](7cb7c58))


### Miscellaneous

* Update acir_tests script to point to master
([#2650](#2650))
([51d1e79](51d1e79))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesjan benesjan benesjan approved these changes

@PhilWindle PhilWindle Awaiting requested review from PhilWindle

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spalladino @benesjan