Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor pedersen hash standard #2592

Merged
merged 160 commits into from
Oct 24, 2023
Merged
Show file tree
Hide file tree
Changes from 157 commits
Commits
Show all changes
160 commits
Select commit Hold shift + click to select a range
2acca41
added cycle_group class
zac-williamson Aug 15, 2023
4f885f6
fixed bugs in cycle_group add/sub/dbl
zac-williamson Aug 16, 2023
fbd9b40
variable-base scalar multiplication passes tests
zac-williamson Aug 17, 2023
55f7019
cycle_group::variable_batch_mul now supports input points that are at…
zac-williamson Aug 17, 2023
e339ba0
added an elliptic curve point doubling gate to the UltraPlonk arithme…
zac-williamson Aug 17, 2023
ce45f32
hash to curve
zac-williamson Aug 21, 2023
f5a9a5f
wip
zac-williamson Aug 25, 2023
604ad3f
fixed linting errors in proof_system/plookup_tables
zac-williamson Aug 26, 2023
c09483e
added refactored pedersen hash methods + stdlib::pedersen_hash (needs…
zac-williamson Aug 29, 2023
36624f3
fixed, tidy up, comments
zac-williamson Sep 2, 2023
0608a65
wip
zac-williamson Sep 10, 2023
dcec4f0
Merge remote-tracking branch 'origin/master' into zw/stdlib-cycle-gro…
charlielye Sep 15, 2023
afad6f0
completed merge of master
zac-williamson Sep 15, 2023
4283697
Merge branch 'master' into zw/stdlib-cycle-group-msm
zac-williamson Sep 15, 2023
43086fa
revert formatting
zac-williamson Sep 15, 2023
918410c
removed extra ecc gate methods from standard/turbo circuit builder
zac-williamson Sep 15, 2023
0db1732
wip
zac-williamson Sep 15, 2023
98e5261
PR changes
zac-williamson Sep 15, 2023
af2a6ac
fixed ecc_dbl gates incorrectly fusing into ecc_add gates
zac-williamson Sep 15, 2023
4426370
wip
zac-williamson Sep 15, 2023
fd0de30
compiler fixes
zac-williamson Sep 20, 2023
a29ebb3
compiler fox
zac-williamson Sep 20, 2023
79b17e1
compiler fox
zac-williamson Sep 20, 2023
a0c9f92
compiler fix
zac-williamson Sep 20, 2023
5e7a4d5
compiler fix
zac-williamson Sep 20, 2023
8b58e39
reverted schnorr
zac-williamson Sep 21, 2023
1bbe81d
updated schnorr to use new cycle_group methods
zac-williamson Sep 21, 2023
87ff132
compiler fix
zac-williamson Sep 21, 2023
9236506
revert pedersen c_bind
zac-williamson Sep 21, 2023
c899d90
revert crypto/schnorr
zac-williamson Sep 21, 2023
06c3261
updated c_binds
zac-williamson Sep 21, 2023
b24ded4
initial replacement of old pedersen with new pedersen
zac-williamson Sep 21, 2023
a5254f1
Merge branch 'master' into zw/stdlib-cycle-group-msm
zac-williamson Sep 21, 2023
6c8adcc
bugfix
zac-williamson Sep 22, 2023
0dfc607
Merge branch 'master' into zw/stdlib-cycle-group-msm
zac-williamson Sep 22, 2023
b8d0bfe
Merge branch 'zw/stdlib-cycle-group-msm' into zw/use-new-pedersen
zac-williamson Sep 22, 2023
da020b9
merge fix
zac-williamson Sep 22, 2023
b9273a1
wip
zac-williamson Sep 22, 2023
616e3d4
wip
zac-williamson Sep 22, 2023
72ce3e9
wip
zac-williamson Sep 28, 2023
841fb44
wip (precomputed generators at compile time)
zac-williamson Sep 28, 2023
da3da7b
yeet
zac-williamson Sep 28, 2023
d103d90
yeet
zac-williamson Sep 28, 2023
d7178bf
small cleanup
zac-williamson Sep 28, 2023
ca811ce
more yeet
zac-williamson Sep 28, 2023
6617fb7
Merge branch 'master' into zw/use-new-pedersen
zac-williamson Sep 29, 2023
61e6b29
merge fix wip
zac-williamson Sep 29, 2023
42ec6c0
removed pedersen_commitment::compress
zac-williamson Oct 2, 2023
30bbca3
typo fix
zac-williamson Oct 3, 2023
26a5f75
wip
zac-williamson Oct 3, 2023
a20d331
wip updating circuits generator syntax
zac-williamson Oct 3, 2023
256ff06
generator index fixes
zac-williamson Oct 3, 2023
179409a
hash to curve tweaks
zac-williamson Oct 4, 2023
0ab1267
reverted tweaks because clang hates constexpr vectors
zac-williamson Oct 4, 2023
6de00ab
fix tests
zac-williamson Oct 4, 2023
e5b86c7
dsl schnorr tests no longer use hardcoded signature
zac-williamson Oct 4, 2023
cf3b391
fixed bb-tests script
zac-williamson Oct 4, 2023
22a417f
wip
zac-williamson Oct 4, 2023
275cdbb
replaced string_view with string in GeneratorContext to prevent memor…
zac-williamson Oct 5, 2023
e5a0903
Merge branch 'master' into zw/use-new-pedersen
zac-williamson Oct 6, 2023
7f70d12
fixed cycle_group dbl bug (not handling points at infinity) + compile…
zac-williamson Oct 6, 2023
3fbae89
fixed error in cycle_group::dbl witness generation code
zac-williamson Oct 10, 2023
c9a548c
wip
zac-williamson Oct 10, 2023
0573f81
wip
zac-williamson Oct 10, 2023
2c62c09
wip
zac-williamson Oct 10, 2023
216cfbb
Delete barretenberg/ts/package-lock.json
zac-williamson Oct 10, 2023
e5b7839
wip
zac-williamson Oct 10, 2023
1d129a7
wip
zac-williamson Oct 10, 2023
bd88433
wip
zac-williamson Oct 10, 2023
ec765aa
updated js vkey
zac-williamson Oct 10, 2023
269ad63
comments, fixes, style changes
zac-williamson Oct 11, 2023
f08a218
more comments, fixes, style changes
zac-williamson Oct 11, 2023
6010d5e
reactivated plookup composer tests
zac-williamson Oct 11, 2023
49832c1
compiler fixes
zac-williamson Oct 11, 2023
a056ac3
compiler fix
zac-williamson Oct 11, 2023
d6323f6
compiler fixes. verification key hashes no longer take a generator index
zac-williamson Oct 11, 2023
4eb558c
compiler fix
zac-williamson Oct 11, 2023
12453bd
added missing c_bind methods
zac-williamson Oct 11, 2023
1d05055
Merge branch 'master' into zw/use-new-pedersen
zac-williamson Oct 11, 2023
046642f
wip
zac-williamson Oct 11, 2023
b40577f
test fixes
zac-williamson Oct 11, 2023
da894d4
comments
zac-williamson Oct 11, 2023
fea4990
Merge branch 'master' into zw/use-new-pedersen
zac-williamson Oct 11, 2023
89a8dc2
fix test script
zac-williamson Oct 11, 2023
8a64417
updated c_binds
zac-williamson Oct 11, 2023
93a658c
c_bind fixes
zac-williamson Oct 12, 2023
af5dda7
c_binds
zac-williamson Oct 12, 2023
4f335a4
c_binds
zac-williamson Oct 12, 2023
d20f1e7
c_binds
zac-williamson Oct 12, 2023
b8de252
cbinds
zac-williamson Oct 12, 2023
21af8a0
fix: Some fixes. (#2841)
charlielye Oct 13, 2023
dd9f1ec
cbinds
zac-williamson Oct 13, 2023
486d7aa
c_binds
zac-williamson Oct 13, 2023
0ca1fbd
c_binds
zac-williamson Oct 13, 2023
3e9000e
c_binds
zac-williamson Oct 13, 2023
6f1594e
aeroguhfael;irguahr c_bind
zac-williamson Oct 13, 2023
7eabdb6
change noir version
kevaundray Oct 13, 2023
5c59af8
change commit
kevaundray Oct 13, 2023
780bac5
update version to account for return-constant-error
kevaundray Oct 13, 2023
75c3723
update contracts
kevaundray Oct 13, 2023
a556370
change acvm_js
kevaundray Oct 13, 2023
c7fe365
delete old artifacts
kevaundray Oct 13, 2023
2c20e9a
recompile box artifacts -- these are not a part of the bootstrap it s…
kevaundray Oct 13, 2023
5216822
test: callstacks for private execution unit tests
sirasistant Oct 17, 2023
3e71bf8
match noir
kevaundray Oct 17, 2023
b0fb818
use old noir compiler version
kevaundray Oct 17, 2023
42badd2
updates snap
kevaundray Oct 17, 2023
7cdb3df
update acvm to point to a version just after the last aztec tag + new…
kevaundray Oct 17, 2023
f3b2cd1
use commit_native and take x value to match change we made for noir
kevaundray Oct 17, 2023
8e76c55
Revert "use commit_native and take x value to match change we made fo…
kevaundray Oct 17, 2023
c4e9078
yarn formatting
kevaundray Oct 17, 2023
8656867
formatting
kevaundray Oct 17, 2023
cbd56db
move `compute_tree_native` and `compute_tree_root_native` to circuits…
kevaundray Oct 17, 2023
52cedac
yarn
kevaundray Oct 17, 2023
9168cce
make an edit in barretenberg to invalidate CI cache
kevaundray Oct 17, 2023
fbfca1a
make circuit types match native_types
kevaundray Oct 18, 2023
33e1c12
[ci rebuild]
ludamad Oct 18, 2023
b93b399
Merge remote-tracking branch 'origin/master' into zw/use-new-pedersen
LeilaWang Oct 18, 2023
95d9a03
manually use new .wasm file without symlink
kevaundray Oct 18, 2023
f036f56
Merge branch 'zw/use-new-pedersen' of github.com:AztecProtocol/aztec-…
kevaundray Oct 18, 2023
c4deba8
Merge remote-tracking branch 'origin/zw/use-new-pedersen' into zw/use…
LeilaWang Oct 18, 2023
8e8a4ad
commit -> hash (hello Zac)
kevaundray Oct 18, 2023
82af2be
merkle_hash also hashes -- this should break noir
kevaundray Oct 18, 2023
a029ea9
Revert "manually use new .wasm file without symlink"
kevaundray Oct 18, 2023
5f2d34f
fix merge: copy file from master -- overwrites ala
kevaundray Oct 18, 2023
090af44
yarn formatting:fix
kevaundray Oct 18, 2023
00623fd
noir-contracts: remove unused dependency
kevaundray Oct 19, 2023
5ff11af
temp: use different pedersen hashing function that is implementable i…
kevaundray Oct 19, 2023
f09e6f8
remove unused import
kevaundray Oct 19, 2023
d488ff0
revert length_generator changes to circuits layer
kevaundray Oct 19, 2023
6563616
move those changes to barretenberg layer
kevaundray Oct 19, 2023
441041a
use barretenberg merkle_tree methods in circuits since we modified th…
kevaundray Oct 19, 2023
8ab1fe9
switch to noir compatible pedersen_hash
kevaundray Oct 19, 2023
ee5cee9
update snaps
kevaundray Oct 19, 2023
c203d30
updated bytecode
kevaundray Oct 19, 2023
78b66c7
update barretenberg test vectors
kevaundray Oct 19, 2023
db33801
joint split circuit change
kevaundray Oct 19, 2023
9da538e
update Blank.json -- are these ever valid?They contain personal paths
kevaundray Oct 19, 2023
6c18ccf
join-split gate change
kevaundray Oct 19, 2023
677ceae
use pedersenCompressInputs
kevaundray Oct 19, 2023
a59e6f2
update merkle tree test
kevaundray Oct 19, 2023
9f65b93
test: callstacks for private execution unit tests
sirasistant Oct 17, 2023
c444865
fix: fix pending commitments contract
sirasistant Oct 20, 2023
832de95
feat: private simulator enforces correct arguments
sirasistant Oct 20, 2023
5716878
wasm update
kevaundray Oct 20, 2023
949eb1a
update package.json
kevaundray Oct 20, 2023
14ae02f
update yarn.lock
kevaundray Oct 20, 2023
163bc93
Pedersen hash oracle call.
LeilaWang Oct 20, 2023
66f4cca
Update boxes.
LeilaWang Oct 20, 2023
9fdb1fb
fix: account contracts
sirasistant Oct 20, 2023
5c83b49
fix: contract address
sirasistant Oct 20, 2023
edc19d3
bump timeout
kevaundray Oct 21, 2023
bf5ed00
update timeout
kevaundray Oct 21, 2023
df605be
update timeout
kevaundray Oct 21, 2023
5fe48c3
formatting:fix
kevaundray Oct 21, 2023
a4205ab
chore: fixup refactor pedersen standard (#2882)
kevaundray Oct 22, 2023
86d4cf8
Merge branch 'master' into zw/use-new-pedersen
sirasistant Oct 23, 2023
5b5d1c5
Merge branch 'master' into zw/use-new-pedersen
kevaundray Oct 24, 2023
ed62d95
chore: update artifacts after master merge
sirasistant Oct 24, 2023
65cc870
Merge branch 'master' into zw/use-new-pedersen
sirasistant Oct 24, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions barretenberg/acir_tests/run_acir_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ set -eu
BIN=${BIN:-../cpp/build/bin/bb}
FLOW=${FLOW:-prove_and_verify}
CRS_PATH=~/.bb-crs
BRANCH="master"
BRANCH=kw/mv/new-pedersen
VERBOSE=${VERBOSE:-}
NAMED_TEST=${1:-}

Expand Down Expand Up @@ -41,7 +41,7 @@ fi
cd acir_tests

# Convert them to array
SKIP_ARRAY=(diamond_deps_0 workspace workspace_default_member)
SKIP_ARRAY=(diamond_deps_0 workspace workspace_default_member merkle_insert simple_shield pedersen_check schnorr)

function test() {
cd $1
Expand Down
1 change: 0 additions & 1 deletion barretenberg/cpp/scripts/bb-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ TESTS=(
crypto_blake2s_tests
crypto_blake3s_tests
crypto_ecdsa_tests
crypto_pedersen_commitment_tests
crypto_schnorr_tests
crypto_sha256_tests
ecc_tests
Expand Down
3 changes: 0 additions & 3 deletions barretenberg/cpp/src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ add_library(
$<TARGET_OBJECTS:crypto_blake2s_objects>
$<TARGET_OBJECTS:crypto_blake3s_objects>
$<TARGET_OBJECTS:crypto_ecdsa_objects>
$<TARGET_OBJECTS:crypto_generators_objects>
$<TARGET_OBJECTS:crypto_keccak_objects>
$<TARGET_OBJECTS:crypto_pedersen_commitment_objects>
$<TARGET_OBJECTS:crypto_pedersen_hash_objects>
Expand Down Expand Up @@ -142,7 +141,6 @@ if(WASM)
$<TARGET_OBJECTS:crypto_blake2s_objects>
$<TARGET_OBJECTS:crypto_blake3s_objects>
$<TARGET_OBJECTS:crypto_ecdsa_objects>
$<TARGET_OBJECTS:crypto_generators_objects>
$<TARGET_OBJECTS:crypto_keccak_objects>
$<TARGET_OBJECTS:crypto_pedersen_commitment_objects>
$<TARGET_OBJECTS:crypto_pedersen_hash_objects>
Expand Down Expand Up @@ -178,7 +176,6 @@ if(WASM)
$<TARGET_OBJECTS:ecc_objects>
$<TARGET_OBJECTS:crypto_blake2s_objects>
$<TARGET_OBJECTS:crypto_keccak_objects>
$<TARGET_OBJECTS:crypto_generators_objects>
$<TARGET_OBJECTS:crypto_schnorr_objects>
$<TARGET_OBJECTS:crypto_pedersen_hash_objects>
$<TARGET_OBJECTS:crypto_pedersen_commitment_objects>
Expand Down
4 changes: 1 addition & 3 deletions barretenberg/cpp/src/barretenberg/barretenberg.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
#include "serialize/test_helper.hpp"
#include "srs/global_crs.hpp"
#include "stdlib/commitment/pedersen/pedersen.hpp"
#include "stdlib/commitment/pedersen/pedersen_plookup.hpp"
#include "stdlib/encryption/ecdsa/ecdsa.hpp"
#include "stdlib/encryption/schnorr/schnorr.hpp"
#include "stdlib/hash/blake2s/blake2s.hpp"
Expand All @@ -60,9 +59,8 @@
#include "stdlib/primitives/curves/bn254.hpp"
#include "stdlib/primitives/field/array.hpp"
#include "stdlib/primitives/field/field.hpp"
#include "stdlib/primitives/group/group.hpp"
#include "stdlib/primitives/group/cycle_group.hpp"
#include "stdlib/primitives/packed_byte_array/packed_byte_array.hpp"
#include "stdlib/primitives/point/point.hpp"
#include "stdlib/primitives/uint/uint.hpp"
#include "stdlib/primitives/witness/witness.hpp"
#include "stdlib/recursion/aggregation_state/aggregation_state.hpp"
Expand Down
1 change: 0 additions & 1 deletion barretenberg/cpp/src/barretenberg/crypto/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
add_subdirectory(hmac)
add_subdirectory(generators)
add_subdirectory(blake2s)
add_subdirectory(blake3s)
add_subdirectory(blake3s_full)
Expand Down

This file was deleted.

This file was deleted.

Loading