Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: aztec-cli unbox "really empty box" #2388

Merged
merged 21 commits into from
Sep 19, 2023
Merged

feat: aztec-cli unbox "really empty box" #2388

merged 21 commits into from
Sep 19, 2023

Conversation

dan-aztec
Copy link
Contributor

@dan-aztec dan-aztec commented Sep 19, 2023 •
edited
Loading

provides a completely stripped down box with almost nothing, for full web developers who want control of their stack

image

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@socket-security
Copy link

socket-security bot commented Sep 19, 2023 •
edited
Loading

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@dan-aztec dan-aztec requested a review from LeilaWang September 19, 2023 05:59
@dan-aztec dan-aztec marked this pull request as ready for review September 19, 2023 05:59
LeilaWang
LeilaWang requested changes Sep 19, 2023
View reviewed changes
yarn-project/boxes/blank/src/tests/test.frontend.test.ts Outdated Show resolved Hide resolved
yarn-project/boxes/blank/.eslintrc.cjs Outdated Show resolved Hide resolved
yarn-project/boxes/blank/src/@types/index.d.ts Outdated Show resolved Hide resolved
yarn-project/boxes/blank/tsconfig.dest.json Outdated Show resolved Hide resolved
yarn-project/boxes/blank/src/typings.d.ts Outdated Show resolved Hide resolved
yarn-project/boxes/blank/README.md

This will generate a [Contract ABI](https://www.alchemy.com/overviews/what-is-an-abi-of-a-smart-contract-examples-and-usage) and TypeScript class for the Aztec smart contract in `src/contracts/main.nr`, which the frontend uses to generate the UI.

Note: the `compile` command seems to generate a Typescript file which needs a single change -
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is true, we should open an issue and fix the command so that the path can be correctly generated.

yarn-project/boxes/blank/package.json Outdated Show resolved Hide resolved
yarn-project/boxes/blank/src/contracts/src/main.nr Outdated Show resolved Hide resolved
yarn-project/boxes/blank/src/config.ts Outdated Show resolved Hide resolved
yarn-project/cli/src/unbox.ts Show resolved Hide resolved
LeilaWang
LeilaWang reviewed Sep 19, 2023
View reviewed changes
yarn-project/boxes/blank/README.md
yarn build
```

This sandbox requires [Docker](https://www.docker.com/) to be installed _and running_ locally. In the event the image needs updating, you can run `yarn install:sandbox` (see [sandbox docs](https://aztec-docs-dev.netlify.app/dev_docs/getting_started/sandbox) for more information.)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url will change. Remember to update it after official release.

@dan-aztec dan-aztec enabled auto-merge (squash) September 19, 2023 23:13
@dan-aztec dan-aztec disabled auto-merge September 19, 2023 23:20
@dan-aztec dan-aztec merged commit b57182d into master Sep 19, 2023
@dan-aztec dan-aztec deleted the dan/really-empty-box branch September 19, 2023 23:45
@AztecBot AztecBot mentioned this pull request Sep 19, 2023
Merged
PhilWindle pushed a commit that referenced this pull request Sep 20, 2023
@AztecBot
chore(master): Release 0.7.10 (#2401)
e4b559e 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.7.10</summary>

##
[0.7.10](aztec-packages-v0.7.9...aztec-packages-v0.7.10)
(2023-09-20)


### Features

* Aztec-cli unbox "really empty box"
([#2388](#2388))
([b57182d](b57182d))
* **docs:** Document noir macros
([#2016](#2016))
([1f1a17f](1f1a17f))
* **docs:** Include aztec rpc interface typedoc output in docs
([#2255](#2255))
([62c9e9b](62c9e9b))
* **token portal standard:** Create a token portal standard
([#2351](#2351))
([426a3ea](426a3ea))


### Bug Fixes

* **build:** Fix build system post deployment tests
([#2420](#2420))
([d509dc3](d509dc3))
* CLI encoding for arrays and structs
([#2407](#2407))
([85283bd](85283bd))
* Correct sandbox addresses in up-quick-start test
([#2412](#2412))
([974d859](974d859))
* **docs:** Revert include aztec rpc interface typedoc output in docs
([#2255](#2255))
([f852432](f852432))
* Handle falsy bigints in json-rpc
([#2403](#2403))
([d100650](d100650)),
closes
[#2402](#2402)
* **nargo_check.sh:** UNIX standard grep
([#2396](#2396))
([02e788a](02e788a))


### Miscellaneous

* **docs:** Note getter options
([#2411](#2411))
([8a95d8c](8a95d8c))
* Update docs url in config
([#2386](#2386))
([e44066d](e44066d))
</details>

<details><summary>barretenberg.js: 0.7.10</summary>

##
[0.7.10](barretenberg.js-v0.7.9...barretenberg.js-v0.7.10)
(2023-09-20)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.7.10</summary>

##
[0.7.10](barretenberg-v0.7.9...barretenberg-v0.7.10)
(2023-09-20)


### Miscellaneous

* **barretenberg:** Synchronize aztec-packages versions
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeilaWang LeilaWang LeilaWang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-aztec @LeilaWang