fix(ci): add install backend step in noir rebuild #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maddiaa0
changed the title
PhilWindle
approved these changes
Sep 11, 2023
kevaundray
reviewed
Sep 11, 2023
Comment on lines
+11
to
+12
| echo "Installing $BACKEND_NAME" | ||
| nargo backend install $BACKEND_NAME https://github.com/AztecProtocol/barretenberg/releases/download/barretenberg-v0.5.1/barretenberg-x86_64-linux-gnu.tar.gz |
There was a problem hiding this comment.
If there was no parallel compile, could we revert this PR?
Asking because:
- Theres a PR to compile contracts in parallel by Tom
- This is likely to be a footgun in the future
There was a problem hiding this comment.
Not a blocker on this PR
There was a problem hiding this comment.
Yep this is only an issue as we compile in parallel and each instance try's to fetch the backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installs the current version of acvm backend barretenberg before running the parallel compile. This prevents each step from attempting to download the backend at the same time