Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unencrypted logs from private functions (except private_token_contract) #1758

Closed
wants to merge 3 commits into from
Closed

chore: Remove unencrypted logs from private functions (except private_token_contract) #1758

wants to merge 3 commits into from

Conversation

suyash67
Copy link
Contributor

resolves #1689

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@suyash67 suyash67 changed the title Remove unencrypted logs from private functions (except private_token_contract) chore: Remove unencrypted logs from private functions (except private_token_contract) Aug 23, 2023
@suyash67 suyash67 force-pushed the sb/remove-unenc-logs-pvt-fn branch from 510836e to cef78cf Compare August 24, 2023 10:35
@suyash67 suyash67 marked this pull request as ready for review August 24, 2023 10:38
@suyash67 suyash67 requested a review from jeanmon August 24, 2023 10:38
@suyash67
Copy link
Contributor Author

Superseded by #1780

@suyash67 suyash67 closed this Aug 24, 2023
@ludamad ludamad deleted the sb/remove-unenc-logs-pvt-fn branch August 22, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanmon jeanmon jeanmon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Noir contract examples: don't emit unencrypted logs from private functions!
2 participants
@suyash67 @jeanmon