Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proving fails when circuit has size > ~500K #1739

Merged
merged 3 commits into from
Aug 22, 2023
Merged

fix: proving fails when circuit has size > ~500K #1739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1f107d
constant is now 2^23
kevaundray Aug 22, 2023
59b9e02
update constant on node cli
kevaundray Aug 22, 2023
45127b6
Merge branch 'master' into kw/srs-too-small-failing-test
kevaundray Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions circuits/cpp/barretenberg/cpp/src/barretenberg/bb/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@
#include <vector>

using namespace barretenberg;

uint32_t MAX_CIRCUIT_SIZE = 1 << 19;
// The maximum size that we can do in the browser is 2^19
// based on memory constraints for UltraPlonk.
// However, since this will be ran natively, we can increase the
// size.
uint32_t MAX_CIRCUIT_SIZE = 1 << 23;
std::string CRS_PATH = "./crs";
bool verbose = false;

Expand Down
4 changes: 2 additions & 2 deletions circuits/cpp/barretenberg/ts/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import { Command } from 'commander';
createDebug.log = console.error.bind(console);
const debug = createDebug('bb.js');

// Maximum we support.
const MAX_CIRCUIT_SIZE = 2 ** 19;
// Maximum we support natively. It is 2^19 for browser.
const MAX_CIRCUIT_SIZE = 2 ** 23;

function getBytecode(bytecodePath: string) {
const encodedCircuit = readFileSync(bytecodePath, 'utf-8');
Expand Down