chore: Enforce PR titles follow conventional commit specification #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
changed the title
kevaundray
changed the title
|
Thanks for doing this |
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Squashed commit of the following: commit 9c2a75e01cdb2b608be7984beb4a0f50c92ccc59 Author: ledwards2225 <[email protected]> Date: Mon Oct 3 17:14:08 2022 +0000 deleting unneeded added files in bb.js commit 52cf9402fbc27ad04b5a00c00bb5bd56b4fcd7fc Author: ledwards2225 <[email protected]> Date: Mon Oct 3 17:08:21 2022 +0000 checkout barretenberg.js from current defi HEAD commit 169758b8586e60caccf822d9e469d05c7ecfbf0f Author: ledwards2225 <[email protected]> Date: Mon Oct 3 16:57:47 2022 +0000 removing tracy and sandbox commit 424c32ea3dd4cd36c5c91cc6487ed705666b7f50 Author: ledwards2225 <[email protected]> Date: Fri Sep 30 15:24:30 2022 +0000 fixing verfier teest string errors and serialization faulres in ver_key commit bb65df8a5f8095d630398de1e49db290c8474e66 Author: ledwards2225 <[email protected]> Date: Wed Sep 21 20:11:00 2022 +0000 one small fix and commenting out some serialization tests with TODO-LDE tags to address when the time is right commit 6cbdccf8e68d07a4e662173977d57f7bad3f07a5 Merge: e44eb0122 836967001 Author: ledwards2225 <[email protected]> Date: Tue Sep 20 21:28:32 2022 +0000 Merge branch 'ec/poly' of github.com:AztecProtocol/aztec2-internal into ec/poly commit e44eb0122c4ae25629803b43053a58821207e2b5 Author: ledwards2225 <[email protected]> Date: Tue Sep 20 21:28:18 2022 +0000 minor naming fixes to fix a handful of tests plus some added comments around an interesting failure in the plookup tests commit 83696700166051f8b20e8d68775614040ec4802c Author: Emerson Clarke <[email protected]> Date: Tue Sep 20 22:11:37 2022 +0200 WASM calling convention debugging, serialized execute on the C++ functions, correct return values but still memory errors. All stdlib primitives tests passing. commit 85788be2694520e3dfbe9db554e9d8623a42e976 Author: ledwards2225 <[email protected]> Date: Mon Sep 19 17:58:31 2022 +0000 debugging comments for needed updates to serialization.hpp commit 19692b3c754c6a822f0394d8f815194cafba92df Author: ledwards2225 <[email protected]> Date: Mon Sep 19 16:37:37 2022 +0000 Fixing z poly over-indexing issue in perm widget that was allowing write to uninitialized memory commit 348897f0cc0f09e50b60de5cfd3bd11aed923e23 Author: Emerson Clarke <[email protected]> Date: Fri Sep 16 16:40:14 2022 +0200 Deserialization fidxes for rollup/proofs (no static buffers, though copying needs to be removed, this can be done with Stream/String from ec/bench branch), debugging and fixing WASM calles for IndexDB/Leveldown. std::info fix for std::cerr which was crashing WASM (likely due to trying to open file handles), this is now redirected to logstr. commit 59b4ce8b006f6859512f43bd51a082557a2c2003 Author: ledwards2225 <[email protected]> Date: Wed Sep 14 20:28:03 2022 +0000 some tweaks to fix the plookup tests commit fde9de210f1a57edc60ff9945fe736490e5c7f33 Author: Emerson Clarke <[email protected]> Date: Wed Sep 14 18:31:35 2022 +0200 Debugging WASM, added guard for plookup composer commit 79a48b210428958582b1211046d89e41af3c776a Author: ledwards2225 <[email protected]> Date: Wed Sep 14 13:12:39 2022 +0000 switching get calls from w_3 to w_3_lagrange in field tests commit 355cf01f6f4c8e42d9c9cfd548120f055f9b64fc Author: Emerson Clarke <[email protected]> Date: Wed Sep 14 11:17:09 2022 +0200 Cleanup serialization, fixed a few errors, and added implementation comments/explanations. commit d34d4183e06141a66bf1f27d16cdf89eabb241b7 Author: reasoning <[email protected]> Date: Tue Sep 13 18:08:59 2022 +0000 LevelDB proving key store tweaks for mainframe commit a1c6a0820ed73e2eb9270a97ba98d3a1293a4078 Author: Emerson Clarke <[email protected]> Date: Tue Sep 13 19:45:28 2022 +0200 Fixes to serialisation overloads B& binding to non pointer types and values causing copies. Added new overloads and fixed std vs serialize Argument Dependent Lookup rules. Compiler now correctly reports errors when the wrong serialization method is called. Introduced an _impl pattern to handle iostreams and buffers with safety. commit 797344cadabae4be209d5c5ed158a42683f13238 Author: ledwards2225 <[email protected]> Date: Mon Sep 12 20:19:37 2022 +0000 small fix to flush to make stdlib_bool.test_basic_operations pass commit 527a889a4e6bb3f9298d4cce89b9008fa1fba159 Author: ledwards2225 <[email protected]> Date: Mon Sep 12 17:57:10 2022 +0000 adding list of pre-computed polys to each composer so we can maintain consistent behavior with historical serialization routines commit e0b839dfd5d0c4f5d6d29c89f6998a7e547331db Author: ledwards2225 <[email protected]> Date: Fri Sep 9 17:11:22 2022 +0000 fixing the cache capacity estimate; badmul now passes commit 1a901899e4a55e003cd81c55cf59ba071aaffde2 Author: Emerson Clarke <[email protected]> Date: Thu Sep 8 20:56:37 2022 +0200 Adjusting guards and 4th round flush commit e5fc936f14980e4674d251d9c5125757d553a10f Author: Emerson Clarke <[email protected]> Date: Thu Sep 8 13:34:17 2022 +0200 Finally slayed the capacity/max_size dragon commit f82b5d9aa33be5641f8366e25642a7aa10fa2eed Author: Emerson Clarke <[email protected]> Date: Thu Sep 8 12:50:56 2022 +0200 Allow flush with no guard using sentinel for composer base and turbo composer init commit 700e280e023530a7468938ad1e1e50a18c16a4c9 Merge: dcfd252ec acd09d5a9 Author: Emerson Clarke <[email protected]> Date: Thu Sep 8 10:24:51 2022 +0200 Merge branch 'ec/poly' of github.com:AztecProtocol/aztec2-internal into ec/poly commit dcfd252ec202f4cc06b9f2e93aa0827625b1a705 Author: Emerson Clarke <[email protected]> Date: Thu Sep 8 10:07:06 2022 +0200 WASM safety on assert, and recursive guard count on cache guard commit acd09d5a9a7ea2c9e0b42acb68c6c27cc9f85d99 Author: ledwards2225 <[email protected]> Date: Wed Sep 7 21:29:54 2022 +0000 quick comment cleanup commit 427d586a32de24ad23224238756028e942be156d Author: ledwards2225 <[email protected]> Date: Wed Sep 7 20:45:57 2022 +0000 getting rid of proving_key::reset altogether commit e1dabaf90d13668e473aca9ce3f5da1b89330076 Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 19:40:15 2022 +0200 Moved flush logging commit 89365f67e1a82f14260f95450d917fcc5b1858ea Author: ledwards2225 <[email protected]> Date: Wed Sep 7 19:29:11 2022 +0000 Setting up automated computation of max cache capacity based on prover type and num gates commit a7c7108cc0eb5d0e45a724978a40f7aa35e65b54 Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 19:35:28 2022 +0200 Max size update after get commit 67d29112996469a3aec4dacbfa0ddf480d117bb5 Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 19:18:02 2022 +0200 Added sentinel value to allow flushing of items not currently in scope, and generalised flush to allow profiling with different capacities/methods. Camel case call to get method in wasm. commit 4158e39fde94433cc79b36a6b3b9eb95aeef5f04 Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 15:56:42 2022 +0200 Tweaked min size and flush loop, less size() calls and >= 0 commit a3d46be85b6dd72121f37feb21a9b0ee96c3792b Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 15:52:52 2022 +0200 Restored formatting, added min/max size and relocated to before and after flush since this catches all changes, and added to print(), also moved flush on get back to pre rather than post operation for memory safety. commit 1ef959deffa056c7c3d53fd821934320afea1402 Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 15:14:08 2022 +0200 Sandbox, debugging logstr/wasm imports, tweaks to scripts, 4th round forced flush in prover commit 1341d4aba99e5e231f73d3d3471df1d63ac20958 Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 12:12:30 2022 +0200 Eslint, async, await, bootstrap commit a3bccdba30032f87969a0320a49d045b4111b797 Author: ledwards2225 <[email protected]> Date: Tue Sep 6 21:40:22 2022 +0000 WIP automating max cache size based on prover type commit 776be5ad294215fa04be21ffd9d657e452c8aaca Author: reasoning <[email protected]> Date: Tue Sep 6 15:05:15 2022 +0000 Debug commit 23ff24c7b99b2102d138c5cedd72c151e23aa82f Author: reasoning <[email protected]> Date: Tue Sep 6 15:04:07 2022 +0000 WASM exports/imports, logstr fix, polynomial serialize size commit 25e78a0a4a01a033c199afb27bad2feb509b4f06 Author: reasoning <[email protected]> Date: Tue Sep 6 13:10:43 2022 +0000 Moving proving key store bindings to barretenberg WASM module init commit 94dd71b4a16fbead197e1c6e0721ad73f8723947 Author: reasoning <[email protected]> Date: Tue Sep 6 11:04:58 2022 +0000 WASM build commit 78021c67bdd4abe8666e2c5d0d28fb7b9a211369 Author: reasoning <[email protected]> Date: Tue Sep 6 10:59:29 2022 +0000 WASM build commit 0cd87f86d6297a105dc1a27ace9bae6167139599 Author: reasoning <[email protected]> Date: Tue Sep 6 10:57:45 2022 +0000 WASM build commit 96f1d831da71ef139ac0e35b279774fbd953f492 Author: reasoning <[email protected]> Date: Tue Sep 6 10:19:17 2022 +0000 Build fixes commit 9cb3a6b54286524ffff3a541b9a549fcc2c4b110 Author: reasoning <[email protected]> Date: Tue Sep 6 10:08:04 2022 +0000 Push model from JavaScript to WASM to deserialize polynomial after get commit 7147bb87ccf11e6e7b0101074462383b5243234d Author: reasoning <[email protected]> Date: Tue Sep 6 08:57:10 2022 +0000 WASM bindings, levelup (memdown+indexdb) commit 9927ed9986d06b063463ce0dd8b4a244384e36be Author: Emerson Clarke <[email protected]> Date: Mon Sep 5 13:07:10 2022 +0200 Delete store keys on get, further guards, debug logging of locks and flush. Tests now passing with 0.3mb cache size. commit 8f87181d860e6c078c3dece6c4d3e96571b554c5 Author: ledwards2225 <[email protected]> Date: Sun Sep 4 21:33:53 2022 +0000 delete all FFTs after quotient computation commit 14538fb4651c10b924d89f2f75262288def5b52f Author: ledwards2225 <[email protected]> Date: Sun Sep 4 20:28:41 2022 +0000 some general cleanup commit 4a7a31e3849854ffc7196fdf647173f33ba20f08 Author: ledwards2225 <[email protected]> Date: Sun Sep 4 16:52:32 2022 +0000 moving opening polys to the store commit fe4438b7d476b60933883872e4ac94c05b1f105c Author: ledwards2225 <[email protected]> Date: Sun Sep 4 14:49:47 2022 +0000 adding linear_poly to the store commit 6c839752c6d9470db76a6623019380e5c8a965fa Author: ledwards2225 <[email protected]> Date: Sun Sep 4 13:37:07 2022 +0000 add lagrange_1 to proving key commit a9954d5b755ec46f010e7bd40293b0badc27fd6b Author: ledwards2225 <[email protected]> Date: Sun Sep 4 12:24:09 2022 +0000 adding some polynomial deletion to avoid unneeded disk writes commit 4ee39a460fb041abe8972ab1bcf3fbb0a612fdd6 Author: ledwards2225 <[email protected]> Date: Fri Sep 2 15:29:11 2022 +0000 cleaning up the scratch space allocation.. again commit 2f058f2c340f08f2f9031549e1ae8804a2598f5a Author: Emerson Clarke <[email protected]> Date: Fri Sep 2 16:49:59 2022 +0200 Small cache capacity, guard/lock logging and work queue, debugging guard scopes, deallocate scratch space permutation widget commit 3fd6ebce1ba8e6b1d3babcefcfdd9ab14d7e780f Author: ledwards2225 <[email protected]> Date: Fri Sep 2 14:16:14 2022 +0000 cleaning out some unwanted memory initialization from reset() and adding scratch space for perm widget commit 5d685c32b9725dace58dacd7d7ba1c737b4553a5 Author: Luke Edwards <[email protected]> Date: Fri Sep 2 14:38:29 2022 +0200 test commit commit 795360f43c3d8cde743309d4c6d32a027b926a8a Author: Emerson Clarke <[email protected]> Date: Fri Sep 2 14:15:59 2022 +0200 Added assertions on polynomials due to test failures, added flush to c_bind/wasm interface at end of work queue processing, and added cache flush locking to work queue. commit 4fde47184ba2649c6953b9951d451ccf6f1c096a Author: Emerson Clarke <[email protected]> Date: Fri Sep 2 09:00:14 2022 +0200 Experimenting with different flush/modified placement commit 46e85a0566385c3b8cbde12af140d25b3a3c8b04 Author: Emerson Clarke <[email protected]> Date: Thu Sep 1 18:30:58 2022 +0200 Restored default in memory store (stdlib_uint.test_divide passes with this but not the leveldb store currently) commit 1294407aa65abe5e995a891f3238a8c17f0e2149 Author: Emerson Clarke <[email protected]> Date: Thu Sep 1 18:26:16 2022 +0200 Polynomial unit test, leveldb store, and serialize fixes commit 50939a3f0d345258292465e856003ff36fdfb814 Author: reasoning <[email protected]> Date: Thu Sep 1 13:51:52 2022 +0000 Simplify flush and test with different capacities commit c7c1689741ce989400a407459e6bfc8d256e3f28 Author: reasoning <[email protected]> Date: Thu Sep 1 13:33:56 2022 +0000 Disc size commit 7595c356eb5ff1e8fee60eed7bb107cc2d471176 Author: reasoning <[email protected]> Date: Thu Sep 1 13:25:06 2022 +0000 Fixed modified commit 49d42e0182306948dff676d22edc05ab349bf89a Author: reasoning <[email protected]> Date: Thu Sep 1 13:04:11 2022 +0000 Added guard logic for readonly access to cache, can't protect/scope the C bindings though commit 7fe0b6734ef3579839aa73afad53dd5be89b3570 Author: reasoning <[email protected]> Date: Thu Sep 1 12:40:56 2022 +0000 Added size in bytes to print functions commit 715dab101efc2c826b7548e1ce0113d3ebefc780 Author: reasoning <[email protected]> Date: Thu Sep 1 12:29:09 2022 +0000 Gitignore commit 2da2268e4f2008f4163339d782c4ab5fd4754cf6 Author: reasoning <[email protected]> Date: Thu Sep 1 12:27:31 2022 +0000 Fix allocated pages in move constructor commit e9e8d75e01d17bd43ca845d2083b1ae34199b930 Author: Emerson Clarke <[email protected]> Date: Thu Sep 1 14:25:57 2022 +0200 Fixed move semantics on cache and added more safety/cleanup to polynomial resize methods commit 782032944b2042e08c55df16d2377a3fffa1c325 Author: Emerson Clarke <[email protected]> Date: Thu Sep 1 13:48:13 2022 +0200 Fix move semantics on polynomial, and initial cache guard work commit a23be34b3a2f18afcd988884fdf7e4905aceb221 Author: ledwards2225 <[email protected]> Date: Thu Sep 1 10:56:51 2022 +0000 avoid giving the work queue a pointer to local copy of z commit 6d366e821e95503c7e562ccd57029079ed28de70 Author: ledwards2225 <[email protected]> Date: Thu Sep 1 10:44:46 2022 +0000 switching to using scratch space in perm impl commit 9bc5e518bc67fbfc57b7faf8462eb389dbf75a00 Author: Emerson Clarke <[email protected]> Date: Wed Aug 31 16:39:45 2022 +0200 Disabled tracy linking commit 283875392a4a886f38a6bd8463d1e4f78dee544d Author: Emerson Clarke <[email protected]> Date: Wed Aug 31 16:39:30 2022 +0200 Luke's z changes and fix to index update in cache, plus altered default cache size commit fd99ca34b27aa13f19a3368fec98adcb0f710386 Author: Emerson Clarke <[email protected]> Date: Wed Aug 31 15:16:52 2022 +0200 Build fixes/clear commit 0b9cc0cefc054b8f0387e1e1274e7d1b60bd61ad Author: Emerson Clarke <[email protected]> Date: Wed Aug 31 15:04:35 2022 +0200 Added clear() on move constructor/operator = and empty assertions on coefficient access. commit e188711d2d0987fdab49eae249909a7538373bec Author: Emerson Clarke <[email protected]> Date: Wed Aug 31 13:26:05 2022 +0200 Chasing mutated cache polynomials and coefficients, found and fixed some scope/lifecycle bugs, identified and added fixme's for a few more on the C interfaces that can't be easily traced. commit 671263ff437f54467a857a7be03d1afa9a753a37 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 17:19:11 2022 +0200 Fix polynomial operator == so that it doesnt crash with a null polynomial (or result of std::move), also given early return commit 2adf017b87bf04521f6dbc5c6c42633993a806bc Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 17:07:03 2022 +0200 Added Tracy mem tracking, and small polynomial/mem changes commit b3194c318de38623eced2a9bda1e0dac66e9cde4 Author: Emerson <[email protected]> Date: Tue Aug 30 16:49:44 2022 +0200 Merged from ec/mem commit c6d79bc459a87869273dbc2da9deabf8a31f74aa Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 16:26:08 2022 +0200 Repeate del from LRU while size > capacity, plus ASSERT(!empty()) on polynomial to catch use after std::move commit bfcf01e636b4952a3d80d96bf7143c4f9d28693f Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 15:51:23 2022 +0200 Moved leveldb dependencies down the cmake chain, added additional tests. commit e3a03979278cf48a24363c883bc3e3223638ef2a Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 13:20:32 2022 +0200 Putting poly's that seem to have been mutated back to cache commit 16e5fabcd5222a116d9f7c250ae64b006b3407e8 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 12:52:12 2022 +0200 Updated test to evict polyB commit 2a8940ffcb159f665fd03fe992de6173140f46d2 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 12:42:50 2022 +0200 Print for memory store, 2MB default size. commit 196811b5d39df09e2a71d6500347215541f26dcd Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 12:34:35 2022 +0200 Update index on put duplicate commit 545d468d6025e6b2c29114685d96519c676a50c9 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 12:27:42 2022 +0200 Fixme's, build fixes, mutex, overwrite on put with same key, serialisation template error avoided with unecessary copy constructor. commit 6ffead3387f47bff018dd9ea9b6ddc45f79c5c00 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 11:39:06 2022 +0200 Print disk and print changes commit 263fc402c5d948d16bb43c8d45946b3df9d58946 Author: Emerson <[email protected]> Date: Tue Aug 30 11:37:24 2022 +0200 Merge from lde/polynomial_store commit 99c2ea7e25a27ab3c26d6a82855467458e972448 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 11:08:30 2022 +0200 Pre merge with Luke's branch commit 6030d0cf053f2ed2a9f6b779936595a4b1a73fc3 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 10:06:58 2022 +0200 Disabled leveldb for build commit 93982413139385e1940034ae8fd5cec3ef13526a Author: Emerson Clarke <[email protected]> Date: Fri Aug 26 16:33:16 2022 +0200 Renaming, build fixes, serialisation, and move semantics on get commit 045c6f59a1881451522cade6801106db020e6096 Author: Emerson Clarke <[email protected]> Date: Fri Aug 26 11:52:33 2022 +0200 Build fixes, added leveldb to plonk module, moved cache code to .cpp file. Added global support for serialize read/write and std::string (leveldb uses std::string so this avoids copy overhead) commit b3937a25ae7f2be6faa88b30238823c55da92200 Author: Emerson Clarke <[email protected]> Date: Fri Aug 26 11:12:33 2022 +0200 Added store (plus mem/leveldb implementations), refactored interface to use get/put/del naming. Fixed incomplete logic and redundant lookups in the cache itself, and proposed solutions to interface for get. Added serialisation read/write methods for polynomial. Renamed lru_cache.hpp to proving_key_cache.hpp. Added result template to common. commit 67d5e389a8234ca5f6511efb6037d376785764b6 Author: Emerson Clarke <[email protected]> Date: Thu Aug 25 12:27:10 2022 +0200 Clang/Ryzen build fixes and common library improvements commit 0a6f7bfcedb63e8d7f8f30a2fdcf21db205bc525 Author: ledwards2225 <[email protected]> Date: Tue Aug 23 18:06:30 2022 +0000 functionality added in transition_widgets to pull only required polys for each widget commit 5e17779f48f2b1988d134a4226e553ad5ef4283a Author: ledwards2225 <[email protected]> Date: Mon Aug 22 22:56:03 2022 +0000 removing FFTGetter and MonomialGetter in favor of simplified PolynomialGetter commit c3cec2c82d0453836f5defb10265c5d0a6d11666 Author: ledwards2225 <[email protected]> Date: Mon Aug 22 02:34:20 2022 +0000 minor edits to lru_cache class commit aac73106dec10380f3139d8eec83d40b0d9d2c5c Author: ledwards2225 <[email protected]> Date: Sun Aug 21 19:54:21 2022 +0000 completely removing program_witness from the codebase commit abd6dbcb872b8bac06e0dc2ca9349113aa940b01 Author: ledwards2225 <[email protected]> Date: Thu Aug 18 21:26:45 2022 +0000 adding pho-disk storage functionality via a poly map in the lru_cache class commit 7a0d8f383242ffe7febbea2eae31e8f6a7b145c3 Author: ledwards2225 <[email protected]> Date: Thu Aug 18 17:19:42 2022 +0000 removing constraint_selectors_lagrange_base commit 40482e8644cd1a379848bc6c9d4ac48b96dddb6c Author: ledwards2225 <[email protected]> Date: Thu Aug 18 17:13:31 2022 +0000 constraint_selectors removed commit 5f75e85530089090aff5fa9d861d4ed7943384ee Author: ledwards2225 <[email protected]> Date: Thu Aug 18 16:52:38 2022 +0000 permutation selectors removed commit 41fd87cd386fc27409d3e6e61bc155199427eb96 Author: ledwards2225 <[email protected]> Date: Wed Aug 17 18:54:04 2022 +0000 wire_ffts map completely removed in favor of polynomial_store commit 96c973d2ec77b75234d403e684f9407179aaeeab Author: ledwards2225 <[email protected]> Date: Wed Aug 17 18:04:29 2022 +0000 cleaning out some old ffts that I missed in the previous commit commit a1caee8bccf6ec42d11533954ce39c8ad3c895ac Author: ledwards2225 <[email protected]> Date: Wed Aug 17 17:45:38 2022 +0000 constraint and permutation fft maps removed entirely, still havent updated serialization functions accordingly commit a6955c7a6ee8d90d29e6d2029f7ac7bb72f71e89 Author: ledwards2225 <[email protected]> Date: Wed Aug 17 16:40:18 2022 +0000 tests passing using poly_store for ffts, still something funny with wire_ffts though commit e96feff9ef2663733009d4dd059700133c0820b6 Author: ledwards2225 <[email protected]> Date: Mon Aug 15 21:40:09 2022 +0000 LRU cache class working under two simple tests commit 522156575fa14d8176d904ede87d4b8b33a76cb5 Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 19:40:15 2022 +0200 Moved flush logging commit 1dd7115b2505070f32c64e050084aaec60aa59cf Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 19:35:28 2022 +0200 Max size update after get commit ebcb42701068cb8d108b21168e660763821518a3 Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 19:18:02 2022 +0200 Added sentinel value to allow flushing of items not currently in scope, and generalised flush to allow profiling with different capacities/methods. Camel case call to get method in wasm. commit b124997fb5a1bc7b14b6a834ce44e19ff183ca62 Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 15:56:42 2022 +0200 Tweaked min size and flush loop, less size() calls and >= 0 commit c20e7810a93f1627a6c5b14f222e863257d31a95 Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 15:52:52 2022 +0200 Restored formatting, added min/max size and relocated to before and after flush since this catches all changes, and added to print(), also moved flush on get back to pre rather than post operation for memory safety. commit bf60cfe3989be038662b933057369a6505fb265f Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 15:14:08 2022 +0200 Sandbox, debugging logstr/wasm imports, tweaks to scripts, 4th round forced flush in prover commit 7708d3305792c0a11de0c60240a45d1515f5d7b5 Author: Emerson Clarke <[email protected]> Date: Wed Sep 7 12:12:30 2022 +0200 Eslint, async, await, bootstrap commit d4ee6545f53e0752b37018cebf70cd07c606603e Author: ledwards2225 <[email protected]> Date: Tue Sep 6 21:40:22 2022 +0000 WIP automating max cache size based on prover type commit a15b5e1307007fdd2221847d95e4baba7cc16b07 Merge: 095dc2762 b226a43e7 Author: ledwards2225 <[email protected]> Date: Tue Sep 6 16:24:17 2022 +0000 Merge branch 'ec/poly' of github.com:AztecProtocol/aztec2-internal into ec/poly commit b226a43e7389533b256e3d426e1c7d0017389d6e Author: reasoning <[email protected]> Date: Tue Sep 6 15:05:15 2022 +0000 Debug commit e146c3ebf3f2e3666284a2d434b8d8b5154328aa Author: reasoning <[email protected]> Date: Tue Sep 6 15:04:07 2022 +0000 WASM exports/imports, logstr fix, polynomial serialize size commit e2f228748fa65254e3d798809e56f0d272fa4677 Author: reasoning <[email protected]> Date: Tue Sep 6 13:10:43 2022 +0000 Moving proving key store bindings to barretenberg WASM module init commit adfa7c36f3b7ace117036c41971aed19f641c228 Author: reasoning <[email protected]> Date: Tue Sep 6 11:04:58 2022 +0000 WASM build commit ad85ccd8cf2e7d1261e4feec8414474bac80d28d Author: reasoning <[email protected]> Date: Tue Sep 6 10:59:29 2022 +0000 WASM build commit cc6cf701e700458074be5cabcc70bcdb08500ced Author: reasoning <[email protected]> Date: Tue Sep 6 10:57:45 2022 +0000 WASM build commit ad92e48de28f5de86d50df9546995847c2acae21 Author: reasoning <[email protected]> Date: Tue Sep 6 10:19:17 2022 +0000 Build fixes commit c3bd905c6dde06598c70fa90c11cdfcf793ba1d3 Author: reasoning <[email protected]> Date: Tue Sep 6 10:08:04 2022 +0000 Push model from JavaScript to WASM to deserialize polynomial after get commit 082a418e12846015a265b9f55514bacb6da131e7 Author: reasoning <[email protected]> Date: Tue Sep 6 08:57:10 2022 +0000 WASM bindings, levelup (memdown+indexdb) commit 97057ec4dfe3988c597bf64d6cbabec0a1b049ab Merge: faa6c88b0 cadaf5f77 Author: Emerson Clarke <[email protected]> Date: Mon Sep 5 13:17:41 2022 +0200 Merge branch 'ec/poly' of github.com:AztecProtocol/aztec2-internal into ec/poly commit faa6c88b0a98abdc67fb6ea741d206940d3c6cf8 Author: Emerson Clarke <[email protected]> Date: Mon Sep 5 13:07:10 2022 +0200 Delete store keys on get, further guards, debug logging of locks and flush. Tests now passing with 0.3mb cache size. commit 095dc2762f00466ce93dfb602b2ea56a13017c5f Author: ledwards2225 <[email protected]> Date: Sun Sep 4 21:33:53 2022 +0000 delete all FFTs after quotient computation commit 61dfba058b9ac06a2e5c7efa2ec925a5080708c1 Author: ledwards2225 <[email protected]> Date: Sun Sep 4 20:28:41 2022 +0000 some general cleanup commit 44202d42852667a635c69426d6cffece02b29247 Author: ledwards2225 <[email protected]> Date: Sun Sep 4 16:52:32 2022 +0000 moving opening polys to the store commit d1cb13ffda41c8325ad1b11fa9df3aeca89ae1db Author: ledwards2225 <[email protected]> Date: Sun Sep 4 14:49:47 2022 +0000 adding linear_poly to the store commit f83f0b6db2309aaacc6de96d6bc5cae169b1b28b Author: ledwards2225 <[email protected]> Date: Sun Sep 4 13:37:07 2022 +0000 add lagrange_1 to proving key commit 06185fcf278f03bab1bd8e5f91fc3da93126e44e Author: ledwards2225 <[email protected]> Date: Sun Sep 4 12:24:09 2022 +0000 adding some polynomial deletion to avoid unneeded disk writes commit cadaf5f770f1003594358c7926159ae69fdff5a7 Author: ledwards2225 <[email protected]> Date: Fri Sep 2 15:29:11 2022 +0000 cleaning up the scratch space allocation.. again commit 515f2986b6f51860c02e14d95778ad55331aba83 Author: Emerson Clarke <[email protected]> Date: Fri Sep 2 16:49:59 2022 +0200 Small cache capacity, guard/lock logging and work queue, debugging guard scopes, deallocate scratch space permutation widget commit 7666f8f4dcdbaaa9c8903ccd31f7d7a41c77564e Author: ledwards2225 <[email protected]> Date: Fri Sep 2 14:16:14 2022 +0000 cleaning out some unwanted memory initialization from reset() and adding scratch space for perm widget commit df7380f682e01bcaafe6376bc4e948bd32957498 Author: Luke Edwards <[email protected]> Date: Fri Sep 2 14:38:29 2022 +0200 test commit commit 2bf46884682fda4a08d242cd211aeb570f00b4ea Author: Emerson Clarke <[email protected]> Date: Fri Sep 2 14:15:59 2022 +0200 Added assertions on polynomials due to test failures, added flush to c_bind/wasm interface at end of work queue processing, and added cache flush locking to work queue. commit 5075ad2efe787562a06242600d7747d166a6e02d Author: Emerson Clarke <[email protected]> Date: Fri Sep 2 09:00:14 2022 +0200 Experimenting with different flush/modified placement commit ca54330511b433bb88142f7e1164ef25a8d61e9a Author: Emerson Clarke <[email protected]> Date: Thu Sep 1 18:30:58 2022 +0200 Restored default in memory store (stdlib_uint.test_divide passes with this but not the leveldb store currently) commit f6f13ee347148b07bf349c94616106e7f624f0dc Author: Emerson Clarke <[email protected]> Date: Thu Sep 1 18:26:16 2022 +0200 Polynomial unit test, leveldb store, and serialize fixes commit 01076687d19474a83b22b07e7c57349da7505caa Author: reasoning <[email protected]> Date: Thu Sep 1 13:51:52 2022 +0000 Simplify flush and test with different capacities commit a6d778b1838b013ad684436037c1d4997ed83f1f Author: reasoning <[email protected]> Date: Thu Sep 1 13:33:56 2022 +0000 Disc size commit e45e027f0fe128bad46159f774885e1509e864d2 Author: reasoning <[email protected]> Date: Thu Sep 1 13:25:06 2022 +0000 Fixed modified commit 562fe0d4207114b20bf75addc56257f607543151 Author: reasoning <[email protected]> Date: Thu Sep 1 13:04:11 2022 +0000 Added guard logic for readonly access to cache, can't protect/scope the C bindings though commit 0dbc98206242c6cc63587afd0ebe12e7ee08b8f8 Author: reasoning <[email protected]> Date: Thu Sep 1 12:40:56 2022 +0000 Added size in bytes to print functions commit 4fcbbd73691a9aa2c7c431ed7d80cb8ea19d49c2 Author: reasoning <[email protected]> Date: Thu Sep 1 12:29:09 2022 +0000 Gitignore commit a5791742798a46a2466716a80cb3ee2283546e82 Author: reasoning <[email protected]> Date: Thu Sep 1 12:27:31 2022 +0000 Fix allocated pages in move constructor commit 67f98f19204aa62a882e978117aa33db7ddae129 Author: Emerson Clarke <[email protected]> Date: Thu Sep 1 14:25:57 2022 +0200 Fixed move semantics on cache and added more safety/cleanup to polynomial resize methods commit 2fb277396f4877b58e9c6860e9f1f159e3130b8d Author: Emerson Clarke <[email protected]> Date: Thu Sep 1 13:48:13 2022 +0200 Fix move semantics on polynomial, and initial cache guard work commit 28050c8066911bdb95ad9154b4d68e415cbc38d9 Author: ledwards2225 <[email protected]> Date: Thu Sep 1 10:56:51 2022 +0000 avoid giving the work queue a pointer to local copy of z commit 9b2d75010eb808e09f7892c3fe4ca6d15f165054 Author: ledwards2225 <[email protected]> Date: Thu Sep 1 10:44:46 2022 +0000 switching to using scratch space in perm impl commit 3e29efcec7f68da3d9e19f3f99475f65d77a0109 Author: Emerson Clarke <[email protected]> Date: Wed Aug 31 16:39:45 2022 +0200 Disabled tracy linking commit e867635c92d34ac0019b78968ced0c3452e46ee6 Author: Emerson Clarke <[email protected]> Date: Wed Aug 31 16:39:30 2022 +0200 Luke's z changes and fix to index update in cache, plus altered default cache size commit 913c274d55542b68d0f4bc61c90959a6554dbecd Author: Emerson Clarke <[email protected]> Date: Wed Aug 31 15:16:52 2022 +0200 Build fixes/clear commit 7ff653c5e511fcc344cbf449f28ae6269b6f941e Author: Emerson Clarke <[email protected]> Date: Wed Aug 31 15:04:35 2022 +0200 Added clear() on move constructor/operator = and empty assertions on coefficient access. commit 1db3a66640119133c0906a06f1d6daf45ca690d1 Author: Emerson Clarke <[email protected]> Date: Wed Aug 31 13:26:05 2022 +0200 Chasing mutated cache polynomials and coefficients, found and fixed some scope/lifecycle bugs, identified and added fixme's for a few more on the C interfaces that can't be easily traced. commit 2d7459f988f2a48c2e12fdd5f38a6318454eca46 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 17:19:11 2022 +0200 Fix polynomial operator == so that it doesnt crash with a null polynomial (or result of std::move), also given early return commit f37c42609b2b46e55a09276890add17185004723 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 17:07:03 2022 +0200 Added Tracy mem tracking, and small polynomial/mem changes commit 93f8304180b9c39dc9ac14345a68ed097f8a7beb Author: Emerson <[email protected]> Date: Tue Aug 30 16:49:44 2022 +0200 Merged from ec/mem commit ddc2103a5a37a5a367677ed5f2e95e039b9c0172 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 16:26:08 2022 +0200 Repeate del from LRU while size > capacity, plus ASSERT(!empty()) on polynomial to catch use after std::move commit 01728caa54cd7c95707a71ffd3126f480cdb6357 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 15:51:23 2022 +0200 Moved leveldb dependencies down the cmake chain, added additional tests. commit e4089a8381adc4fef5fad838f8ce61c24fbb42a7 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 13:20:32 2022 +0200 Putting poly's that seem to have been mutated back to cache commit 923029a12fafe99ac8d3fac4f50729105754bde4 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 12:52:12 2022 +0200 Updated test to evict polyB commit 56a051095b193bb92b4fd7b953d3bb3b2568aaab Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 12:42:50 2022 +0200 Print for memory store, 2MB default size. commit 7c92f754f3fab5be8b6d3b00390a35ad69811897 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 12:34:35 2022 +0200 Update index on put duplicate commit fb5c88596750dd908c345f841426c6638accf798 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 12:27:42 2022 +0200 Fixme's, build fixes, mutex, overwrite on put with same key, serialisation template error avoided with unecessary copy constructor. commit a0e3ec6008efcc542f463b54419f1af92f4ecd8d Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 11:39:06 2022 +0200 Print disk and print changes commit 204598f67435d4e9092c168d3690c6a402929ee0 Author: Emerson <[email protected]> Date: Tue Aug 30 11:37:24 2022 +0200 Merge from lde/polynomial_store commit 4f5aaafaa070757b162a5bd1c07d2620625e63a3 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 11:08:30 2022 +0200 Pre merge with Luke's branch commit cc02480640dd745d911b1de20c474cf137f66f89 Author: Emerson Clarke <[email protected]> Date: Tue Aug 30 10:06:58 2022 +0200 Disabled leveldb for build commit 2a5e2f9cf655e6c838089331368e74dc20a5d224 Author: Emerson Clarke <[email protected]> Date: Fri Aug 26 16:33:16 2022 +0200 Renaming, build fixes, serialisation, and move semantics on get commit 26867f1af4a9c204486e74694d94cf6ed401c613 Author: Emerson Clarke <[email protected]> Date: Fri Aug 26 11:52:33 2022 +0200 Build fixes, added leveldb to plonk module, moved cache code to .cpp file. Added global support for serialize read/write and std::string (leveldb uses std::string so this avoids copy overhead) commit cbe87d822951b197a231fd322415023c16b22936 Author: Emerson Clarke <[email protected]> Date: Fri Aug 26 11:12:33 2022 +0200 Added store (plus mem/leveldb implementations), refactored interface to use get/put/del naming. Fixed incomplete logic and redundant lookups in the cache itself, and proposed solutions to interface for get. Added serialisation read/write methods for polynomial. Renamed lru_cache.hpp to proving_key_cache.hpp. Added result template to common. commit 8d9a39efc94f5b3d57ed597989eb0739dbf99e50 Author: Emerson Clarke <[email protected]> Date: Thu Aug 25 12:27:10 2022 +0200 Clang/Ryzen build fixes and common library improvements commit dc255c954377a1c071fce0f05de7ab0c53f61bc5 Author: ledwards2225 <[email protected]> Date: Tue Aug 23 18:06:30 2022 +0000 functionality added in transition_widgets to pull only required polys for each widget commit 2a440b6bb398027dd4cfa34f0dbf4d045b9eb74e Author: ledwards2225 <[email protected]> Date: Mon Aug 22 22:56:03 2022 +0000 removing FFTGetter and MonomialGetter in favor of simplified PolynomialGetter commit 526ef220c27ec49130e7f1fc6d4d8784d91e46e1 Author: ledwards2225 <[email protected]> Date: Mon Aug 22 02:34:20 2022 +0000 minor edits to lru_cache class commit 7fcc72f6d5ae4a0ba96f9f3cfe3b8ce39d40a061 Author: ledwards2225 <[email protected]> Date: Sun Aug 21 19:54:21 2022 +0000 completely removing program_witness from the codebase commit af57da32f02ee8221f86f0a9d63019df512b4a55 Author: ledwards2225 <[email protected]> Date: Thu Aug 18 21:26:45 2022 +0000 adding pho-disk storage functionality via a poly map in the lru_cache class commit bf5e06d87c5cbc902a15ab1f008c2565304e52fd Author: ledwards2225 <[email protected]> Date: Thu Aug 18 17:19:42 2022 +0000 removing constraint_selectors_lagrange_base commit e1464350c24aaee3e8de645f93980e13b85441cb Author: ledwards2225 <[email protected]> Date: Thu Aug 18 17:13:31 2022 +0000 constraint_selectors removed commit 64b051c1ab78ceb9479cf8e6abaf227933b77a50 Author: ledwards2225 <[email protected]> Date: Thu Aug 18 16:52:38 2022 +0000 permutation selectors removed commit 69dfac74df0965a48c47a744a40e3675ed6445aa Author: ledwards2225 <[email protected]> Date: Wed Aug 17 18:54:04 2022 +0000 wire_ffts map completely removed in favor of polynomial_store commit 3ccc5d8e05592df09792070d0723de75c853db74 Author: ledwards2225 <[email protected]> Date: Wed Aug 17 18:04:29 2022 +0000 cleaning out some old ffts that I missed in the previous commit commit eb3d615762b1a0bf8e3f515e90d52bca17f8a709 Author: ledwards2225 <[email protected]> Date: Wed Aug 17 17:45:38 2022 +0000 constraint and permutation fft maps removed entirely, still havent updated serialization functions accordingly commit b90feb76e411902cf247c237675c97319fcba0f0 Author: ledwards2225 <[email protected]> Date: Wed Aug 17 16:40:18 2022 +0000 tests passing using poly_store for ffts, still something funny with wire_ffts though commit d810556b91815ce9757721d1ff53fcd4967e3add Author: ledwards2225 <[email protected]> Date: Mon Aug 15 21:40:09 2022 +0000 LRU cache class working under two simple tests * fixing crypto dir changes * fixing common dir * returning some dirs to their original state * returning rollup to original state * more cleanup * removing some leveldb stuff and changing std::info prinbts * deleting some extra files * returning more files to original state * more updates * removing some broken consts * doing away with more const issues for now * more const * maybe the last of the consts * updating poly serialization * finally building * Local memory disk enabled; plonk tests are passing in full * serialization WiP * WiP, write is working, need to update read * proving key serialization working; but still WiP bc serialization test still failing * updating test * one more fix to serialization and turning back on verification key serialization tests * removing lock guard, cache capacity looks good * added PrecomputedPolyList class and updated serialization accordingly * standalone proving key mmap test is working; still need to run rollup tests * fixed proving_key constructor; serialization test now passes * some cleanup of poly cache class * removing outdated pre-computed polys infrastructure * removing emersons WASM debug prints * big ol general cleanup commit * some minor organizational changes + cleanup; all plonk tests passing * more cleanup * cleaning up polynomial cpp + h * WiP, removing some TODOs * udpate to witness_computed in plookup composer * adding appropriate buffer serialization tests for proving_key * added comment to failing plookup test - possibly can be removed since its functionality is not supported * changing polynomial naming z to z_perm in all instances * removing debug comments for circleCI tests... * removing more prints * updating plookup test to make sense * All node specific code is imported via ./node/index.js for clean stripping. * moving capacity_ initialization to the proving key cache + relevant updates * cleaning up proving key cache * adding some fft functionality and using it to clean up fft stuff in work_queue and composer_base * Initial working. * making capacity large enough to avoid writing to store for circleCI testing * fixing size_t issue that seemed to break wasm tests * adding bool to toggle use of store * Seems to work! * fixing incorrect direct copy of cache index that led to large cache after copy construction * increasing hard coded account and joinsplit size (x4) to see if wasm tests pass * adding abort in p key serialize to see if ofstream is failing * cleaning up the polynomial_manifest * big general PR cleanup commit * Length hack didnt work, output properly. * FileCrs so we don't need network connection. JS test pass with asynCall. * wip * Bootstrap fixes. * Reduce max mem. * Dockerfile * clean * Fix lint. * Force to -O2 backend optimisations to workaround either optimiser or aes bug. * Attemp to fix things. * Back to remote CRS and add web data store. * Deps. * wasm instantiate fix * Comment tweaks. * Slightly cleaner async funcs. * Separate out call state. * Separate async logic out into its own class. Comments. * Creates proof but doesn't pass... * wip * wip * wip * Fixed fft. Test pases. * sdk fixes. * wip. needs cleanup. * plonk_tests now passing with the exception of mem_file_consistency; something simple probably * serialization tests passing using polynomial cache in proving_key_data; can attempt to make this a simple map instead * reviving all proving_key_data and some general cleanup * commenting out mmap proving key test that fails on circleCI * bypassing c_bind test failure for now to continue testing * Fixes * Fixe * Fix * Fix what I think is an ancient mem alloc bug in poly mapping. * Remove account getKey test * Fix * Fix * removing dead proving_key constructors and name change to polynomial_cache * some cleanup including move from [0] access to get_coefficients() * minor cleanup and commenting * bringing back transcript00 for two previously failing tests * removing old 4x debug code and the throw_or_aborts related to pk save/load * minor coments in cache * Remove old transcript. * See if mmap test works. log cleanup. * Cleanup. Use std::filesystem. * updating some comments Co-authored-by: Charlie Lye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs are no longer valid if users do not put
type(scope): mesasge.Most PRs are already of this form.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.