-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to make proofs with an already computed proving key #1682
Conversation
There are a few things which are blocking this PR:
For the last point, this seems to be broken due to bbmalloc retuning a void* return type, whereas the script expects only void return types for WASM_EXPORT. See here for the error which gets raised. |
For the third point, #1683 has been opened |
This is based off of #1672 , so once that gets merged, the diff will be smaller |
@charlielye noted that the time it takes to copy a large proving key vs the time it takes to recompute it, can be about a difference of 2x. Given that this does add complexity, going to close this for now until users complain about multiple proving times. The issues regarding bindgen.sh not working will still need to be fixed regardless in separate PRs |
resolves #1680
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.