Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to make proofs with an already computed proving key #1682

Closed
wants to merge 9 commits into from

Conversation

kevaundray
Copy link
Contributor

resolves #1680

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@kevaundray
Copy link
Contributor Author

There are a few things which are blocking this PR:

  • The typescript main.js needs to be modified to accept the proving key path
  • Should try and use writeKeys in tests, to see if performance is good enough to get rid of proveAndVerify
  • Re-generate the exports.json file and barretenberg_api

For the last point, this seems to be broken due to bbmalloc retuning a void* return type, whereas the script expects only void return types for WASM_EXPORT. See here for the error which gets raised.

@kevaundray
Copy link
Contributor Author

For the third point, #1683 has been opened

@kevaundray
Copy link
Contributor Author

This is based off of #1672 , so once that gets merged, the diff will be smaller

@kevaundray
Copy link
Contributor Author

@charlielye noted that the time it takes to copy a large proving key vs the time it takes to recompute it, can be about a difference of 2x.

Given that this does add complexity, going to close this for now until users complain about multiple proving times.

The issues regarding bindgen.sh not working will still need to be fixed regardless in separate PRs

@kevaundray kevaundray closed this Aug 21, 2023
codygunton pushed a commit that referenced this pull request Jan 23, 2024
@ludamad ludamad deleted the kw/changeVK branch August 22, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Proving keys should be written to files instead of recomputed each time
1 participant