fix: default color to light mode #1664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@critesjosh this one's still in draft. Are there further changes you're intending to make to this PR? (Just checking in case it's accidentally been left in 'draft' mode) |
|
I think I accidentally left this in draft mode. just marked it as ready for review |
critesjosh
changed the title
|
I'm not sure why CI has failed so catastrophically. Maybe a rebase is needed? |
…tocol/aztec-packages into docs/jc/update-branding
…tocol/aztec-packages into docs/jc/update-branding
4 tasks
|
trying again in #1847 |
critesjosh
added a commit
that referenced
this pull request
Aug 28, 2023
Defaulting to light mode, which matches our brand colors better. Still keeping the option for dark mode for people that want it, even though feels like an old color scheme. replaces #1664 # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [x] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [x] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaulting to light mode, which matches our brand colors better. Still keeping the option for dark mode for people that want it, even though feels like an old color scheme.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.