Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create fixtures folder in E2E #1419

Merged
merged 5 commits into from
Aug 4, 2023
Merged

chore: Create fixtures folder in E2E #1419

merged 5 commits into from
Aug 4, 2023

Conversation

LHerskind
Copy link
Contributor

@LHerskind LHerskind commented Aug 4, 2023

Creates a folder for fixtures in E2E and moves:

  • dumps
  • fixtures.ts
  • utils
  • cross_chain_test_harness.ts

Not moving the cheat_codes.ts as @rahul-kothari was in progress of moving that to another location already.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@LHerskind LHerskind marked this pull request as ready for review August 4, 2023 08:16
Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@Maddiaa0 Maddiaa0 merged commit b8972b4 into master Aug 4, 2023
@Maddiaa0 Maddiaa0 deleted the lh/e2e-fixtures branch August 4, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants