Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove some instances of --silence-warnings #11071

Merged
merged 2 commits into from
Jan 6, 2025
Merged

chore: remove some instances of --silence-warnings #11071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa5538
chore: remove some instances of `silence-warnings`
TomAFrench Jan 6, 2025
91bf3a8
chore: print warnings on tests
TomAFrench Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion noir-projects/aztec-nr/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export NARGO=${NARGO:-../../noir/noir-repo/target/release/nargo}

function test_cmds {
i=0
$NARGO test --list-tests --silence-warnings | while read -r package test; do
$NARGO test --list-tests | while read -r package test; do
# We assume there are 8 txe's running.
port=$((45730 + (i++ % ${NUM_TXES:-1})))
echo "noir-projects/scripts/run_test.sh aztec-nr $package $test $port"
Expand Down
6 changes: 3 additions & 3 deletions noir-projects/noir-contracts/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ function compile {
"^noir-projects/aztec-nr/" \
)"
if ! cache_download contract-$contract_hash.tar.gz &> /dev/null; then
$NARGO compile --package $contract --silence-warnings --inliner-aggressiveness 0
$NARGO compile --package $contract --inliner-aggressiveness 0
$TRANSPILER $json_path $json_path
cache_upload contract-$contract_hash.tar.gz $json_path &> /dev/null
fi
Expand Down Expand Up @@ -144,7 +144,7 @@ function build {

function test_cmds {
i=0
$NARGO test --list-tests --silence-warnings | while read -r package test; do
$NARGO test --list-tests | while read -r package test; do
# We assume there are 8 txe's running.
port=$((45730 + (i++ % ${NUM_TXES:-1})))
echo "noir-projects/scripts/run_test.sh noir-contracts $package $test $port"
Expand Down Expand Up @@ -197,4 +197,4 @@ case "$cmd" in
*)
echo_stderr "Unknown command: $cmd"
exit 1
esac
esac
4 changes: 2 additions & 2 deletions noir-projects/noir-protocol-circuits/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function compile {
SECONDS=0
rm -f $json_path
# TODO: --skip-brillig-constraints-check added temporarily for blobs build time.
local compile_cmd="$NARGO compile --package $name --silence-warnings --skip-brillig-constraints-check"
local compile_cmd="$NARGO compile --package $name --skip-brillig-constraints-check"
echo_stderr "$compile_cmd"
dump_fail "$compile_cmd"
echo_stderr "Compilation complete for: $name (${SECONDS}s)"
Expand Down Expand Up @@ -138,7 +138,7 @@ function test {
CIRCUITS_HASH=$(cache_content_hash ../../noir/.rebuild_patterns "^noir-projects/$name")
test_should_run $name-tests-$CIRCUITS_HASH || return 0

RAYON_NUM_THREADS= $NARGO test --silence-warnings --skip-brillig-constraints-check
RAYON_NUM_THREADS= $NARGO test --skip-brillig-constraints-check
cache_upload_flag $name-tests-$CIRCUITS_HASH
}

Expand Down
8 changes: 4 additions & 4 deletions noir-projects/scripts/check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ set -eu

cd $(dirname "$0")/../

nargo check --program-dir ./aztec-nr --silence-warnings
nargo check --program-dir ./noir-contracts --silence-warnings
nargo check --program-dir ./noir-protocol-circuits --silence-warnings
nargo check --program-dir ./mock-protocol-circuits --silence-warnings
nargo check --program-dir ./aztec-nr
nargo check --program-dir ./noir-contracts
nargo check --program-dir ./noir-protocol-circuits
nargo check --program-dir ./mock-protocol-circuits
Loading