Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: permutation argument optimizations #10960

Merged
merged 29 commits into from
Jan 9, 2025
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
64317bc
basic computations skipping model working in GP comp
ledwards2225 Dec 23, 2024
0ab2078
WiP things working before switch to active idxs loops
ledwards2225 Dec 23, 2024
35d1c8d
using active idxs for GP step 1
ledwards2225 Dec 23, 2024
418f7bc
fix
ledwards2225 Dec 23, 2024
09ef41a
dont do any computation for num/denom in inactive regions
ledwards2225 Dec 23, 2024
a258127
Merge branch 'master' into lde/perm_opt
ledwards2225 Dec 24, 2024
72b215f
fix build
ledwards2225 Dec 24, 2024
c36feaa
fix PG tests
ledwards2225 Dec 24, 2024
bd8a511
clean debug code to fix some tests
ledwards2225 Dec 24, 2024
dd50b47
Merge branch 'master' into lde/perm_opt
ledwards2225 Jan 2, 2025
d9b43bb
test revision of gp method
ledwards2225 Jan 2, 2025
deb1d65
remove debug code for ci
ledwards2225 Jan 2, 2025
339a5c9
optimized version seems to be working, cleanup needed
ledwards2225 Jan 3, 2025
5471504
some fixes, see what fails
ledwards2225 Jan 3, 2025
4d7ea03
fix for client ivc
ledwards2225 Jan 3, 2025
7f348aa
correct ivc structure
ledwards2225 Jan 3, 2025
9736925
Merge branch 'master' into lde/perm_opt
ledwards2225 Jan 5, 2025
8911c2f
some cleanup
ledwards2225 Jan 6, 2025
46e378c
clean and regularize
ledwards2225 Jan 6, 2025
d0ea21a
fix index error in thread method
ledwards2225 Jan 6, 2025
45156f7
clarify and clean
ledwards2225 Jan 6, 2025
0ebd607
active regions model working
ledwards2225 Jan 6, 2025
b2539a7
Merge branch 'master' into lde/perm_opt
ledwards2225 Jan 6, 2025
bf1394d
more cleanup
ledwards2225 Jan 7, 2025
b104bc6
clean and remove debug code
ledwards2225 Jan 7, 2025
e702d00
remove problematic assert
ledwards2225 Jan 7, 2025
d34fe9c
clean
ledwards2225 Jan 8, 2025
cd6e7b6
Merge branch 'master' into lde/perm_opt
ledwards2225 Jan 8, 2025
e442a51
make active region class more robust and constify some things
ledwards2225 Jan 9, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove debug code for ci
  • Loading branch information
ledwards2225 committed Jan 2, 2025
commit deb1d65baa2cdceaf07302080e21dbd9b9d80d0f
Original file line number Diff line number Diff line change
@@ -119,10 +119,10 @@ class PrivateFunctionExecutionMockCircuitProducer {
mock_databus.populate_kernel_databus(circuit); // populate databus inputs/outputs
ivc.complete_kernel_circuit_logic(circuit); // complete with recursive verifiers etc
} else {
[[maybe_unused]] bool use_large_circuit =
large_first_app && (circuit_counter == 1); // first circuit is size 2^19
GoblinMockCircuits::construct_mock_app_circuit(circuit, false); // construct mock app
mock_databus.populate_app_databus(circuit); // populate databus outputs
bool use_large_circuit = large_first_app && (circuit_counter == 1); // first circuit is size 2^19
GoblinMockCircuits::construct_mock_app_circuit(circuit, use_large_circuit); // construct mock app
// GoblinMockCircuits::construct_mock_app_circuit(circuit, false); // construct mock app
mock_databus.populate_app_databus(circuit); // populate databus outputs
}
return circuit;
}
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/goblin/mock_circuits.hpp
Original file line number Diff line number Diff line change
@@ -191,7 +191,7 @@ class GoblinMockCircuits {
{
PROFILE_THIS();
// DEBUG
// add_some_ecc_op_gates(builder);
add_some_ecc_op_gates(builder);
MockCircuits::construct_arithmetic_circuit(builder);
}

Loading