Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove auto verify in cbind ivc prove #10627

Merged
merged 5 commits into from
Dec 11, 2024
Merged

fix: remove auto verify in cbind ivc prove #10627

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0673191
remove auto verify in cbind ivc prove
ledwards2225 Dec 11, 2024
6388f0e
comment hack to run yarn proj
ledwards2225 Dec 11, 2024
10c5924
undo
ledwards2225 Dec 11, 2024
e3e4fd8
Merge branch 'master' into lde/fix_wasm_ivc_integration
ledwards2225 Dec 11, 2024
7e5387d
Update package.json
ludamad Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/dsl/acir_proofs/c_bind.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ WASM_EXPORT void acir_prove_aztec_client(uint8_t const* acir_stack,
}
// TODO(https://github.com/AztecProtocol/barretenberg/issues/1101): remove use of auto_verify_mode
TraceSettings trace_settings{ E2E_FULL_TEST_STRUCTURE };
auto ivc = std::make_shared<ClientIVC>(trace_settings, /*auto_verify_mode=*/true);
auto ivc = std::make_shared<ClientIVC>(trace_settings);

const acir_format::ProgramMetadata metadata{ ivc };

Expand Down
2 changes: 1 addition & 1 deletion yarn-project/ivc-integration/src/wasm_client_ivc_integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ describe('Client IVC Integration', () => {
const tx = {
number_of_calls: '0x2',
};
// Witness gen app and kernels
// Witness gen for app and kernels
const creatorAppWitnessGenResult = await witnessGenCreatorAppMockCircuit({ commitments_to_create: ['0x1', '0x2'] });
const readerAppWitnessGenResult = await witnessGenReaderAppMockCircuit({ commitments_to_read: ['0x2', '0x0'] });

Expand Down
Loading