-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use synched block number to sync notes #10545
Closed
Closed
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
74420bb
wait for pxe to synch before checking balances
Thunkar 92ba769
actually commit
Thunkar 0337f73
comment
Thunkar a0483db
fix
Thunkar d989cad
Merge branch 'master' into gj/deflate_e2e_2_pxes
Thunkar 823921e
Merge branch 'master' of github.com:AztecProtocol/aztec-packages into…
Thunkar 0fde995
merge
Thunkar 0d58475
Merge branch 'gj/deflate_e2e_2_pxes' of github.com:AztecProtocol/azte…
Thunkar fe40d4f
fmt
Thunkar 3721212
Merge branch 'master' of github.com:AztecProtocol/aztec-packages into…
Thunkar 9540975
Merge branch 'master' into gj/deflate_e2e_2_pxes
Thunkar 782902a
Merge branch 'master' into gj/deflate_e2e_2_pxes
Thunkar 4a180a0
Merge branch 'master' of github.com:AztecProtocol/aztec-packages into…
Thunkar 9499176
Merge branch 'master' into gj/deflate_e2e_2_pxes
Thunkar f91e77e
Merge branch 'master' into gj/deflate_e2e_2_pxes
Thunkar 11a8b71
Merge branch 'gj/deflate_e2e_2_pxes' of github.com:AztecProtocol/azte…
Thunkar 712f25e
synchronize on demand
Thunkar 64b4996
Merge branch 'master' into gj/deflate_e2e_2_pxes
Thunkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -112,4 +112,4 @@ | |
"engines": { | ||
"node": ">=18" | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the wallet... ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, didn't save the file properly.
To address the overall comment, theCircuit execution failed
error seems to happen when validating a read request in the kernel, so I assumed it's because we haven't synched the balances properly (kernel verification happens with a stale header). Even if PXEYou made me think, hope you're happy. The problem is in a misalignment between what's read in the simulation (that uses notes seen up to
aztecNode.getBlockNumber()
) and the kernels (that checks read requests up tosynchronizer.getSynchedBlockNumber
). I'm gonna test this theory by forcing simulation to use only the synched blockNumber!