Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes for devnet #10448

Closed
wants to merge 35 commits into from
Closed

fix: Fixes for devnet #10448

wants to merge 35 commits into from

Conversation

PhilWindle
Copy link
Collaborator

@PhilWindle PhilWindle commented Dec 6, 2024

This PR makes a number of devnet related fixes

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Changes to public function bytecode sizes

Generated at commit: 324b443a9d46062734bbf331c989d666a49d7ce2, compared to commit: 4fcbc592c963389a132b5b72f0f68d1f6526943b

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
Lending::get_assets +86 ❌ +19.91%
AMM::_swap_exact_tokens_for_tokens +503 ❌ +12.12%
AvmTest::poseidon2_hash +181 ❌ +11.69%
AvmTest::set_storage_map +177 ❌ +10.91%
AuthRegistry::set_authorized +181 ❌ +10.82%
AuthRegistry::_set_authorized +181 ❌ +10.52%
AuthRegistry::is_consumable +181 ❌ +10.48%
AvmTest::add_storage_map +177 ❌ +10.27%
AMM::_swap_tokens_for_exact_tokens +464 ❌ +9.83%
EasyPrivateVoting::add_to_tally_public +177 ❌ +9.43%
EasyPrivateVoting::public_dispatch +445 ❌ +9.36%
StatefulTest::increment_public_value_no_init_check +138 ❌ +8.82%
FeeJuice::_increase_public_balance +177 ❌ +8.67%
NFT::owner_of +192 ❌ +8.58%
StatefulTest::increment_public_value +138 ❌ +8.56%
AuthRegistry::set_reject_all +133 ❌ +8.48%
Benchmarking::broadcast +138 ❌ +8.43%
StatefulTest::get_public_value +134 ❌ +8.36%
Token::set_minter +138 ❌ +8.28%
AvmTest::read_storage_map +129 ❌ +8.18%
TokenBlacklist::_increase_public_balance +187 ❌ +8.13%
Token::_increase_public_balance +187 ❌ +8.13%
CardGame::on_card_played +446 ❌ +8.10%
Spam::public_spam +182 ❌ +8.10%
NFT::_finish_transfer_to_public +133 ❌ +8.05%
Token::is_minter +134 ❌ +8.04%
AuthRegistry::is_reject_all +129 ❌ +7.97%
NFT::set_minter +133 ❌ +7.96%
PriceFeed::set_price +133 ❌ +7.95%
NFT::is_minter +129 ❌ +7.72%
PriceFeed::get_price +125 ❌ +7.68%
FeeJuice::balance_of_public +129 ❌ +7.52%
TokenBlacklist::balance_of_public +129 ❌ +7.29%
Token::balance_of_public +129 ❌ +7.29%
Lending::get_asset +147 ❌ +7.16%
Token::mint_to_public +187 ❌ +6.99%
NFT::mint +183 ❌ +6.89%
Lending::init +190 ❌ +6.88%
Benchmarking::public_dispatch +247 ❌ +6.65%
Benchmarking::increment_balance +143 ❌ +6.39%
CardGame::start_game +421 ❌ +6.38%
FeeJuice::check_balance +133 ❌ +6.37%
Lending::get_position +298 ❌ +6.34%
Lending::_deposit +151 ❌ +6.33%
Spam::public_dispatch +190 ❌ +6.22%
AvmTest::get_args_hash +99 ❌ +5.81%
FeeJuice::public_dispatch +283 ❌ +5.66%
Auth::get_authorized_delay +108 ❌ +5.56%
AvmInitializerTest::constructor +95 ❌ +5.12%
PriceFeed::public_dispatch +146 ❌ +4.95%
CardGame::public_dispatch +721 ❌ +4.73%
CardGame::on_game_joined +221 ❌ +4.60%
DocsExample::public_dispatch +175 ❌ +4.36%
Auth::get_scheduled_authorized +71 ❌ +4.08%
Auth::get_authorized +71 ❌ +3.85%
AvmInitializerTest::public_dispatch +95 ❌ +3.63%
Lending::update_accumulator +195 ❌ +3.52%
Crowdfunding::_publish_donation_receipts +31 ❌ +3.36%
Crowdfunding::public_dispatch +142 ❌ +3.13%
CardGame::on_cards_claimed +221 ❌ +3.12%
Lending::_repay +161 ❌ +2.92%
Router::public_dispatch +55 ❌ +2.39%
InclusionProofs::public_dispatch +87 ❌ +2.37%
TokenBlacklist::mint_public +92 ❌ +2.36%
AuthRegistry::consume +56 ❌ +1.98%
InclusionProofs::constructor +43 ❌ +1.90%
TokenBlacklist::mint_private +69 ❌ +1.88%
Uniswap::constructor +43 ❌ +1.85%
EasyPrivateVoting::constructor +43 ❌ +1.82%
Auth::constructor +43 ❌ +1.82%
Token::finalize_transfer_to_private +113 ❌ +1.77%
Token::_finalize_transfer_to_private_unsafe +113 ❌ +1.75%
NFT::public_dispatch +387 ❌ +1.66%
AMM::constructor +43 ❌ +1.62%
Crowdfunding::init +43 ❌ +1.61%
TestLog::emit_unencrypted_events +18 ❌ +1.59%
NFT::_store_payload_in_transient_storage_unsafe +18 ❌ +1.54%
Token::_store_payload_in_transient_storage_unsafe +18 ❌ +1.54%
AppSubscription::constructor +43 ❌ +1.54%
AvmTest::keccak_hash +35 ❌ +1.48%
TokenBlacklist::get_roles +38 ❌ +1.44%
NFT::finalize_transfer_to_private +71 ❌ +1.33%
NFT::_finalize_transfer_to_private_unsafe +71 ❌ +1.32%
TokenBlacklist::update_roles +79 ❌ +1.31%
Auth::set_authorized +56 ❌ +1.25%
Test::emit_unencrypted +18 ❌ +1.23%
Auth::set_authorized_delay +56 ❌ +1.22%
NFT::constructor +47 ❌ +1.17%
AuthRegistry::public_dispatch +92 ❌ +1.17%
Token::constructor +47 ❌ +1.15%
Auth::public_dispatch +100 ❌ +1.15%
Test::public_dispatch +216 ❌ +1.14%
Lending::_borrow +83 ❌ +1.14%
StatefulTest::public_dispatch +62 ❌ +1.02%
Token::finalize_mint_to_private +58 ❌ +0.96%
Token::_finalize_mint_to_private_unsafe +58 ❌ +0.95%
Parent::public_nested_static_call +30 ❌ +0.90%
AppSubscription::public_dispatch +35 ❌ +0.88%
Router::_check_block_number +8 ❌ +0.83%
Router::_check_timestamp +8 ❌ +0.81%
TokenBlacklist::constructor +43 ❌ +0.70%
Test::consume_message_from_arbitrary_sender_public +46 ❌ +0.58%
TokenBlacklist::burn_public +27 ❌ +0.52%
TokenBlacklist::transfer_public +27 ❌ +0.48%
AvmTest::emit_unencrypted_log +13 ❌ +0.47%
Token::burn_public +14 ❌ +0.34%
Token::transfer_in_public +14 ❌ +0.33%
TestLog::public_dispatch +6 ❌ +0.26%
Token::public_dispatch +78 ❌ +0.25%
TokenBlacklist::shield +14 ❌ +0.24%
Test::create_l2_to_l1_message_public +5 ❌ +0.23%
Claim::public_dispatch +7 ❌ +0.22%
AvmTest::pedersen_hash +5 ❌ +0.16%
AvmTest::pedersen_hash_with_index +5 ❌ +0.16%
StatefulTest::public_constructor +4 ❌ +0.14%
NFT::transfer_in_public +4 ❌ +0.12%
Claim::constructor -1 ✅ -0.04%
TokenBridge::constructor -1 ✅ -0.04%
FPC::constructor -1 ✅ -0.04%
TokenBlacklist::public_dispatch -79 ✅ -0.34%
AvmTest::u128_addition_overflow -5 ✅ -0.37%
Lending::_withdraw -47 ✅ -0.54%
StaticChild::public_dispatch -19 ✅ -0.89%
AuthWitTest::public_dispatch -17 ✅ -1.01%
AvmTest::bulk_testing -249 ✅ -1.09%
AvmTest::u128_from_integer_overflow -9 ✅ -1.09%
Test::consume_mint_to_public_message -135 ✅ -1.24%
AvmTest::sha256_hash -52 ✅ -1.31%
FPC::public_dispatch -109 ✅ -1.51%
TokenBridge::claim_public -174 ✅ -1.52%
AvmTest::pedersen_commit -21 ✅ -1.64%
Token::complete_refund -95 ✅ -1.74%
AvmTest::debug_logging -26 ✅ -1.97%
TokenBridge::public_dispatch -443 ✅ -2.12%
Parent::public_static_call -26 ✅ -2.23%
StaticParent::public_static_call -26 ✅ -2.23%
AvmTest::public_dispatch -1,456 ✅ -2.34%
AvmTest::assert_calldata_copy -13 ✅ -2.39%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 -165 ✅ -2.62%
Parent::public_dispatch -211 ✅ -2.69%
AvmTest::returndata_copy_oracle -50 ✅ -2.75%
Uniswap::public_dispatch -670 ✅ -2.83%
Uniswap::swap_public -461 ✅ -2.95%
Child::public_dispatch -152 ✅ -3.09%
AMM::public_dispatch -670 ✅ -3.12%
Lending::public_dispatch -970 ✅ -3.46%
AvmTest::elliptic_curve_add_and_double -26 ✅ -3.52%
AvmTest::elliptic_curve_add -26 ✅ -4.29%
Parent::pub_entry_point -26 ✅ -4.30%
StaticParent::public_call -26 ✅ -4.30%
AvmTest::read_storage_list -13 ✅ -4.38%
StaticParent::public_dispatch -278 ✅ -4.60%
Parent::pub_entry_point_twice -52 ✅ -5.06%
Uniswap::_assert_token_is_same -39 ✅ -5.16%
StaticParent::public_nested_static_call -117 ✅ -5.41%
AvmTest::check_selector -13 ✅ -5.42%
DocsExample::get_public_immutable_constrained_public_indirect -39 ✅ -5.61%
Lending::withdraw_public -117 ✅ -5.82%
Lending::borrow_public -117 ✅ -5.82%
TokenBridge::exit_to_l1_public -391 ✅ -5.82%
AuthWitTest::consume_public -39 ✅ -5.90%
FPC::pay_refund -130 ✅ -5.99%
FPC::prepare_fee -130 ✅ -6.14%
Child::set_value_twice_with_nested_first -39 ✅ -6.21%
Child::set_value_twice_with_nested_last -39 ✅ -6.21%
AMM::_remove_liquidity -442 ✅ -6.31%
AvmTest::get_function_selector -13 ✅ -6.34%
AvmTest::nested_static_call_to_add -39 ✅ -6.41%
AvmTest::nested_call_to_add -39 ✅ -6.41%
AvmTest::nested_call_to_assert_same -39 ✅ -6.41%
AMM::_add_liquidity -559 ✅ -6.50%
StaticParent::public_get_value_from_child -39 ✅ -6.57%
AvmTest::nested_call_to_add_with_gas -39 ✅ -6.69%
AvmTest::create_different_nullifier_in_nested_call -39 ✅ -7.32%
AvmTest::create_same_nullifier_in_nested_call -39 ✅ -7.46%
ImportTest::pub_call_public_fn -39 ✅ -7.53%
AvmTest::nested_static_call_to_set_storage -39 ✅ -7.54%
Child::set_value_with_two_nested_calls -78 ✅ -7.74%
AvmTest::nested_call_to_nothing -39 ✅ -7.75%
AvmTest::external_call_to_assertion_failure -39 ✅ -7.75%
AvmTest::external_call_to_divide_by_zero -39 ✅ -7.75%
ImportTest::public_dispatch -91 ✅ -7.90%
Lending::repay_public -221 ✅ -8.35%
Lending::deposit_public -234 ✅ -8.43%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
Lending::get_assets 518 (+86) +19.91%
AMM::_swap_exact_tokens_for_tokens 4,653 (+503) +12.12%
AvmTest::poseidon2_hash 1,729 (+181) +11.69%
AvmTest::set_storage_map 1,799 (+177) +10.91%
AuthRegistry::set_authorized 1,854 (+181) +10.82%
AuthRegistry::_set_authorized 1,901 (+181) +10.52%
AuthRegistry::is_consumable 1,908 (+181) +10.48%
AvmTest::add_storage_map 1,901 (+177) +10.27%
AMM::_swap_tokens_for_exact_tokens 5,184 (+464) +9.83%
EasyPrivateVoting::add_to_tally_public 2,053 (+177) +9.43%
EasyPrivateVoting::public_dispatch 5,199 (+445) +9.36%
StatefulTest::increment_public_value_no_init_check 1,702 (+138) +8.82%
FeeJuice::_increase_public_balance 2,219 (+177) +8.67%
NFT::owner_of 2,429 (+192) +8.58%
StatefulTest::increment_public_value 1,751 (+138) +8.56%
AuthRegistry::set_reject_all 1,702 (+133) +8.48%
Benchmarking::broadcast 1,775 (+138) +8.43%
StatefulTest::get_public_value 1,737 (+134) +8.36%
Token::set_minter 1,804 (+138) +8.28%
AvmTest::read_storage_map 1,706 (+129) +8.18%
TokenBlacklist::_increase_public_balance 2,488 (+187) +8.13%
Token::_increase_public_balance 2,488 (+187) +8.13%
CardGame::on_card_played 5,949 (+446) +8.10%
Spam::public_spam 2,429 (+182) +8.10%
NFT::_finish_transfer_to_public 1,786 (+133) +8.05%
Token::is_minter 1,801 (+134) +8.04%
AuthRegistry::is_reject_all 1,747 (+129) +7.97%
NFT::set_minter 1,804 (+133) +7.96%
PriceFeed::set_price 1,805 (+133) +7.95%
NFT::is_minter 1,801 (+129) +7.72%
PriceFeed::get_price 1,753 (+125) +7.68%
FeeJuice::balance_of_public 1,845 (+129) +7.52%
TokenBlacklist::balance_of_public 1,899 (+129) +7.29%
Token::balance_of_public 1,899 (+129) +7.29%
Lending::get_asset 2,200 (+147) +7.16%
Token::mint_to_public 2,863 (+187) +6.99%
NFT::mint 2,840 (+183) +6.89%
Lending::init 2,953 (+190) +6.88%
Benchmarking::public_dispatch 3,963 (+247) +6.65%
Benchmarking::increment_balance 2,381 (+143) +6.39%
CardGame::start_game 7,022 (+421) +6.38%
FeeJuice::check_balance 2,222 (+133) +6.37%
Lending::get_position 5,000 (+298) +6.34%
Lending::_deposit 2,536 (+151) +6.33%
Spam::public_dispatch 3,244 (+190) +6.22%
AvmTest::get_args_hash 1,804 (+99) +5.81%
FeeJuice::public_dispatch 5,287 (+283) +5.66%
Auth::get_authorized_delay 2,051 (+108) +5.56%
AvmInitializerTest::constructor 1,952 (+95) +5.12%
PriceFeed::public_dispatch 3,093 (+146) +4.95%
CardGame::public_dispatch 15,953 (+721) +4.73%
CardGame::on_game_joined 5,027 (+221) +4.60%
DocsExample::public_dispatch 4,190 (+175) +4.36%
Auth::get_scheduled_authorized 1,813 (+71) +4.08%
Auth::get_authorized 1,913 (+71) +3.85%
AvmInitializerTest::public_dispatch 2,710 (+95) +3.63%
Lending::update_accumulator 5,742 (+195) +3.52%
Crowdfunding::_publish_donation_receipts 953 (+31) +3.36%
Crowdfunding::public_dispatch 4,674 (+142) +3.13%
CardGame::on_cards_claimed 7,298 (+221) +3.12%
Lending::_repay 5,670 (+161) +2.92%
Router::public_dispatch 2,361 (+55) +2.39%
InclusionProofs::public_dispatch 3,762 (+87) +2.37%
TokenBlacklist::mint_public 3,996 (+92) +2.36%
AuthRegistry::consume 2,888 (+56) +1.98%
InclusionProofs::constructor 2,301 (+43) +1.90%
TokenBlacklist::mint_private 3,737 (+69) +1.88%
Uniswap::constructor 2,365 (+43) +1.85%
EasyPrivateVoting::constructor 2,402 (+43) +1.82%
Auth::constructor 2,406 (+43) +1.82%
Token::finalize_transfer_to_private 6,515 (+113) +1.77%
Token::_finalize_transfer_to_private_unsafe 6,562 (+113) +1.75%
NFT::public_dispatch 23,684 (+387) +1.66%
AMM::constructor 2,701 (+43) +1.62%
Crowdfunding::init 2,716 (+43) +1.61%
TestLog::emit_unencrypted_events 1,149 (+18) +1.59%
NFT::_store_payload_in_transient_storage_unsafe 1,185 (+18) +1.54%
Token::_store_payload_in_transient_storage_unsafe 1,185 (+18) +1.54%
AppSubscription::constructor 2,834 (+43) +1.54%
AvmTest::keccak_hash 2,398 (+35) +1.48%
TokenBlacklist::get_roles 2,682 (+38) +1.44%
NFT::finalize_transfer_to_private 5,420 (+71) +1.33%
NFT::_finalize_transfer_to_private_unsafe 5,467 (+71) +1.32%
TokenBlacklist::update_roles 6,132 (+79) +1.31%
Auth::set_authorized 4,544 (+56) +1.25%
Test::emit_unencrypted 1,484 (+18) +1.23%
Auth::set_authorized_delay 4,640 (+56) +1.22%
NFT::constructor 4,050 (+47) +1.17%
AuthRegistry::public_dispatch 7,938 (+92) +1.17%
Token::constructor 4,125 (+47) +1.15%
Auth::public_dispatch 8,790 (+100) +1.15%
Test::public_dispatch 19,125 (+216) +1.14%
Lending::_borrow 7,391 (+83) +1.14%
StatefulTest::public_dispatch 6,132 (+62) +1.02%
Token::finalize_mint_to_private 6,108 (+58) +0.96%
Token::_finalize_mint_to_private_unsafe 6,155 (+58) +0.95%
Parent::public_nested_static_call 3,360 (+30) +0.90%
AppSubscription::public_dispatch 3,995 (+35) +0.88%
Router::_check_block_number 976 (+8) +0.83%
Router::_check_timestamp 993 (+8) +0.81%
TokenBlacklist::constructor 6,227 (+43) +0.70%
Test::consume_message_from_arbitrary_sender_public 7,913 (+46) +0.58%
TokenBlacklist::burn_public 5,223 (+27) +0.52%
TokenBlacklist::transfer_public 5,603 (+27) +0.48%
AvmTest::emit_unencrypted_log 2,777 (+13) +0.47%
Token::burn_public 4,167 (+14) +0.34%
Token::transfer_in_public 4,217 (+14) +0.33%
TestLog::public_dispatch 2,320 (+6) +0.26%
Token::public_dispatch 31,494 (+78) +0.25%
TokenBlacklist::shield 5,791 (+14) +0.24%
Test::create_l2_to_l1_message_public 2,202 (+5) +0.23%
Claim::public_dispatch 3,252 (+7) +0.22%
AvmTest::pedersen_hash 3,095 (+5) +0.16%
AvmTest::pedersen_hash_with_index 3,095 (+5) +0.16%
StatefulTest::public_constructor 2,787 (+4) +0.14%
NFT::transfer_in_public 3,327 (+4) +0.12%
Claim::constructor 2,453 (-1) -0.04%
TokenBridge::constructor 2,357 (-1) -0.04%
FPC::constructor 2,318 (-1) -0.04%
TokenBlacklist::public_dispatch 23,178 (-79) -0.34%
AvmTest::u128_addition_overflow 1,337 (-5) -0.37%
Lending::_withdraw 8,633 (-47) -0.54%
StaticChild::public_dispatch 2,112 (-19) -0.89%
AuthWitTest::public_dispatch 1,659 (-17) -1.01%
AvmTest::bulk_testing 22,633 (-249) -1.09%
AvmTest::u128_from_integer_overflow 817 (-9) -1.09%
Test::consume_mint_to_public_message 10,767 (-135) -1.24%
AvmTest::sha256_hash 3,915 (-52) -1.31%
FPC::public_dispatch 7,131 (-109) -1.51%
TokenBridge::claim_public 11,261 (-174) -1.52%
AvmTest::pedersen_commit 1,263 (-21) -1.64%
Token::complete_refund 5,373 (-95) -1.74%
AvmTest::debug_logging 1,292 (-26) -1.97%
TokenBridge::public_dispatch 20,492 (-443) -2.12%
Parent::public_static_call 1,138 (-26) -2.23%
StaticParent::public_static_call 1,138 (-26) -2.23%
AvmTest::public_dispatch 60,662 (-1,456) -2.34%
AvmTest::assert_calldata_copy 531 (-13) -2.39%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 6,142 (-165) -2.62%
Parent::public_dispatch 7,629 (-211) -2.69%
AvmTest::returndata_copy_oracle 1,769 (-50) -2.75%
Uniswap::public_dispatch 22,971 (-670) -2.83%
Uniswap::swap_public 15,162 (-461) -2.95%
Child::public_dispatch 4,770 (-152) -3.09%
AMM::public_dispatch 20,802 (-670) -3.12%
Lending::public_dispatch 27,067 (-970) -3.46%
AvmTest::elliptic_curve_add_and_double 713 (-26) -3.52%
AvmTest::elliptic_curve_add 580 (-26) -4.29%
Parent::pub_entry_point 578 (-26) -4.30%
StaticParent::public_call 578 (-26) -4.30%
AvmTest::read_storage_list 284 (-13) -4.38%
StaticParent::public_dispatch 5,764 (-278) -4.60%
Parent::pub_entry_point_twice 975 (-52) -5.06%
Uniswap::_assert_token_is_same 717 (-39) -5.16%
StaticParent::public_nested_static_call 2,046 (-117) -5.41%
AvmTest::check_selector 227 (-13) -5.42%
DocsExample::get_public_immutable_constrained_public_indirect 656 (-39) -5.61%
Lending::withdraw_public 1,894 (-117) -5.82%
Lending::borrow_public 1,894 (-117) -5.82%
TokenBridge::exit_to_l1_public 6,327 (-391) -5.82%
AuthWitTest::consume_public 622 (-39) -5.90%
FPC::pay_refund 2,041 (-130) -5.99%
FPC::prepare_fee 1,986 (-130) -6.14%
Child::set_value_twice_with_nested_first 589 (-39) -6.21%
Child::set_value_twice_with_nested_last 589 (-39) -6.21%
AMM::_remove_liquidity 6,560 (-442) -6.31%
AvmTest::get_function_selector 192 (-13) -6.34%
AvmTest::nested_static_call_to_add 569 (-39) -6.41%
AvmTest::nested_call_to_add 569 (-39) -6.41%
AvmTest::nested_call_to_assert_same 569 (-39) -6.41%
AMM::_add_liquidity 8,043 (-559) -6.50%
StaticParent::public_get_value_from_child 555 (-39) -6.57%
AvmTest::nested_call_to_add_with_gas 544 (-39) -6.69%
AvmTest::create_different_nullifier_in_nested_call 494 (-39) -7.32%
AvmTest::create_same_nullifier_in_nested_call 484 (-39) -7.46%
ImportTest::pub_call_public_fn 479 (-39) -7.53%
AvmTest::nested_static_call_to_set_storage 478 (-39) -7.54%
Child::set_value_with_two_nested_calls 930 (-78) -7.74%
AvmTest::nested_call_to_nothing 464 (-39) -7.75%
AvmTest::external_call_to_assertion_failure 464 (-39) -7.75%
AvmTest::external_call_to_divide_by_zero 464 (-39) -7.75%
ImportTest::public_dispatch 1,061 (-91) -7.90%
Lending::repay_public 2,425 (-221) -8.35%
Lending::deposit_public 2,542 (-234) -8.43%

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Changes to circuit sizes

Generated at commit: 324b443a9d46062734bbf331c989d666a49d7ce2, compared to commit: 4fcbc592c963389a132b5b72f0f68d1f6526943b

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_reset_4_4_4_4_4_4_4_4_4 +2,098 ❌ +5.74% +13,627 ❌ +14.75%
parity_base +492 ❌ +13.83% +528 ❌ +1.76%
private_kernel_reset -2,201 ✅ -2.26% +3,818 ❌ +0.60%
rollup_merge +328 ❌ +11.22% +352 ❌ +0.02%
parity_root +492 ❌ +11.47% +528 ❌ +0.01%
rollup_block_root +330 ❌ +8.54% +354 ❌ +0.01%
private_kernel_tail -6 ✅ -0.11% -7 ✅ -0.05%
rollup_block_merge -2,323 ✅ -16.75% -2,263 ✅ -0.12%
rollup_root -2,323 ✅ -16.77% -2,263 ✅ -0.12%
private_kernel_inner -1,584 ✅ -3.43% -2,321 ✅ -3.61%
private_kernel_init -1,542 ✅ -5.52% -2,272 ✅ -5.61%
private_kernel_tail_to_public -1,176 ✅ -6.30% -2,842 ✅ -8.51%
rollup_base_public -2,114,283 ✅ -74.57% -3,634,599 ✅ -12.41%
rollup_base_private -2,099,150 ✅ -90.49% -3,599,111 ✅ -50.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_reset_4_4_4_4_4_4_4_4_4 38,676 (+2,098) +5.74% 105,995 (+13,627) +14.75%
parity_base 4,049 (+492) +13.83% 30,482 (+528) +1.76%
private_kernel_reset 95,121 (-2,201) -2.26% 642,517 (+3,818) +0.60%
rollup_merge 3,252 (+328) +11.22% 1,826,923 (+352) +0.02%
parity_root 4,782 (+492) +11.47% 3,636,544 (+528) +0.01%
rollup_block_root 4,192 (+330) +8.54% 2,739,382 (+354) +0.01%
private_kernel_tail 5,327 (-6) -0.11% 15,176 (-7) -0.05%
rollup_block_merge 11,544 (-2,323) -16.75% 1,858,081 (-2,263) -0.12%
rollup_root 11,528 (-2,323) -16.77% 1,858,067 (-2,263) -0.12%
private_kernel_inner 44,664 (-1,584) -3.43% 62,034 (-2,321) -3.61%
private_kernel_init 26,397 (-1,542) -5.52% 38,197 (-2,272) -5.61%
private_kernel_tail_to_public 17,502 (-1,176) -6.30% 30,552 (-2,842) -8.51%
rollup_base_public 721,202 (-2,114,283) -74.57% 25,650,146 (-3,634,599) -12.41%
rollup_base_private 220,672 (-2,099,150) -90.49% 3,598,501 (-3,599,111) -50.00%

@PhilWindle PhilWindle added e2e-all CI: Enables this CI job. network-all Run this CI job. labels Dec 6, 2024
@alexghr
Copy link
Contributor

alexghr commented Dec 9, 2024

Closing this as all changes went in as part #10344

@alexghr alexghr closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-all CI: Enables this CI job. network-all Run this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants