-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bootstrapping devnet #10396
fix: bootstrapping devnet #10396
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,7 +49,7 @@ function tryExtractEvent< | |
logger?: DebugLogger, | ||
): TEventType | undefined { | ||
for (const log of logs) { | ||
if (log.address === address) { | ||
if (log.address.toLowerCase() === address.toLowerCase()) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was the problem :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does viem return addresses in log entries checksummed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, while the address we stored for the contract was all-lower-cased |
||
try { | ||
const decodedEvent = decodeEventLog({ abi, ...log }); | ||
if (decodedEvent.eventName === eventName) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% if this is necessary anymore but might be useful to have on the PXE public API.