Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check max fees per gas #10283

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: check max fees per gas #10283

wants to merge 5 commits into from

Conversation

LeilaWang
Copy link
Contributor

Please read contributing guidelines and remove this line.

@LeilaWang LeilaWang added the e2e-all CI: Enables this CI job. label Nov 28, 2024
@LeilaWang LeilaWang linked an issue Nov 28, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Nov 28, 2024

Changes to public function bytecode sizes

Generated at commit: f028efdaf2d481922b2481fd64105bf182d8324b, compared to commit: c48ae90c5d72450a3a19b76e552df1607ff79953

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
AvmTest::nested_call_to_nothing +4 ❌ +0.86%
AvmTest::external_call_to_assertion_failure +4 ❌ +0.86%
AvmTest::external_call_to_divide_by_zero +4 ❌ +0.86%
Child::set_value_with_two_nested_calls +8 ❌ +0.86%
AvmTest::nested_static_call_to_set_storage +4 ❌ +0.84%
ImportTest::pub_call_public_fn +4 ❌ +0.84%
AvmTest::create_same_nullifier_in_nested_call +4 ❌ +0.83%
Parent::pub_entry_point_twice +8 ❌ +0.82%
AvmTest::create_different_nullifier_in_nested_call +4 ❌ +0.81%
AvmTest::nested_call_to_add_with_gas +4 ❌ +0.74%
StaticParent::public_get_value_from_child +4 ❌ +0.72%
AvmTest::nested_static_call_to_add +4 ❌ +0.70%
AvmTest::nested_call_to_assert_same +4 ❌ +0.70%
AvmTest::nested_call_to_add +4 ❌ +0.70%
Parent::pub_entry_point +4 ❌ +0.69%
StaticParent::public_call +4 ❌ +0.69%
Child::set_value_twice_with_nested_last +4 ❌ +0.68%
Child::set_value_twice_with_nested_first +4 ❌ +0.68%
AuthWitTest::consume_public +4 ❌ +0.64%
DocsExample::get_public_immutable_constrained_public_indirect +4 ❌ +0.61%
Uniswap::_assert_token_is_same +4 ❌ +0.56%
ImportTest::public_dispatch +4 ❌ +0.38%
Parent::public_static_call +4 ❌ +0.35%
StaticParent::public_static_call +4 ❌ +0.35%
Lending::repay_public +8 ❌ +0.33%
Lending::deposit_public +8 ❌ +0.31%
StaticParent::public_dispatch +16 ❌ +0.28%
Parent::public_dispatch +20 ❌ +0.26%
AuthWitTest::public_dispatch +4 ❌ +0.24%
NFT::transfer_in_public +8 ❌ +0.24%
Uniswap::swap_public +36 ❌ +0.24%
TokenBlacklist::burn_public +12 ❌ +0.23%
AvmTest::returndata_copy_oracle +4 ❌ +0.23%
Lending::_borrow +16 ❌ +0.22%
TokenBlacklist::transfer_public +12 ❌ +0.21%
Lending::borrow_public +4 ❌ +0.21%
Lending::withdraw_public +4 ❌ +0.21%
TokenBlacklist::shield +12 ❌ +0.21%
AvmTest::sha256_hash +8 ❌ +0.20%
FPC::prepare_fee +4 ❌ +0.20%
FPC::pay_refund +4 ❌ +0.20%
StaticParent::public_nested_static_call +4 ❌ +0.20%
Token::burn_public +8 ❌ +0.19%
Token::transfer_in_public +8 ❌ +0.19%
TokenBridge::exit_to_l1_public +12 ❌ +0.19%
Lending::_withdraw +16 ❌ +0.19%
Benchmarking::increment_balance +4 ❌ +0.17%
CardGame::on_game_joined +8 ❌ +0.16%
Lending::_deposit +4 ❌ +0.16%
StatefulTest::public_constructor +4 ❌ +0.14%
TokenBridge::claim_public +16 ❌ +0.14%
Lending::_repay +8 ❌ +0.14%
Lending::update_accumulator +8 ❌ +0.14%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 +8 ❌ +0.13%
Parent::public_nested_static_call +4 ❌ +0.12%
TokenBridge::public_dispatch +24 ❌ +0.12%
FPC::public_dispatch +8 ❌ +0.11%
Test::consume_mint_to_public_message +12 ❌ +0.11%
Uniswap::public_dispatch +24 ❌ +0.10%
Test::consume_message_from_arbitrary_sender_public +8 ❌ +0.10%
Benchmarking::public_dispatch +4 ❌ +0.10%
DocsExample::public_dispatch +4 ❌ +0.10%
TokenBlacklist::public_dispatch +20 ❌ +0.09%
Child::public_dispatch +4 ❌ +0.08%
Lending::get_position +4 ❌ +0.08%
StatefulTest::public_dispatch +4 ❌ +0.07%
Test::public_dispatch +12 ❌ +0.06%
Lending::public_dispatch +16 ❌ +0.06%
Token::public_dispatch +16 ❌ +0.05%
NFT::public_dispatch +12 ❌ +0.05%
CardGame::public_dispatch +8 ❌ +0.05%
AvmTest::bulk_testing +8 ❌ +0.04%
AvmTest::public_dispatch +20 ❌ +0.03%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
AvmTest::nested_call_to_nothing 468 (+4) +0.86%
AvmTest::external_call_to_assertion_failure 468 (+4) +0.86%
AvmTest::external_call_to_divide_by_zero 468 (+4) +0.86%
Child::set_value_with_two_nested_calls 938 (+8) +0.86%
AvmTest::nested_static_call_to_set_storage 482 (+4) +0.84%
ImportTest::pub_call_public_fn 483 (+4) +0.84%
AvmTest::create_same_nullifier_in_nested_call 488 (+4) +0.83%
Parent::pub_entry_point_twice 983 (+8) +0.82%
AvmTest::create_different_nullifier_in_nested_call 498 (+4) +0.81%
AvmTest::nested_call_to_add_with_gas 548 (+4) +0.74%
StaticParent::public_get_value_from_child 559 (+4) +0.72%
AvmTest::nested_static_call_to_add 573 (+4) +0.70%
AvmTest::nested_call_to_assert_same 573 (+4) +0.70%
AvmTest::nested_call_to_add 573 (+4) +0.70%
Parent::pub_entry_point 582 (+4) +0.69%
StaticParent::public_call 582 (+4) +0.69%
Child::set_value_twice_with_nested_last 593 (+4) +0.68%
Child::set_value_twice_with_nested_first 593 (+4) +0.68%
AuthWitTest::consume_public 626 (+4) +0.64%
DocsExample::get_public_immutable_constrained_public_indirect 660 (+4) +0.61%
Uniswap::_assert_token_is_same 721 (+4) +0.56%
ImportTest::public_dispatch 1,065 (+4) +0.38%
Parent::public_static_call 1,142 (+4) +0.35%
StaticParent::public_static_call 1,142 (+4) +0.35%
Lending::repay_public 2,433 (+8) +0.33%
Lending::deposit_public 2,550 (+8) +0.31%
StaticParent::public_dispatch 5,780 (+16) +0.28%
Parent::public_dispatch 7,649 (+20) +0.26%
AuthWitTest::public_dispatch 1,663 (+4) +0.24%
NFT::transfer_in_public 3,335 (+8) +0.24%
Uniswap::swap_public 15,198 (+36) +0.24%
TokenBlacklist::burn_public 5,235 (+12) +0.23%
AvmTest::returndata_copy_oracle 1,773 (+4) +0.23%
Lending::_borrow 7,407 (+16) +0.22%
TokenBlacklist::transfer_public 5,615 (+12) +0.21%
Lending::borrow_public 1,898 (+4) +0.21%
Lending::withdraw_public 1,898 (+4) +0.21%
TokenBlacklist::shield 5,803 (+12) +0.21%
AvmTest::sha256_hash 3,923 (+8) +0.20%
FPC::prepare_fee 1,990 (+4) +0.20%
FPC::pay_refund 2,045 (+4) +0.20%
StaticParent::public_nested_static_call 2,050 (+4) +0.20%
Token::burn_public 4,175 (+8) +0.19%
Token::transfer_in_public 4,225 (+8) +0.19%
TokenBridge::exit_to_l1_public 6,339 (+12) +0.19%
Lending::_withdraw 8,649 (+16) +0.19%
Benchmarking::increment_balance 2,385 (+4) +0.17%
CardGame::on_game_joined 5,035 (+8) +0.16%
Lending::_deposit 2,540 (+4) +0.16%
StatefulTest::public_constructor 2,791 (+4) +0.14%
TokenBridge::claim_public 11,277 (+16) +0.14%
Lending::_repay 5,678 (+8) +0.14%
Lending::update_accumulator 5,750 (+8) +0.14%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 6,150 (+8) +0.13%
Parent::public_nested_static_call 3,364 (+4) +0.12%
TokenBridge::public_dispatch 20,516 (+24) +0.12%
FPC::public_dispatch 7,139 (+8) +0.11%
Test::consume_mint_to_public_message 10,779 (+12) +0.11%
Uniswap::public_dispatch 22,995 (+24) +0.10%
Test::consume_message_from_arbitrary_sender_public 7,921 (+8) +0.10%
Benchmarking::public_dispatch 3,967 (+4) +0.10%
DocsExample::public_dispatch 4,194 (+4) +0.10%
TokenBlacklist::public_dispatch 23,198 (+20) +0.09%
Child::public_dispatch 4,774 (+4) +0.08%
Lending::get_position 5,004 (+4) +0.08%
StatefulTest::public_dispatch 6,136 (+4) +0.07%
Test::public_dispatch 19,137 (+12) +0.06%
Lending::public_dispatch 27,083 (+16) +0.06%
Token::public_dispatch 31,510 (+16) +0.05%
NFT::public_dispatch 23,696 (+12) +0.05%
CardGame::public_dispatch 15,961 (+8) +0.05%
AvmTest::bulk_testing 22,641 (+8) +0.04%
AvmTest::public_dispatch 60,682 (+20) +0.03%

Copy link
Contributor

Changes to circuit sizes

Generated at commit: e6e41e4adf3f0f25a0f57d8e7bfe7df2667a3bd9, compared to commit: c48ae90c5d72450a3a19b76e552df1607ff79953

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_private +166 ❌ +0.10% +366 ❌ +0.01%
rollup_base_public +166 ❌ +0.05% +366 ❌ +0.01%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_private 169,340 (+166) +0.10% 2,617,675 (+366) +0.01%
rollup_base_public 355,840 (+166) +0.05% 3,868,303 (+366) +0.01%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-all CI: Enables this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Use max_fee_per_gas from GasSettings
1 participant