fix: also publish to version tag if on master, not just to master #10196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thunkar
approved these changes
Nov 26, 2024
spypsy
reviewed
Nov 26, 2024
| if [ "${{ github.ref_name }}" == "master" ]; then | ||
| TAG=master | ||
| else | ||
| TAG=${{ env.DEPLOY_TAG }} | ||
| export TF_VAR_VERSION=${TAG#aztec-packages-v} |
There was a problem hiding this comment.
I have a PR here which I forgot to merge 🤦 : #10095
This fixes the issue you're tackling here
|
#10095 solved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A switch condition was being hit to deploy with master as the tag if we were on master, but it was NOT also deploying to the version when i think it should.
This has left the docker composes unupdated after the last release, when they should have been updated
WARNING: I HAVE NOT RAN THIS SCRIPT CHANGE