Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getNotes return NEW_NULLIFIERS_LENGTH number of notes #941

Closed
suyash67 opened this issue Jun 30, 2023 · 1 comment · Fixed by #8833
Closed

Make getNotes return NEW_NULLIFIERS_LENGTH number of notes #941

suyash67 opened this issue Jun 30, 2023 · 1 comment · Fixed by #8833
Labels
C-aztec.nr Component: Aztec smart contract framework

Comments

@suyash67
Copy link
Contributor

Currently, the oracle call to get notes owned by a user from the database returns TWO notes (hard-coded 😭). This is probably because we used to have TWO input notes in Aztec connect. For aztec, we plan to allow the number of input notes to be spent equal to: NEW_NULLIFIERS_LENGTH = 4. This value could be increased in the near future.

So, we should allow a user to fetch at least NEW_NULLIFIERS_LENGTH number of notes. Note that the maximum number of notes a user can spend in one transaction right now is: NEW_NULLIFIERS_LENGTH * PRIVATE_CALLS_STACK_LEN.
@github-project-automation github-project-automation bot moved this to Todo in A3 Jun 30, 2023
@iAmMichaelConnor
Copy link
Contributor

@suyash67 did this get resolved during the offsite?

@iAmMichaelConnor iAmMichaelConnor added the C-aztec.nr Component: Aztec smart contract framework label Aug 25, 2023
@dbanks12 dbanks12 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 29, 2023
ludamad added a commit that referenced this issue Sep 26, 2024
@ludamad
chore(bb.js): strip wasm-threads again
6221890 
per community request, closes #941
@ludamad ludamad mentioned this issue Sep 26, 2024
Merged
ludamad added a commit that referenced this issue Sep 26, 2024
@ludamad
chore(bb.js): strip wasm-threads again (#8833)
68ba5d4 
per community request, closes #941
Rumata888 pushed a commit that referenced this issue Sep 27, 2024
@ludamad @Rumata888
chore(bb.js): strip wasm-threads again (#8833)
ec3a315 
per community request, closes #941
Rumata888 pushed a commit that referenced this issue Sep 27, 2024
@ludamad @Rumata888
chore(bb.js): strip wasm-threads again (#8833)
04b8806 
per community request, closes #941
Rumata888 pushed a commit that referenced this issue Sep 27, 2024
@ludamad @Rumata888
chore(bb.js): strip wasm-threads again (#8833)
33fa756 
per community request, closes #941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-aztec.nr Component: Aztec smart contract framework
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(bb.js): strip wasm-threads again AztecProtocol/aztec-packages
3 participants
@suyash67 @iAmMichaelConnor @dbanks12