Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private ordering circuit should delete nullifier and pending commitment when match is found #836

Closed
Tracked by #512
dbanks12 opened this issue Jun 13, 2023 · 0 comments · Fixed by #1089
Closed
Tracked by #512

Private ordering circuit should delete nullifier and pending commitment when match is found #836

dbanks12 opened this issue Jun 13, 2023 · 0 comments · Fixed by #1089
Assignees
@dbanks12
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Milestone
🚀 Initial F&F San...

Comments

@dbanks12
Copy link
Collaborator

dbanks12 commented Jun 13, 2023 •
edited
Loading

  1. See spec here
  2. Create C++ test that submits a new commitment and its nullifier in the same TX and ensure they are deleted.
  3. Create C++ test that repeats this but creates the new commitment and its nullifier in different kernel iterations.

Not all read requests will have nullifiers and vice versa.
@dbanks12 dbanks12 added this to A3 Jun 13, 2023
@dbanks12 dbanks12 converted this from a draft issue Jun 13, 2023
@dbanks12 dbanks12 added the C-protocol-circuits Component: Protocol circuits (kernel & rollup) label Jun 13, 2023
This was referenced Jun 13, 2023
Closed
Closed
@dbanks12 dbanks12 changed the title [C++] Kernel should delete nullifier and pending commitment when match is found [C++] Private kernel should delete nullifier and pending commitment when match is found Jun 13, 2023
@dbanks12 dbanks12 changed the title [C++] Private kernel should delete nullifier and pending commitment when match is found [C++] Private ordering circuit should delete nullifier and pending commitment when match is found Jun 16, 2023
@dbanks12 dbanks12 mentioned this issue Jul 14, 2023
Closed
@jeanmon jeanmon self-assigned this Jul 17, 2023
@jeanmon jeanmon moved this from Todo to In Progress in A3 Jul 17, 2023
@jeanmon jeanmon mentioned this issue Jul 17, 2023
Merged
6 tasks
@dbanks12 dbanks12 assigned dbanks12 and unassigned jeanmon Aug 7, 2023
@dbanks12 dbanks12 changed the title [C++] Private ordering circuit should delete nullifier and pending commitment when match is found Private ordering circuit should delete nullifier and pending commitment when match is found Aug 7, 2023
dbanks12 pushed a commit that referenced this issue Aug 11, 2023
@jeanmon
836 - nullifying pending commitments in private kernel ordering circu…
1c18cc3 
…it (#1089)

Closes #836
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbanks12 dbanks12

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
A3
Archived in project
Milestone
🚀 Initial F&F Sandbox Release
Development

Successfully merging a pull request may close this issue.

836 - nullifying pending commitments in private kernel ordering circuit AztecProtocol/aztec-packages
2 participants
@dbanks12 @jeanmon