Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo: token bridge tutorial uses incorrect dir-name #8199

Closed
FilipHarald opened this issue Aug 27, 2024 · 1 comment · Fixed by #8214
Closed

typo: token bridge tutorial uses incorrect dir-name #8199

FilipHarald opened this issue Aug 27, 2024 · 1 comment · Fixed by #8214

Comments

@FilipHarald
Copy link
Contributor

Here the tutorial is referencing token-bridge, but everywhere else it's called token_bridge.

https://github.com/AztecProtocol/aztec-packages/blob/master/docs/docs/tutorials/codealong/contract_tutorials/advanced/token_bridge/2_minting_on_aztec.md?plain=1#L9
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 27, 2024
@FilipHarald FilipHarald mentioned this issue Aug 27, 2024
Closed
@FilipHarald
Copy link
Contributor Author

Also, these cds are unecessary: https://github.com/AztecProtocol/aztec-packages/blob/master/docs/docs/tutorials/codealong/contract_tutorials/advanced/token_bridge/4_typescript_glue_code.md?plain=1#L12

@ludamad ludamad mentioned this issue Aug 27, 2024
Merged
ludamad added a commit that referenced this issue Aug 27, 2024
@ludamad @FilipHarald @AztecBot
chore: redo typo PR by FilipHarald (#8214)
895c700 
Thanks FilipHarald for
#8200. Our policy is
to redo typo changes to dissuade metric farming. This is an automated
script.

Resolves: #8199

---------

Co-authored-by: filip <[email protected]>
Co-authored-by: AztecBot <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 27, 2024
@FilipHarald FilipHarald mentioned this issue Sep 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
1 participant
@FilipHarald