refactor: get rid of time traveler #8153
Comments
This was referenced Aug 22, 2024
LHerskind
added a commit
that referenced
this issue
Aug 29, 2024
Doing some cleanup after #7850, looking to address the issue of #8153 and #8110. - #8153 - Addressed by including a "watcher" as part of the setup, which will push us to the next slot if there is already a block proposed for the current one. - #8110 - Updates the logic in the contract such that we can deal with "simulating" in the future, and use this from the sequencer. Gets rid of the `time_traveler` from the l1-publisher, now lives in the watcher which is used in tests. Issues related to slot duration is still to be addressed, so the name of this branch got slightly funky. Taking over the extra check added in #8204 since i) they are related and ii) the pain of going through CI made me do it.
|
This was fixed in #8148 |
codygunton
pushed a commit
that referenced
this issue
Aug 30, 2024
Doing some cleanup after #7850, looking to address the issue of #8153 and #8110. - #8153 - Addressed by including a "watcher" as part of the setup, which will push us to the next slot if there is already a block proposed for the current one. - #8110 - Updates the logic in the contract such that we can deal with "simulating" in the future, and use this from the sequencer. Gets rid of the `time_traveler` from the l1-publisher, now lives in the watcher which is used in tests. Issues related to slot duration is still to be addressed, so the name of this branch got slightly funky. Taking over the extra check added in #8204 since i) they are related and ii) the pain of going through CI made me do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The time traveler and
commitTimeJumpshould not be necessary, they should be removed.The text was updated successfully, but these errors were encountered: