Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hash in l1_to_l2_message.ts #646

Closed
LHerskind opened this issue May 22, 2023 · 0 comments · Fixed by #772
Closed

Remove hash in l1_to_l2_message.ts #646

LHerskind opened this issue May 22, 2023 · 0 comments · Fixed by #772
Assignees
@rahul-kothari

Comments

@LHerskind
Copy link
Contributor

In yarn-project/types/src/l1_to_l2_message.ts the hash function is computing a different result than solidity, update it such that it is on par. Issue is serialization.
@LHerskind LHerskind added this to A3 May 22, 2023
@LHerskind LHerskind converted this from a draft issue May 22, 2023
@LHerskind LHerskind mentioned this issue May 22, 2023
Merged
6 tasks
@Maddiaa0 Maddiaa0 added this to the 📥 L1->L2 Calls milestone May 22, 2023
@LHerskind LHerskind changed the title Refactor hash in l1_to_l2_message.ts Remove hash in l1_to_l2_message.ts Jun 5, 2023
@rahul-kothari rahul-kothari mentioned this issue Jun 7, 2023
Merged
6 tasks
@rahul-kothari rahul-kothari moved this from Todo to In Progress in A3 Jun 7, 2023
@rahul-kothari rahul-kothari moved this from In Progress to In Review in A3 Jun 7, 2023
rahul-kothari added a commit that referenced this issue Jun 7, 2023
@rahul-kothari
fix #741 and #646
baf1da8
rahul-kothari added a commit that referenced this issue Jun 7, 2023
@rahul-kothari
fix #741 and #646
b8a8ae0
rahul-kothari added a commit that referenced this issue Jun 8, 2023
@rahul-kothari
fix #741 and #646
6354587
rahul-kothari added a commit that referenced this issue Jun 8, 2023
@rahul-kothari
fix #741 and #646
53fd463
rahul-kothari added a commit that referenced this issue Jun 8, 2023
@rahul-kothari
fix #741 and #646
4743969
Maddiaa0 pushed a commit that referenced this issue Jun 8, 2023
@rahul-kothari
fix #741 and #646 (#772)
bb675e0 
* fix #741 and #646

* fix ci, naming, return fr

* don't pass secret as default val
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Jun 8, 2023
This was referenced Jul 25, 2023
Closed
Closed
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul-kothari rahul-kothari

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #741 and #646 AztecProtocol/aztec-packages
3 participants
@LHerskind @rahul-kothari @Maddiaa0