Add serde tests for circuit structs #6339
Comments
Merged
just-mitch
added a commit
that referenced
this issue
May 13, 2024
## Implemented [See spec](https://docs.aztec.network/protocol-specs/gas-and-fees/specifying-gas-fee-info). A boolean flag `is_fee_payer` in the PrivateCircuitPublicInputs. The private kernel circuits will check this flag for every call stack item. When a call stack item is found with `is_fee_payer` set, the kernel circuit will set `fee_payer` in its PrivateKernelCircuitPublicInputs to be the callStackItem.contractAddress. This is subsequently passed through the PublicKernelCircuitPublicInputs to the KernelCircuitPublicInputs. If a transaction attempts to set fee_payer multiple times, the transaction will be considered invalid. ## Deviations Whereas in the spec we said we would use `contract_address`, we have updated that to use `storage_contract_address` because it correctly handles delegate calls: if `is_fee_payer` gets set during delegate call, the "delegator" should be the `fee_payer`, not the "delegatee". ## Remaining Actually setting `fee_payer` in a contract, and making assertions. (#5920) If the fee_payer is not set, the transaction will be considered invalid. (#6343) ## Elsewhere Unit tests on SerDe (#6339)
AztecBot
pushed a commit
to AztecProtocol/aztec-nr
that referenced
this issue
May 14, 2024
## Implemented [See spec](https://docs.aztec.network/protocol-specs/gas-and-fees/specifying-gas-fee-info). A boolean flag `is_fee_payer` in the PrivateCircuitPublicInputs. The private kernel circuits will check this flag for every call stack item. When a call stack item is found with `is_fee_payer` set, the kernel circuit will set `fee_payer` in its PrivateKernelCircuitPublicInputs to be the callStackItem.contractAddress. This is subsequently passed through the PublicKernelCircuitPublicInputs to the KernelCircuitPublicInputs. If a transaction attempts to set fee_payer multiple times, the transaction will be considered invalid. ## Deviations Whereas in the spec we said we would use `contract_address`, we have updated that to use `storage_contract_address` because it correctly handles delegate calls: if `is_fee_payer` gets set during delegate call, the "delegator" should be the `fee_payer`, not the "delegatee". ## Remaining Actually setting `fee_payer` in a contract, and making assertions. (AztecProtocol/aztec-packages#5920) If the fee_payer is not set, the transaction will be considered invalid. (AztecProtocol/aztec-packages#6343) ## Elsewhere Unit tests on SerDe (AztecProtocol/aztec-packages#6339)
iakovenkos
pushed a commit
that referenced
this issue
May 15, 2024
## Implemented [See spec](https://docs.aztec.network/protocol-specs/gas-and-fees/specifying-gas-fee-info). A boolean flag `is_fee_payer` in the PrivateCircuitPublicInputs. The private kernel circuits will check this flag for every call stack item. When a call stack item is found with `is_fee_payer` set, the kernel circuit will set `fee_payer` in its PrivateKernelCircuitPublicInputs to be the callStackItem.contractAddress. This is subsequently passed through the PublicKernelCircuitPublicInputs to the KernelCircuitPublicInputs. If a transaction attempts to set fee_payer multiple times, the transaction will be considered invalid. ## Deviations Whereas in the spec we said we would use `contract_address`, we have updated that to use `storage_contract_address` because it correctly handles delegate calls: if `is_fee_payer` gets set during delegate call, the "delegator" should be the `fee_payer`, not the "delegatee". ## Remaining Actually setting `fee_payer` in a contract, and making assertions. (#5920) If the fee_payer is not set, the transaction will be considered invalid. (#6343) ## Elsewhere Unit tests on SerDe (#6339)
superstar0402
added a commit
to superstar0402/aztec-nr
that referenced
this issue
Aug 16, 2024
## Implemented [See spec](https://docs.aztec.network/protocol-specs/gas-and-fees/specifying-gas-fee-info). A boolean flag `is_fee_payer` in the PrivateCircuitPublicInputs. The private kernel circuits will check this flag for every call stack item. When a call stack item is found with `is_fee_payer` set, the kernel circuit will set `fee_payer` in its PrivateKernelCircuitPublicInputs to be the callStackItem.contractAddress. This is subsequently passed through the PublicKernelCircuitPublicInputs to the KernelCircuitPublicInputs. If a transaction attempts to set fee_payer multiple times, the transaction will be considered invalid. ## Deviations Whereas in the spec we said we would use `contract_address`, we have updated that to use `storage_contract_address` because it correctly handles delegate calls: if `is_fee_payer` gets set during delegate call, the "delegator" should be the `fee_payer`, not the "delegatee". ## Remaining Actually setting `fee_payer` in a contract, and making assertions. (AztecProtocol/aztec-packages#5920) If the fee_payer is not set, the transaction will be considered invalid. (AztecProtocol/aztec-packages#6343) ## Elsewhere Unit tests on SerDe (AztecProtocol/aztec-packages#6339)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I got bit on a proving test because I forgot to add a field to the serialization function of
PrivateKernelCircuitPublicInputs.Add unit tests in noir to prevent this, and similar bugs.
This requires implementing deserialization methods for many structs.
The text was updated successfully, but these errors were encountered: