Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Contract Cleanup + Write out style guide #593

Closed
LHerskind opened this issue May 16, 2023 · 1 comment · Fixed by #856
Closed

General Contract Cleanup + Write out style guide #593

LHerskind opened this issue May 16, 2023 · 1 comment · Fixed by #856
Assignees
Labels
A-documentation Area: relates to documentation A-internal-devex Area: Relates to the devex of internal teams building Aztec.

Comments

@LHerskind
Copy link
Contributor

Write out the styleguide that Jan and I used for Aztec connect + update it and see if we can use https://github.com/0xKitsune/solstat to enforce as much of it as possible (or add extra rules).
If solstat requires too much work to get to a good state for us, consider using https://github.com/LHerskind/solhint which has many of the rules, but relies on gettign node into the contracts part again 😓.

Update the contracts to follow the style guide.

@LHerskind LHerskind added this to A3 May 16, 2023
@LHerskind LHerskind converted this from a draft issue May 16, 2023
@LHerskind LHerskind self-assigned this May 16, 2023
@LHerskind LHerskind added A-documentation Area: relates to documentation A-internal-devex Area: Relates to the devex of internal teams building Aztec. labels May 16, 2023
@LHerskind LHerskind moved this from Todo to In Progress in A3 May 23, 2023
@LHerskind
Copy link
Contributor Author

Adding linter and performing some general cleanup in #667 and #674.

@LHerskind LHerskind mentioned this issue Jun 15, 2023
6 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Jun 15, 2023
ludamad pushed a commit that referenced this issue Jul 14, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: relates to documentation A-internal-devex Area: Relates to the devex of internal teams building Aztec.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant