Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of L2Tx with TxEffect and nuke it #4845

Closed
benesjan opened this issue Feb 28, 2024 · 0 comments · Fixed by #4876
Closed

Replace usage of L2Tx with TxEffect and nuke it #4845

benesjan opened this issue Feb 28, 2024 · 0 comments · Fixed by #4876

Comments

@benesjan
Copy link
Contributor

L2Tx is now basically the same thing as TxEffect so it makes sense to nuke it in order to not have many redundant types. I really disliked this one anyway because it just super confusing when we have Tx as well. Having just Tx and TxEffect will be pretty elegant.
@github-project-automation github-project-automation bot moved this to Todo in A3 Feb 28, 2024
This was referenced Feb 29, 2024
Closed
Merged
benesjan added a commit that referenced this issue Mar 1, 2024
@benesjan
refactor: replacing use of L2Tx with TxEffect (#4876)
d9acaa4 
Fixes #4845
\+ dropped 'new' from TxEffect's properties (originally had this in
separate PR but with graphite trial end it got messed up)
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
1 participant
@benesjan