Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MAX_NEW_COMMITMENTS_PER_TX to MAX_NEW_NOTE_HASHES_PER_TX #4593

Closed
sklppy88 opened this issue Feb 13, 2024 · 1 comment · Fixed by #4717
Closed

Rename MAX_NEW_COMMITMENTS_PER_TX to MAX_NEW_NOTE_HASHES_PER_TX #4593

sklppy88 opened this issue Feb 13, 2024 · 1 comment · Fixed by #4717
Assignees
@sklppy88

Comments

@sklppy88
Copy link
Contributor

sklppy88 commented Feb 13, 2024 •
edited
Loading

We should rename the constants here to be `MAX_NEW_NOTE_HASHES_PER_TX`. Would be good for consistency I think. But needs to have changes multiple places so can be done in a different PR.

Originally posted by @LHerskind in #4541 (comment)
@github-project-automation github-project-automation bot moved this to Todo in A3 Feb 13, 2024
@sklppy88 sklppy88 self-assigned this Feb 13, 2024
@LHerskind LHerskind mentioned this issue Feb 14, 2024
Merged
@benesjan benesjan mentioned this issue Feb 26, 2024
Merged
@benesjan
Copy link
Contributor

Addressed in #4593

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sklppy88 sklppy88

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: using Tuples in TxEffects and renaming note commitments AztecProtocol/aztec-packages
2 participants
@benesjan @sklppy88