Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AztecNode.getBlocks(0, ...) should return from genesis #411

Closed
LHerskind opened this issue Apr 28, 2023 · 0 comments · Fixed by #2816
Closed

AztecNode.getBlocks(0, ...) should return from genesis #411

LHerskind opened this issue Apr 28, 2023 · 0 comments · Fixed by #2816
Assignees
@benesjan

Comments

@LHerskind
Copy link
Contributor

If running AztecNode::getBlocks(0, ...) it will throw an error. While this makes sense when understanding that the genesis (block 0) is essentially the state set in the L1 contract, it feels wrong and unnecessarily clunky to make it throw. Instead i suggest that we just make it behave like starting from 1 to let getBlocks(0, ...) simply indicate: "give me blocks from the beginning".
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 28, 2023
ludamad added a commit that referenced this issue Jul 14, 2023
@suyash67 @ludamad @codygunton
Pending bb work for aztec3 (#368)
4487114 
* update js vk (because we now use UP for merkle hashing)

* Helpers for ECDSA in A3 (#364)

* Add `stdlib_keccak` in cmake.

Correct an assertion in `to_byte_array` in bigfield.

* Add `random_element` to affine element.

* negate y conditionally.

* Change pedersen hash c_bind to use `pedersen_hash::lookup`.

* c_binds and other ECDSA related fixes (#407)

* Add v to stdlib ecdsa.

* create an engine if its empty.

* Add ecdsa c_bind.

* print v as a uint32.

* Add secp256k1 cbind.

add c_bind.hpp

Change hpp to h.

remove hpp.

* Add ecdsa in cmakelists.

remove stdlib_ecdsa from build.

* chore: align BARRETENBERG_CRYPTO_GENERATOR_PARAMETERS_HACK usage (#411)

* Update join_split test

* Tweaks to comments

* Add comment for the assertion in bigfield.

* Expanded on ecdsa comment.

---------

Co-authored-by: ludamad <[email protected]>
Co-authored-by: ludamad <[email protected]>
Co-authored-by: codygunton <[email protected]>
ludamad added a commit that referenced this issue Jul 14, 2023
@dbanks12 @suyash67 @ludamad
feat: CI to test aztec circuits with current commit of bberg (#418)
adbbddc 
* More generators for aztec3.

* update js vk (because we now use UP for merkle hashing)

* Helpers for ECDSA in A3 (#364)

* Add `stdlib_keccak` in cmake.

Correct an assertion in `to_byte_array` in bigfield.

* Add `random_element` to affine element.

* negate y conditionally.

* Change pedersen hash c_bind to use `pedersen_hash::lookup`.

* c_binds and other ECDSA related fixes (#407)

* Add v to stdlib ecdsa.

* create an engine if its empty.

* Add ecdsa c_bind.

* print v as a uint32.

* Add secp256k1 cbind.

add c_bind.hpp

Change hpp to h.

remove hpp.

* Add ecdsa in cmakelists.

remove stdlib_ecdsa from build.

* hack: (aztec3) introduce barretenberg crypto generator parameters hack (#408)

* hack: introduce BARRETENBERG_CRYPTO_GENERATOR_PARAMETERS_HACK

* doc: concise

* chore: align BARRETENBERG_CRYPTO_GENERATOR_PARAMETERS_HACK usage

* CI to test aztec circuits with current commit of bberg

* build manifest

* chore: align BARRETENBERG_CRYPTO_GENERATOR_PARAMETERS_HACK usage (#411)

* try other branch of aztec packages

* ci rename script

* Update join_split test

* bump aztec version and merge in aztec3-temporary fixes

* aztec commit switched to branch

* bump aztec commit and document

* typo README.md

* Update README.md

---------

Co-authored-by: Suyash Bagad <[email protected]>
Co-authored-by: Suyash Bagad <[email protected]>
Co-authored-by: ludamad <[email protected]>
Co-authored-by: ludamad <[email protected]>
@benesjan benesjan self-assigned this Oct 11, 2023
@benesjan benesjan mentioned this issue Oct 11, 2023
Closed
@benesjan benesjan moved this from Todo to In Progress in A3 Oct 12, 2023
@benesjan benesjan mentioned this issue Oct 12, 2023
Merged
4 tasks
benesjan added a commit that referenced this issue Oct 12, 2023
@benesjan
refactor: from < genesis allowed in getBlocks (#2816)
5622b50 
Fixes #411
+ renamed getL2Blocks in archiver as getBlocks to make it consistent
with the naming in `AztecNode` interface.
+ removed the `getBlocksLength` function from archiver interface. It's
redundant because `getBlockNumber` can be used instead.
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Oct 12, 2023
codygunton added a commit that referenced this issue Jan 23, 2024
@suyash67 @ludamad @codygunton
Pending bb work for aztec3 (#368)
89946ae 
* update js vk (because we now use UP for merkle hashing)

* Helpers for ECDSA in A3 (#364)

* Add `stdlib_keccak` in cmake.

Correct an assertion in `to_byte_array` in bigfield.

* Add `random_element` to affine element.

* negate y conditionally.

* Change pedersen hash c_bind to use `pedersen_hash::lookup`.

* c_binds and other ECDSA related fixes (#407)

* Add v to stdlib ecdsa.

* create an engine if its empty.

* Add ecdsa c_bind.

* print v as a uint32.

* Add secp256k1 cbind.

add c_bind.hpp

Change hpp to h.

remove hpp.

* Add ecdsa in cmakelists.

remove stdlib_ecdsa from build.

* chore: align BARRETENBERG_CRYPTO_GENERATOR_PARAMETERS_HACK usage (#411)

* Update join_split test

* Tweaks to comments

* Add comment for the assertion in bigfield.

* Expanded on ecdsa comment.

---------

Co-authored-by: ludamad <[email protected]>
Co-authored-by: ludamad <[email protected]>
Co-authored-by: codygunton <[email protected]>
codygunton pushed a commit that referenced this issue Jan 23, 2024
@dbanks12 @suyash67 @ludamad
feat: CI to test aztec circuits with current commit of bberg (#418)
20a0873 
* More generators for aztec3.

* update js vk (because we now use UP for merkle hashing)

* Helpers for ECDSA in A3 (#364)

* Add `stdlib_keccak` in cmake.

Correct an assertion in `to_byte_array` in bigfield.

* Add `random_element` to affine element.

* negate y conditionally.

* Change pedersen hash c_bind to use `pedersen_hash::lookup`.

* c_binds and other ECDSA related fixes (#407)

* Add v to stdlib ecdsa.

* create an engine if its empty.

* Add ecdsa c_bind.

* print v as a uint32.

* Add secp256k1 cbind.

add c_bind.hpp

Change hpp to h.

remove hpp.

* Add ecdsa in cmakelists.

remove stdlib_ecdsa from build.

* hack: (aztec3) introduce barretenberg crypto generator parameters hack (#408)

* hack: introduce BARRETENBERG_CRYPTO_GENERATOR_PARAMETERS_HACK

* doc: concise

* chore: align BARRETENBERG_CRYPTO_GENERATOR_PARAMETERS_HACK usage

* CI to test aztec circuits with current commit of bberg

* build manifest

* chore: align BARRETENBERG_CRYPTO_GENERATOR_PARAMETERS_HACK usage (#411)

* try other branch of aztec packages

* ci rename script

* Update join_split test

* bump aztec version and merge in aztec3-temporary fixes

* aztec commit switched to branch

* bump aztec commit and document

* typo README.md

* Update README.md

---------

Co-authored-by: Suyash Bagad <[email protected]>
Co-authored-by: Suyash Bagad <[email protected]>
Co-authored-by: ludamad <[email protected]>
Co-authored-by: ludamad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: from < genesis allowed in getBlocks AztecProtocol/aztec-packages
2 participants
@benesjan @LHerskind