-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Prove contract inclusion with constructor args #3695
Comments
To be done as part of larger restructure related to #3533. |
Actually. The address of the contract is computed based on the aztec-packages/yarn-project/noir-protocol-circuits/src/crates/private-kernel-lib/src/common.nr Lines 298 to 306 in 7c8814e
|
1. Fixes AztecProtocol#3465 2. Fixes AztecProtocol#3695 3. naming consistency fix in get sibling path methods, 4. refactored the e2e test and each type of proof is now in a nested describe statement.
The leaf in the contracts tree should include the constructor vk + args hash. That way ensuring that it can easily be used in factory setups.
Currently the pre-image of the leafs are
(contract_address, portal_address, function_tree_root)
which makes it difficult to figure out if the constructor was also the same as desired.Why is this important? The functions might be the same, but if either the constructor or the arguments to it differs, it might set values differently to what was expected or other shenanigans.
The text was updated successfully, but these errors were encountered: