-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate sandbox, node, p2p-bootstrap etc into single binary #3552
Comments
I would add, don't just blindly implement the above. Might be worth having a discussion around what the best cli api is. program
.command('start')
.description('Start various processes')
.option('--sequencer [options]', 'Start the sequencer with options (e.g., "--sequencer option1=value1,option2=value2")')
.option('--prover [options]', 'Start the prover with options')
.option('--pxe [options]', 'Start PXE with options')
.action((options) => {
if (options.sequencer !== undefined) {
const sequencerOptions = parseOptions(options.sequencer);
// Start sequencer logic here with sequencerOptions
}
if (options.prover !== undefined) {
const proverOptions = parseOptions(options.prover);
// Start prover logic here with proverOptions
}
if (options.pxe !== undefined) {
const pxeOptions = parseOptions(options.pxe);
// Start PXE logic here with pxeOptions
}
});``` |
Proposed cli commands:
|
PhilWindle
changed the title
aztec(-sandbox) should have a cli interface.
Consolidate sandbox, node, p2p-bootstrap etc into single binary
Jan 3, 2024
spypsy
added a commit
that referenced
this issue
Jan 29, 2024
michaelelliot
pushed a commit
to Swoir/noir_rs
that referenced
this issue
Feb 28, 2024
Closes AztecProtocol#3552 Closes AztecProtocol#3811 - New `aztec` package, replaces `aztec-sandbox` - New `aztec start` CLI to run Aztec infra (node, sequencer, archiver, p2p-bootstrap)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It currently just runs and has a MODE env var. It's fine for certain things to be set in the environment as CLI arg alternatives, but this should be an application much like other network binaries. i.e. it accepts commands to define which subsystems are enabled.
e.g.
aztec --sandbox
aztec --sequencer
aztec --sequencer --prover
aztec --p2p-node
aztec --pxe
aztec --pxe --p2p-node
Obviously
sandbox
is mutually exclusive, but i think other subsystems are/should be optional?TLDR: Use commander to make our aztec binary more intuitive.
The text was updated successfully, but these errors were encountered: