Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup fixture ignores number of wallets if sandbox is connected #3214

Closed
LHerskind opened this issue Nov 2, 2023 · 0 comments · Fixed by #2732
Closed

Setup fixture ignores number of wallets if sandbox is connected #3214

LHerskind opened this issue Nov 2, 2023 · 0 comments · Fixed by #2732
Assignees
@LHerskind
Labels
T-bug Type: Bug. Something is broken.

Comments

@LHerskind
Copy link
Contributor

We have a setup fixture that take a parameter numberOfAccounts which it use as the number of accounts to deploy. However, if connected to a sandbox, it won't actually deploy the the number of specified accounts, instead it will always deploy a hardcoded number of accounts. So for tests that expect >3 (current hardcoded accounts) accounts, the setup will pass and tests will then fail when the account is to be used.

Example of this is in #2732.
@LHerskind LHerskind added the T-bug Type: Bug. Something is broken. label Nov 2, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Nov 2, 2023
@LHerskind LHerskind mentioned this issue Nov 3, 2023
Merged
4 tasks
@LHerskind LHerskind self-assigned this Nov 3, 2023
LHerskind added a commit that referenced this issue Nov 20, 2023
@LHerskind
feat: Slow updates experimentation (#2732)
193e6c8 
Fixes #2801. (Also fixes #3214)

Experimentation with slow updates in Noir. 

- Adds a slow update structure
  - Sparse tree to support membership and non-memberships
- Wraps this structure in a contract to make interaction easier
- Adds an oracle to make it practical to pass the >200 params.
- Implement token contract with blacklist and access control in the slow
tree.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
T-bug Type: Bug. Something is broken.
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Slow updates experimentation AztecProtocol/aztec-packages
1 participant
@LHerskind