Spike: Barretenberg ASSERT should not be ignored in wasm, or workaround
#308
Labels
T-bug
Type: Bug. Something is broken.
Comments
iAmMichaelConnor
changed the title
ASSERT should not be ignored in wasm, or workaroundASSERT should not be ignored in wasm, or workaround
|
This is bad, but I guess if we want runtime failures we should use throw_or_abort? I guess they are turned off for speed |
ludamad
pushed a commit
that referenced
this issue
Jul 14, 2023
* Add debugging CMake preset & update code-workspace --------- Co-authored-by: Blaine Bublitz <[email protected]>
|
Was this resolved with |
@iAmMichaelConnor I don't think so. I think that this ticket is for real assertions in barretenberg. Maybe we could stop using real asserts in barretenberg and instead implement something similar? |
codygunton
added a commit
that referenced
this issue
Jan 23, 2024
* Add debugging CMake preset & update code-workspace --------- Co-authored-by: Blaine Bublitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Asserts/exceptions don't work in wasm by default. This means that bberg functions (stdlib etc) with assertions that SHOULD FAIL, just skip the assertion when running in a wasm environment. This is bad and means that in production assertions will just be skipped!
We need to determine if it's possible/worth it to enable exceptions/asserts in wasm (performance issues?) or some other way to work around this (similar to
DummyComposer)?The text was updated successfully, but these errors were encountered: