Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get selector-encoded function signature and computed selector out of CLI #2895

Closed
spalladino opened this issue Oct 17, 2023 · 1 comment · Fixed by #3053
Closed

Get selector-encoded function signature and computed selector out of CLI #2895

spalladino opened this issue Oct 17, 2023 · 1 comment · Fixed by #3053
Assignees
@rahul-kothari
Labels
C-cli Component: Aztec CLI T-feedback Type: recording user feedback

Comments

@spalladino
Copy link
Collaborator

It's not trivial to get the function signature encoded exactly as needed for computing the selector, as we've seen several users struggling to get the correct signature to pass into compute_selector for calling call_public_function in their Noir contracts.

We should tweak the inspect-contract CLI command so it outputs the exact string the user needs to input into compute_selector (via an option? should it be the default? should it just show both versions?) as well as the computed selector (since we're at it).

Requested by @0xShaito from Wonderland
@spalladino spalladino added T-feedback Type: recording user feedback C-cli Component: Aztec CLI labels Oct 17, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 17, 2023
@rahul-kothari
Copy link
Contributor

like this idea a lot! Will pick it up!

@rahul-kothari rahul-kothari self-assigned this Oct 23, 2023
@rahul-kothari rahul-kothari mentioned this issue Oct 26, 2023
Merged
@rahul-kothari rahul-kothari moved this from Todo to In Review in A3 Oct 26, 2023
rahul-kothari added a commit that referenced this issue Oct 26, 2023
@rahul-kothari
feat: add function selector to cli to make it easier for to call func…
e0f0a8e 
…tions (#3053)

Fix #2895 
Fix #1996
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul-kothari rahul-kothari

Labels
C-cli Component: Aztec CLI T-feedback Type: recording user feedback
Projects
A3
Archived in project
Milestone
No milestone
2 participants
@spalladino @rahul-kothari