Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce static calls in the kernel #2872

Closed
LHerskind opened this issue Oct 16, 2023 · 1 comment
Closed

Enforce static calls in the kernel #2872

LHerskind opened this issue Oct 16, 2023 · 1 comment

Comments

@LHerskind
Copy link
Contributor

Currently the kernel accept flags for whether the call is static or not, however it don't actually enforce anything based on that flag.

If a call is static it should ensure that:

  • It don't modify any state
  • Child calls are set to be static as well

Authwitness is currently assuming that static calls will be enforced at some point, until then, it is allowing all the flows you could want re-entries and other good stuff.
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 16, 2023
@Thunkar Thunkar mentioned this issue Feb 13, 2024
Merged
Thunkar added a commit that referenced this issue Feb 14, 2024
@Thunkar
feat: static call support in aztec.nr and acir-simulator (#4106)
5f9546a 
Closes #4036,
#2872

Added support for static calls, making sure callcontext is properly
forwarded and checked in the simulator before reaching the kernel
circuits.
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this issue Mar 19, 2024
@Thunkar @AztecBot
feat: static call support in aztec.nr and acir-simulator (#4106)
2dac256 
Closes AztecProtocol/aztec-packages#4036,
AztecProtocol/aztec-packages#2872

Added support for static calls, making sure callcontext is properly
forwarded and checked in the simulator before reaching the kernel
circuits.
superstar0402 added a commit to superstar0402/aztec-nr that referenced this issue Aug 16, 2024
@superstar0402
feat: static call support in aztec.nr and acir-simulator (#4106)
76396d0 
Closes AztecProtocol/aztec-packages#4036,
AztecProtocol/aztec-packages#2872

Added support for static calls, making sure callcontext is properly
forwarded and checked in the simulator before reaching the kernel
circuits.
@iAmMichaelConnor
Copy link
Contributor

Looks like this should have been closed when #4106 was merged.

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LHerskind @iAmMichaelConnor