Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing blake3 for blake2 #2859

Open
kevaundray opened this issue Oct 14, 2023 · 0 comments
Open

Changing blake3 for blake2 #2859

kevaundray opened this issue Oct 14, 2023 · 0 comments
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)

Comments

@kevaundray
Copy link
Contributor

Observation

  • Noir doesn't support blake3s
  • Reducing the number of different hash functions being used, reduces the complexity.

Ideally, we only use sha256 since you need this for l2 to l1 communications, but the cost of sha256 is too high and when we implement poseidon we will likely want to use that instead of sha256 due to it being at least two order of magnitude cheaper in a SANRK
@kevaundray kevaundray added the C-protocol-circuits Component: Protocol circuits (kernel & rollup) label Oct 14, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 14, 2023
This was referenced Oct 14, 2023
Merged
Open
kevaundray added a commit that referenced this issue Oct 16, 2023
@kevaundray
chore!: Change blake3 to blake2 in private kernel (#2861)
d629940 
Related to #2859 

Opening this up in the case that there are no blockers to removing
blake3

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
A3
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevaundray