Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract PublicState serialization & deserialization #2838

Closed
catmcgee opened this issue Oct 13, 2023 · 0 comments
Closed

Abstract PublicState serialization & deserialization #2838

catmcgee opened this issue Oct 13, 2023 · 0 comments
Assignees
@Thunkar
Labels
A-internal-devex Area: Relates to the devex of internal teams building Aztec. C-aztec.nr Component: Aztec smart contract framework T-feedback Type: recording user feedback

Comments

@catmcgee
Copy link
Contributor

It clutters the contract with SERIALIZATION_LENGTH constants, and adds some extra mental overhead
@catmcgee catmcgee added A-internal-devex Area: Relates to the devex of internal teams building Aztec. C-aztec.nr Component: Aztec smart contract framework T-feedback Type: recording user feedback labels Oct 13, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 13, 2023
@Thunkar Thunkar mentioned this issue Jan 18, 2024
Merged
Thunkar added a commit that referenced this issue Jan 30, 2024
@Thunkar @sirasistant
chore!: Serialize, Deserialize and NoteInterface as Traits (#4135)
9e6605c 
Closes: #3756,
#2838


Taking advantage of @jfecher's fantastic work in
noir-lang/noir#4000, implemented `Serialize<N>`
and `Deserialize<N>`. Together with `NoteInterface`, they make possible
getting rid of all the serialization interfaces, which greatly simplify
how the storage is handled and opens the door to further improvements.
~~Still some clutter to go, the lengths are still needed in some
places.~~


![Brace yourself](https://i.imgflip.com/8crkve.jpg)

I'm so sorry.

---------

Co-authored-by: sirasistant <[email protected]>
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this issue Jan 31, 2024
@Thunkar @sirasistant @AztecBot
chore!: Serialize, Deserialize and NoteInterface as Traits (#4135)
8aa2962 
Closes: AztecProtocol/aztec-packages#3756,
AztecProtocol/aztec-packages#2838


Taking advantage of @jfecher's fantastic work in
noir-lang/noir#4000, implemented `Serialize<N>`
and `Deserialize<N>`. Together with `NoteInterface`, they make possible
getting rid of all the serialization interfaces, which greatly simplify
how the storage is handled and opens the door to further improvements.
~~Still some clutter to go, the lengths are still needed in some
places.~~


![Brace yourself](https://i.imgflip.com/8crkve.jpg)

I'm so sorry.

---------

Co-authored-by: sirasistant <[email protected]>
@Thunkar Thunkar closed this as completed Jan 31, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 31, 2024
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@Thunkar @sirasistant
chore!: Serialize, Deserialize and NoteInterface as Traits (AztecProt…
d288059 
…ocol#4135)

Closes: AztecProtocol#3756,
AztecProtocol#2838


Taking advantage of @jfecher's fantastic work in
noir-lang/noir#4000, implemented `Serialize<N>`
and `Deserialize<N>`. Together with `NoteInterface`, they make possible
getting rid of all the serialization interfaces, which greatly simplify
how the storage is handled and opens the door to further improvements.
~~Still some clutter to go, the lengths are still needed in some
places.~~


![Brace yourself](https://i.imgflip.com/8crkve.jpg)

I'm so sorry.

---------

Co-authored-by: sirasistant <[email protected]>
superstar0402 added a commit to superstar0402/aztec-nr that referenced this issue Aug 16, 2024
@superstar0402 @sirasistant
chore!: Serialize, Deserialize and NoteInterface as Traits (#4135)
e699bd5 
Closes: AztecProtocol/aztec-packages#3756,
AztecProtocol/aztec-packages#2838


Taking advantage of @jfecher's fantastic work in
noir-lang/noir#4000, implemented `Serialize<N>`
and `Deserialize<N>`. Together with `NoteInterface`, they make possible
getting rid of all the serialization interfaces, which greatly simplify
how the storage is handled and opens the door to further improvements.
~~Still some clutter to go, the lengths are still needed in some
places.~~


![Brace yourself](https://i.imgflip.com/8crkve.jpg)

I'm so sorry.

---------

Co-authored-by: sirasistant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thunkar Thunkar

Labels
A-internal-devex Area: Relates to the devex of internal teams building Aztec. C-aztec.nr Component: Aztec smart contract framework T-feedback Type: recording user feedback
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Thunkar @catmcgee