Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(benchmark): Measure block sync time #2637

Merged
merged 3 commits into from
Oct 3, 2023
Merged

chore(benchmark): Measure block sync time #2637

merged 3 commits into from
Oct 3, 2023

Conversation

spalladino
Copy link
Collaborator

Extends the bench_publish_rollup test to spin up a 2nd node, without a sequencer, to measure how long it takes to process the published blocks.

@spalladino
chore(benchmark): Measure block sync time
c09700f 
Extends the bench_publish_rollup test to spin up a 2nd node, without a
sequencer, to measure how long it takes to process the published blocks.
@spalladino spalladino requested a review from PhilWindle October 3, 2023 13:34
benesjan
benesjan reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@benesjan benesjan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Looks good 👍

scripts/ci/benchmark_shared.js Outdated

// Events to track
const ROLLUP_PUBLISHED_TO_L1 = "rollup-published-to-l1";
const ROLLUP_BLOCK_SYNCED = "l2-block-handled";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A while ago we agreed to use the name L2_BLOCK and not ROLLUP_BLOCK. I would ideally rename this to keep the naming consistent.

yarn-project/world-state/src/merkle-tree/merkle_tree_operations_facade.ts Outdated
@@ -144,7 +151,7 @@ export class MerkleTreeOperationsFacade implements MerkleTreeOperations {
* @param block - The L2 block to handle.
* @returns Empty promise.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated @return description ^

yarn-project/world-state/src/synchronizer/server_world_state_synchronizer.ts
duration: time.ms(),
isBlockOurs: result.isBlockOurs,
...l2Block.getStats(),
});
}
}

/**
* Handles a single L2 block (i.e. Inserts the new commitments into the merkle tree).
* @param l2Block - The L2 block to handle.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No return description ^.

yarn-project/world-state/src/world-state-db/merkle_trees.ts
@@ -381,8 +382,8 @@ export class MerkleTrees implements MerkleTreeDb {
* Handles a single L2 block (i.e. Inserts the new commitments into the merkle tree).
* @param block - The L2 block to handle.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing return desc here ^.

I hope I am not too much of a docs Karen but I think it makes sense to have the description when return is not void.

@spalladino spalladino requested a review from benesjan October 3, 2023 17:32
@spalladino
Copy link
Collaborator Author

@benesjan addressed all comments!

@spalladino spalladino enabled auto-merge (squash) October 3, 2023 17:32
@spalladino spalladino merged commit d11343f into master Oct 3, 2023
@spalladino spalladino deleted the palla/measure-block-sync-time branch October 3, 2023 17:48
@AztecBot AztecBot mentioned this pull request Oct 3, 2023
Merged
kevaundray pushed a commit that referenced this pull request Oct 3, 2023
@AztecBot
chore(master): Release 0.8.1 (#2640)
0731311 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.1</summary>

##
[0.8.1](aztec-packages-v0.8.0...aztec-packages-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](#2610))
([7cb7c58](7cb7c58))
* Benchmark script fixes for master branch
([#2638](#2638))
([0a161a4](0a161a4))
* Redirect sunset instructions
([#2646](#2646))
([9253442](9253442))
* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](#2649))
([84b8ff4](84b8ff4))


### Miscellaneous

* **benchmark:** Measure block sync time
([#2637](#2637))
([d11343f](d11343f))
* Update acir_tests script to point to master
([#2650](#2650))
([51d1e79](51d1e79))
</details>

<details><summary>barretenberg.js: 0.8.1</summary>

##
[0.8.1](barretenberg.js-v0.8.0...barretenberg.js-v0.8.1)
(2023-10-03)


### Bug Fixes

* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](#2649))
([84b8ff4](84b8ff4))
</details>

<details><summary>barretenberg: 0.8.1</summary>

##
[0.8.1](barretenberg-v0.8.0...barretenberg-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](#2610))
([7cb7c58](7cb7c58))


### Miscellaneous

* Update acir_tests script to point to master
([#2650](#2650))
([51d1e79](51d1e79))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Oct 5, 2023
@AztecBot
chore(master): Release 0.8.1 (#2640)
dc6de42 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.1</summary>

##
[0.8.1](AztecProtocol/aztec-packages@aztec-packages-v0.8.0...aztec-packages-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](AztecProtocol/aztec-packages#2610))
([7cb7c58](AztecProtocol/aztec-packages@7cb7c58))
* Benchmark script fixes for master branch
([#2638](AztecProtocol/aztec-packages#2638))
([0a161a4](AztecProtocol/aztec-packages@0a161a4))
* Redirect sunset instructions
([#2646](AztecProtocol/aztec-packages#2646))
([9253442](AztecProtocol/aztec-packages@9253442))
* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](AztecProtocol/aztec-packages#2649))
([84b8ff4](AztecProtocol/aztec-packages@84b8ff4))


### Miscellaneous

* **benchmark:** Measure block sync time
([#2637](AztecProtocol/aztec-packages#2637))
([d11343f](AztecProtocol/aztec-packages@d11343f))
* Update acir_tests script to point to master
([#2650](AztecProtocol/aztec-packages#2650))
([51d1e79](AztecProtocol/aztec-packages@51d1e79))
</details>

<details><summary>barretenberg.js: 0.8.1</summary>

##
[0.8.1](AztecProtocol/aztec-packages@barretenberg.js-v0.8.0...barretenberg.js-v0.8.1)
(2023-10-03)


### Bug Fixes

* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](AztecProtocol/aztec-packages#2649))
([84b8ff4](AztecProtocol/aztec-packages@84b8ff4))
</details>

<details><summary>barretenberg: 0.8.1</summary>

##
[0.8.1](AztecProtocol/aztec-packages@barretenberg-v0.8.0...barretenberg-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](AztecProtocol/aztec-packages#2610))
([7cb7c58](AztecProtocol/aztec-packages@7cb7c58))


### Miscellaneous

* Update acir_tests script to point to master
([#2650](AztecProtocol/aztec-packages#2650))
([51d1e79](AztecProtocol/aztec-packages@51d1e79))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Maddiaa0 pushed a commit that referenced this pull request Oct 6, 2023
@spalladino @Maddiaa0
chore(benchmark): Measure block sync time (#2637)
778ee51 
Extends the bench_publish_rollup test to spin up a 2nd node, without a
sequencer, to measure how long it takes to process the published blocks.
Maddiaa0 pushed a commit that referenced this pull request Oct 6, 2023
@AztecBot @Maddiaa0
chore(master): Release 0.8.1 (#2640)
1501345 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.1</summary>

##
[0.8.1](aztec-packages-v0.8.0...aztec-packages-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](#2610))
([7cb7c58](7cb7c58))
* Benchmark script fixes for master branch
([#2638](#2638))
([0a161a4](0a161a4))
* Redirect sunset instructions
([#2646](#2646))
([9253442](9253442))
* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](#2649))
([84b8ff4](84b8ff4))


### Miscellaneous

* **benchmark:** Measure block sync time
([#2637](#2637))
([d11343f](d11343f))
* Update acir_tests script to point to master
([#2650](#2650))
([51d1e79](51d1e79))
</details>

<details><summary>barretenberg.js: 0.8.1</summary>

##
[0.8.1](barretenberg.js-v0.8.0...barretenberg.js-v0.8.1)
(2023-10-03)


### Bug Fixes

* Remove -u from build_wasm script so that we can skip the build when
SKIP_CPP_BUILD is unset
([#2649](#2649))
([84b8ff4](84b8ff4))
</details>

<details><summary>barretenberg: 0.8.1</summary>

##
[0.8.1](barretenberg-v0.8.0...barretenberg-v0.8.1)
(2023-10-03)


### Bug Fixes

* Add missing ecc doubling gate into ultra plonk and ultra honk
([#2610](#2610))
([7cb7c58](7cb7c58))


### Miscellaneous

* Update acir_tests script to point to master
([#2650](#2650))
([51d1e79](51d1e79))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesjan benesjan benesjan approved these changes

@PhilWindle PhilWindle Awaiting requested review from PhilWindle

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spalladino @benesjan