Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce zero right-padded arrays in accumulated data of native private kernel circuit #2612

Closed
jeanmon opened this issue Oct 2, 2023 · 0 comments · Fixed by #2614
Closed

Enforce zero right-padded arrays in accumulated data of native private kernel circuit #2612

jeanmon opened this issue Oct 2, 2023 · 0 comments · Fixed by #2614
Assignees
@jeanmon
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Oct 2, 2023

This essentially consists in applying the validation introduced in #1090 for arrays in previous_kernel.public_inputs.end
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 2, 2023
@jeanmon jeanmon self-assigned this Oct 2, 2023
@jeanmon jeanmon added the C-protocol-circuits Component: Protocol circuits (kernel & rollup) label Oct 2, 2023
@jeanmon jeanmon moved this from Todo to In Progress in A3 Oct 2, 2023
@jeanmon jeanmon mentioned this issue Oct 2, 2023
Merged
4 tasks
@jeanmon jeanmon moved this from In Progress to In Review in A3 Oct 2, 2023
jeanmon added a commit that referenced this issue Oct 2, 2023
@jeanmon
chore(circuits): 2612 - add validation in native private kernel circu…
f1fe059 
…it of arrays in accumulated data (#2614)

Resolves #2612 

- Aded validation check for arrays in accumulated data of inner and
ordering private kernel circuit on the following
previous_kernel.public_inputs.end members:
    - read_requests
    - new_commitments
    - new_nullifiers
    - nullified_commitments
    - private_call_stack
    - public_call_stack
    - new_l2_to_l1_msgs
    
- Corresponding unit tests added on native private kernel circuits

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [x] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Oct 2, 2023
Maddiaa0 pushed a commit that referenced this issue Oct 6, 2023
@jeanmon @Maddiaa0
chore(circuits): 2612 - add validation in native private kernel circu…
9d69e2a 
…it of arrays in accumulated data (#2614)

Resolves #2612 

- Aded validation check for arrays in accumulated data of inner and
ordering private kernel circuit on the following
previous_kernel.public_inputs.end members:
    - read_requests
    - new_commitments
    - new_nullifiers
    - nullified_commitments
    - private_call_stack
    - public_call_stack
    - new_l2_to_l1_msgs
    
- Corresponding unit tests added on native private kernel circuits

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [x] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
A3
Archived in project
Milestone
No milestone
1 participant
@jeanmon