chore: Use retries by default on rpc client fetch #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
changed the title
PhilWindle
approved these changes
Sep 15, 2023
ludamad
pushed a commit
that referenced
this pull request
Sep 15, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.7.5</summary> ## [0.7.5](aztec-packages-v0.7.4...aztec-packages-v0.7.5) (2023-09-15) ### Features * Protogalaxy interfaces ([#2125](#2125)) ([b45dd26](b45dd26)) * Renamed `nargoVersion` as `compatibleNargoVersion` ([#2338](#2338)) ([6f9e0f1](6f9e0f1)) ### Bug Fixes * Add retry around docker login and revive spot_run_test_script ([#2346](#2346)) ([79e5f05](79e5f05)) * Unbox command. ([#2337](#2337)) ([e9bc9c6](e9bc9c6)) ### Miscellaneous * Increase guides-dapp-testing test timeout ([#2343](#2343)) ([1cebe2c](1cebe2c)) * Use retries by default on rpc client fetch ([#2342](#2342)) ([f4ffd68](f4ffd68)) </details> <details><summary>barretenberg.js: 0.7.5</summary> ## [0.7.5](barretenberg.js-v0.7.4...barretenberg.js-v0.7.5) (2023-09-15) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.7.5</summary> ## [0.7.5](barretenberg-v0.7.4...barretenberg-v0.7.5) (2023-09-15) ### Features * Protogalaxy interfaces ([#2125](#2125)) ([b45dd26](b45dd26)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that used the default
fetchimplementation with retries (likeguides-sample-dapp) were failing due to connection issues. This PR changes the default fetch to always retry 3 times, which was what were manually configuring in most scenarios.