Skip to content

Commit

Permalink
feat: renamed nargoVersion as compatibleNargoVersion (#2338)
Browse files Browse the repository at this point in the history
Renamed `nargoVersion` as `compatibleNargoVersion` and it now shows tag
instead of commit. This was necessary for `noirup` to install pre-built
version.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
  • Loading branch information
benesjan authored Sep 15, 2023
1 parent e9bc9c6 commit 6f9e0f1
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ export class AztecRPCServer implements AztecRPC {
chainId,
rollupAddress,
client: this.clientInfo,
nargoVersion: NoirVersion.commit,
compatibleNargoVersion: NoirVersion.tag,
};
}

Expand Down
2 changes: 1 addition & 1 deletion yarn-project/aztec.js/src/contract/contract.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('Contract Class', () => {
chainId: 2,
rollupAddress: EthAddress.random(),
client: '',
nargoVersion: 'sdlhahf823',
compatibleNargoVersion: 'vx.x.x-aztec.x',
};

const defaultAbi: ContractAbi = {
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/end-to-end/src/e2e_cli.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('CLI e2e test', () => {
logs.push(format(...args));
debug(...args);
};
});
}, 30_000);

afterAll(async () => {
await cleanup();
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/types/src/interfaces/aztec_rpc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export type NodeInfo = {
/**
* The nargo version compatible with this node.
*/
nargoVersion: string;
compatibleNargoVersion: string;
};

/** Provides up to which block has been synced by different components. */
Expand Down

0 comments on commit 6f9e0f1

Please sign in to comment.