Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create script that extracts the correct version from a commit tag #2058

Closed
spypsy opened this issue Sep 6, 2023 · 0 comments · Fixed by #2368
Closed

Create script that extracts the correct version from a commit tag #2058

spypsy opened this issue Sep 6, 2023 · 0 comments · Fixed by #2368
Assignees
@spypsy

Comments

@spypsy
Copy link
Member

spypsy commented Sep 6, 2023 •
edited
Loading

There is a check we perform in multiple places in build-system, which is used to take a COMMIT_TAG, check if it's specific to a repo (e.g. aztec-node/v0.1.0-alpha33) and whether we're building tha repo, checks if it's a valid semver, and finally extract the version (e.g. 0.1.0-alpha33).
We should create an external function (extract_version) that can be used in all these places
@spypsy spypsy added this to A3 Sep 6, 2023
@spypsy spypsy converted this from a draft issue Sep 6, 2023
@spypsy spypsy self-assigned this Sep 6, 2023
@spypsy spypsy mentioned this issue Sep 18, 2023
Merged
4 tasks
spypsy added a commit that referenced this issue Sep 18, 2023
@spypsy
chore: script to extract tag version (#2368)
4b686b0 
Fixes #2058
This should mean that versioning is consistent across the board, using
semver format (e.g. `0.7.5` with **no** leading `v`)
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spypsy spypsy

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: script to extract tag version AztecProtocol/aztec-packages
1 participant
@spypsy